Re: [U-Boot] [PATCH v1 1/2] common: fdt_support: add support for setting usable memory
Hi Stefano,
On Mon, Oct 14, 2019 at 3:40 PM sbabic@denx.de wrote:
From: Igor Opaniuk igor.opaniuk@toradex.com Add support for setting linux,usable-memory property in the memory node of device tree for the kernel [1]. This property holds a base address and size, describing a limited region in which memory may be considered available for use by the kernel. Memory outside of this range is not available for use. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/chosen.txt Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com Signed-off-by: Sanchayan Maity maitysanchayan@gmail.com Signed-off-by: Stefan Agner stefan.agner@toradex.com Signed-off-by: Igor Opaniuk igor.opaniuk@gmail.com Reviewed-by: Oleksandr Suvorov oleksandr.suvorov@toradex.com
Applied to u-boot-imx, master, thanks !
Unfortunately I can't find this commit neither in u-boot-imx/next neither in u-boot-imx/master.
Best regards, Stefano Babic
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================
Hi Igor,
On 28/11/19 16:23, Igor Opaniuk wrote:
Hi Stefano,
On Mon, Oct 14, 2019 at 3:40 PM sbabic@denx.de wrote:
From: Igor Opaniuk igor.opaniuk@toradex.com Add support for setting linux,usable-memory property in the memory node of device tree for the kernel [1]. This property holds a base address and size, describing a limited region in which memory may be considered available for use by the kernel. Memory outside of this range is not available for use. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/chosen.txt Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com Signed-off-by: Sanchayan Maity maitysanchayan@gmail.com Signed-off-by: Stefan Agner stefan.agner@toradex.com Signed-off-by: Igor Opaniuk igor.opaniuk@gmail.com Reviewed-by: Oleksandr Suvorov oleksandr.suvorov@toradex.com
Applied to u-boot-imx, master, thanks !
Unfortunately I can't find this commit neither in u-boot-imx/next neither in u-boot-imx/master.
Added again, and I have found that this breaks all boards where CONFIG_ARCH_FIXUP_FDT_MEMORY is not set.
In fact, your new function calls fdt_pack_reg and this is not compiled if the define above is not set. Just ask if it does not make sense to let fdt_pack_reg() be always compiled...
Best regards, Stefano Babic
Hi Stefano,
On Tue, Dec 3, 2019 at 11:28 AM Stefano Babic sbabic@denx.de wrote:
Hi Igor,
On 28/11/19 16:23, Igor Opaniuk wrote:
Hi Stefano,
On Mon, Oct 14, 2019 at 3:40 PM sbabic@denx.de wrote:
From: Igor Opaniuk igor.opaniuk@toradex.com Add support for setting linux,usable-memory property in the memory node of device tree for the kernel [1]. This property holds a base address and size, describing a limited region in which memory may be considered available for use by the kernel. Memory outside of this range is not available for use. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/chosen.txt Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com Signed-off-by: Sanchayan Maity maitysanchayan@gmail.com Signed-off-by: Stefan Agner stefan.agner@toradex.com Signed-off-by: Igor Opaniuk igor.opaniuk@gmail.com Reviewed-by: Oleksandr Suvorov oleksandr.suvorov@toradex.com
Applied to u-boot-imx, master, thanks !
Unfortunately I can't find this commit neither in u-boot-imx/next neither in u-boot-imx/master.
Added again, and I have found that this breaks all boards where CONFIG_ARCH_FIXUP_FDT_MEMORY is not set.
In fact, your new function calls fdt_pack_reg and this is not compiled if the define above is not set. Just ask if it does not make sense to let fdt_pack_reg() be always compiled...
Thanks for reporting, the fix is here [1]
[1] https://patchwork.ozlabs.org/project/uboot/list/?series=146241
Best regards, Stefano Babic
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================
participants (2)
-
Igor Opaniuk -
Stefano Babic