[U-Boot] [PATCH] Less verbose output when loading vxworks 6.x images
Loading vxWorks 5.x images resulted just into 3 or 4 lines of output. With vxWorks 6.x and the new GCC it emits about 30 lines, which is far too noisy in my opinion.
Signed-off-by: Niklaus Giger niklaus.giger@member.fsf.org --- common/cmd_elf.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/common/cmd_elf.c b/common/cmd_elf.c index abec7dd..0842ce9 100644 --- a/common/cmd_elf.c +++ b/common/cmd_elf.c @@ -286,6 +286,7 @@ unsigned long load_elf_image (unsigned long addr) continue; }
+#ifdef DEBUG if (strtab) { printf ("%sing %s @ 0x%08lx (%ld bytes)\n", (shdr->sh_type == SHT_NOBITS) ? @@ -294,6 +295,7 @@ unsigned long load_elf_image (unsigned long addr) (unsigned long) shdr->sh_addr, (long) shdr->sh_size); } +#endif
if (shdr->sh_type == SHT_NOBITS) { memset ((void *)shdr->sh_addr, 0, shdr->sh_size);
On Wed 22 Jul 2009 15:32, Niklaus Giger pondered:
Loading vxWorks 5.x images resulted just into 3 or 4 lines of output. With vxWorks 6.x and the new GCC it emits about 30 lines, which is far too noisy in my opinion.
Signed-off-by: Niklaus Giger niklaus.giger@member.fsf.org
common/cmd_elf.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/common/cmd_elf.c b/common/cmd_elf.c index abec7dd..0842ce9 100644 --- a/common/cmd_elf.c +++ b/common/cmd_elf.c @@ -286,6 +286,7 @@ unsigned long load_elf_image (unsigned long addr) continue; }
+#ifdef DEBUG if (strtab) { printf ("%sing %s @ 0x%08lx (%ld bytes)\n", (shdr->sh_type == SHT_NOBITS) ? @@ -294,6 +295,7 @@ unsigned long load_elf_image (unsigned long addr) (unsigned long) shdr->sh_addr, (long) shdr->sh_size); } +#endif
if (shdr->sh_type == SHT_NOBITS) { memset ((void *)shdr->sh_addr, 0,shdr->sh_size);
its better to remove the ifdef, and replace the printf() with debug() (IMHO).
Dear Niklaus Giger,
In message 200907221629.09703.rgetz@blackfin.uclinux.org Robin Getz wrote:
+#ifdef DEBUG if (strtab) { printf ("%sing %s @ 0x%08lx (%ld bytes)\n", (shdr->sh_type == SHT_NOBITS) ? @@ -294,6 +295,7 @@ unsigned long load_elf_image (unsigned long addr) (unsigned long) shdr->sh_addr, (long) shdr->sh_size); } +#endif
if (shdr->sh_type == SHT_NOBITS) { memset ((void *)shdr->sh_addr, 0,shdr->sh_size);
its better to remove the ifdef, and replace the printf() with debug() (IMHO).
Best regards,
Wolfgang Denk
participants (3)
-
Niklaus Giger -
Robin Getz -
Wolfgang Denk