[U-Boot] [PATCH] x86: Eliminate make defconfig warning for Crown Bay and Minnowmax
Remove duplicated entry of OF_CONTROL in crownbay_defconfig and minnowmax_defconfig which causes a warning when making defconfig. The updated defconfig files are generated by 'make savedefconfig'.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
configs/crownbay_defconfig | 14 ++++++-------- configs/minnowmax_defconfig | 6 ++---- 2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig index c906883..17e6a72 100644 --- a/configs/crownbay_defconfig +++ b/configs/crownbay_defconfig @@ -4,7 +4,10 @@ CONFIG_DEFAULT_DEVICE_TREE="crownbay" CONFIG_TARGET_CROWNBAY=y CONFIG_SMP=y CONFIG_MAX_CPUS=2 +CONFIG_HAVE_VGA_BIOS=y CONFIG_GENERATE_PIRQ_TABLE=y +CONFIG_GENERATE_MP_TABLE=y +CONFIG_CMD_CPU=y # CONFIG_CMD_IMLS is not set # CONFIG_CMD_FLASH is not set # CONFIG_CMD_SETEXPR is not set @@ -13,15 +16,10 @@ CONFIG_BOOTSTAGE=y CONFIG_BOOTSTAGE_REPORT=y CONFIG_CMD_BOOTSTAGE=y CONFIG_OF_CONTROL=y -CONFIG_SPI_FLASH=y -CONFIG_USE_PRIVATE_LIBGCC=y -CONFIG_SYS_VSNPRINTF=y -CONFIG_HAVE_VGA_BIOS=y -CONFIG_GENERATE_MP_TABLE=y -CONFIG_CMD_CPU=y -CONFIG_CMD_NET=y -CONFIG_OF_CONTROL=y CONFIG_CPU=y +CONFIG_SPI_FLASH=y CONFIG_VIDEO_VESA=y CONFIG_FRAMEBUFFER_SET_VESA_MODE=y CONFIG_DM_RTC=y +CONFIG_USE_PRIVATE_LIBGCC=y +CONFIG_SYS_VSNPRINTF=y diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig index 582d6cc..29dd44b 100644 --- a/configs/minnowmax_defconfig +++ b/configs/minnowmax_defconfig @@ -3,8 +3,8 @@ CONFIG_VENDOR_INTEL=y CONFIG_DEFAULT_DEVICE_TREE="minnowmax" CONFIG_TARGET_MINNOWMAX=y CONFIG_HAVE_INTEL_ME=y -CONFIG_HAVE_VGA_BIOS=y CONFIG_SMP=y +CONFIG_HAVE_VGA_BIOS=y CONFIG_GENERATE_SFI_TABLE=y CONFIG_CMD_CPU=y # CONFIG_CMD_IMLS is not set @@ -16,12 +16,10 @@ CONFIG_BOOTSTAGE_REPORT=y CONFIG_CMD_BOOTSTAGE=y CONFIG_OF_CONTROL=y CONFIG_CPU=y +CONFIG_DM_PCI=y CONFIG_SPI_FLASH=y CONFIG_VIDEO_VESA=y CONFIG_FRAMEBUFFER_SET_VESA_MODE=y CONFIG_FRAMEBUFFER_VESA_MODE_11A=y CONFIG_USE_PRIVATE_LIBGCC=y CONFIG_SYS_VSNPRINTF=y -CONFIG_CMD_NET=y -CONFIG_OF_CONTROL=y -CONFIG_DM_PCI=y
Hi Bin,
On 8 July 2015 at 07:50, Bin Meng bmeng.cn@gmail.com wrote:
Remove duplicated entry of OF_CONTROL in crownbay_defconfig and minnowmax_defconfig which causes a warning when making defconfig. The updated defconfig files are generated by 'make savedefconfig'.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
configs/crownbay_defconfig | 14 ++++++-------- configs/minnowmax_defconfig | 6 ++---- 2 files changed, 8 insertions(+), 12 deletions(-)
I've incorporated this into the offending patches in x86/master. Please take a look and let me know what you think. I'd rather avoid strange errors in the tree, even tools/genboardscfg.py.
Regards, Simon
Hi Simon,
On Thu, Jul 9, 2015 at 4:28 AM, Simon Glass sjg@chromium.org wrote:
Hi Bin,
On 8 July 2015 at 07:50, Bin Meng bmeng.cn@gmail.com wrote:
Remove duplicated entry of OF_CONTROL in crownbay_defconfig and minnowmax_defconfig which causes a warning when making defconfig. The updated defconfig files are generated by 'make savedefconfig'.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
configs/crownbay_defconfig | 14 ++++++-------- configs/minnowmax_defconfig | 6 ++---- 2 files changed, 8 insertions(+), 12 deletions(-)
I've incorporated this into the offending patches in x86/master. Please take a look and let me know what you think. I'd rather avoid strange errors in the tree, even tools/genboardscfg.py.
It looks good. But the order does not match 'savedefconfig', like what I did in this patch. I've tested all 7 x86 boards, and found only these two have this ordering issue. I am not sure if this issue is now a must as I see the mainline seems all defconfigs are updated.
Regards, Bin
Hi Bin,
On 8 July 2015 at 18:17, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Thu, Jul 9, 2015 at 4:28 AM, Simon Glass sjg@chromium.org wrote:
Hi Bin,
On 8 July 2015 at 07:50, Bin Meng bmeng.cn@gmail.com wrote:
Remove duplicated entry of OF_CONTROL in crownbay_defconfig and minnowmax_defconfig which causes a warning when making defconfig. The updated defconfig files are generated by 'make savedefconfig'.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
configs/crownbay_defconfig | 14 ++++++-------- configs/minnowmax_defconfig | 6 ++---- 2 files changed, 8 insertions(+), 12 deletions(-)
I've incorporated this into the offending patches in x86/master. Please take a look and let me know what you think. I'd rather avoid strange errors in the tree, even tools/genboardscfg.py.
It looks good. But the order does not match 'savedefconfig', like what I did in this patch. I've tested all 7 x86 boards, and found only these two have this ordering issue. I am not sure if this issue is now a must as I see the mainline seems all defconfigs are updated.
If you like you could send a new patch to fix the order?
Regards, Simon
participants (2)
-
Bin Meng -
Simon Glass