Currently, vsc8541_config does not account for cases where RGMII mode with internal delays on TX, RX or both are selected, even though the device supports that functionality. Instead, it returns an error when "rgmii-id", "rgmii-txid" or "rgmii-rxid" is selected in its corresponding DT node.

Fix by adding missing RGMII internal delay modes to list of fall-through cases so that when configured with modes "rgmii-id", "rgmii-txid" or "rgmii-rxid", the internal delay registers get updated correctly in vsc8531_vsc8541_clk_skew_config().

Signed-off-by: Ryan Shimizu ryan.shimizu@viasat.com ---

drivers/net/phy/mscc.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index bd9cd95297..7263887b9c 100644 --- a/drivers/net/phy/mscc.c +++ b/drivers/net/phy/mscc.c @@ -1371,6 +1371,9 @@ static int vsc8541_config(struct phy_device *phydev) case PHY_INTERFACE_MODE_GMII: case PHY_INTERFACE_MODE_RMII: case PHY_INTERFACE_MODE_RGMII: + case PHY_INTERFACE_MODE_RGMII_TXID: + case PHY_INTERFACE_MODE_RGMII_RXID: + case PHY_INTERFACE_MODE_RGMII_ID: retval = vsc8531_vsc8541_mac_config(phydev); if (retval != 0) return retval; -- 2.34.1