[U-Boot-Users] [PATCH 0/1] Fix warning: passing argument 1 of 'move64' discards qualifiers from pointer target type
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/post/drivers/memory.c b/post/drivers/memory.c index fbc349a..bf16157 100644 --- a/post/drivers/memory.c +++ b/post/drivers/memory.c @@ -207,7 +207,7 @@ static void move64(unsigned long long *src, unsigned long long *dest) * than the test pattern. This is for detecting floating bus lines. * */ -const static unsigned long long pattern[] = { +static unsigned long long pattern[] = { 0xaaaaaaaaaaaaaaaaULL, 0xccccccccccccccccULL, 0xf0f0f0f0f0f0f0f0ULL, @@ -221,7 +221,7 @@ const static unsigned long long pattern[] = { 0x3333333333333333ULL, 0x5555555555555555ULL }; -const unsigned long long otherpattern = 0x0123456789abcdefULL; +unsigned long long otherpattern = 0x0123456789abcdefULL;
static int memory_post_dataline(unsigned long long * pmem)
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/board/esd/canbt/canbt.c b/board/esd/canbt/canbt.c index 055a397..e0f9c57 100644 --- a/board/esd/canbt/canbt.c +++ b/board/esd/canbt/canbt.c @@ -39,7 +39,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]); #endif
/* fpga configuration data */ -const unsigned char fpgadata[] = { +unsigned char fpgadata[] = { #include "fpgadata.c" };
diff --git a/board/esd/cpci405/cpci405.c b/board/esd/cpci405/cpci405.c index 69cb8ce..059c48a 100644 --- a/board/esd/cpci405/cpci405.c +++ b/board/esd/cpci405/cpci405.c @@ -37,7 +37,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]); /*cmd_ #endif
/* fpga configuration data - generated by bin2cc */ -const unsigned char fpgadata[] = +unsigned char fpgadata[] = { #ifdef CONFIG_CPCI405_VER2 # ifdef CONFIG_CPCI405AB diff --git a/board/esd/cpciiser4/cpciiser4.c b/board/esd/cpciiser4/cpciiser4.c index fcb8cbb..c4f5d09 100644 --- a/board/esd/cpciiser4/cpciiser4.c +++ b/board/esd/cpciiser4/cpciiser4.c @@ -45,7 +45,7 @@ extern void lxt971_no_sleep(void); #endif
/* fpga configuration data - generated by bin2cc */ -const unsigned char fpgadata[] = { +unsigned char fpgadata[] = { #include "fpgadata.c" };
diff --git a/board/esd/du405/du405.c b/board/esd/du405/du405.c index 6943213..9450cda 100644 --- a/board/esd/du405/du405.c +++ b/board/esd/du405/du405.c @@ -45,7 +45,7 @@ extern void lxt971_no_sleep(void); #endif
/* fpga configuration data - generated by bin2cc */ -const unsigned char fpgadata[] = { +unsigned char fpgadata[] = { #include "fpgadata.c" };
In message 1195504030-17994-2-git-send-email-plagnioj@jcrosoft.com you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/board/esd/canbt/canbt.c b/board/esd/canbt/canbt.c index 055a397..e0f9c57 100644 --- a/board/esd/canbt/canbt.c +++ b/board/esd/canbt/canbt.c @@ -39,7 +39,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]); #endif
/* fpga configuration data */ -const unsigned char fpgadata[] = { +unsigned char fpgadata[] = { #include "fpgadata.c" };
diff --git a/board/esd/cpci405/cpci405.c b/board/esd/cpci405/cpci405.c index 69cb8ce..059c48a 100644 --- a/board/esd/cpci405/cpci405.c +++ b/board/esd/cpci405/cpci405.c @@ -37,7 +37,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]); /*cmd_ #endif
/* fpga configuration data - generated by bin2cc */ -const unsigned char fpgadata[] = +unsigned char fpgadata[] = { #ifdef CONFIG_CPCI405_VER2 # ifdef CONFIG_CPCI405AB diff --git a/board/esd/cpciiser4/cpciiser4.c b/board/esd/cpciiser4/cpciiser4.c index fcb8cbb..c4f5d09 100644 --- a/board/esd/cpciiser4/cpciiser4.c +++ b/board/esd/cpciiser4/cpciiser4.c @@ -45,7 +45,7 @@ extern void lxt971_no_sleep(void); #endif
/* fpga configuration data - generated by bin2cc */ -const unsigned char fpgadata[] = { +unsigned char fpgadata[] = { #include "fpgadata.c" };
diff --git a/board/esd/du405/du405.c b/board/esd/du405/du405.c index 6943213..9450cda 100644 --- a/board/esd/du405/du405.c +++ b/board/esd/du405/du405.c @@ -45,7 +45,7 @@ extern void lxt971_no_sleep(void); #endif
/* fpga configuration data - generated by bin2cc */ -const unsigned char fpgadata[] = { +unsigned char fpgadata[] = { #include "fpgadata.c" };
May I ask what your rationale is for these changes? This *is* constant data, so why do you make these changes?
Best regards,
Wolfgang Denk
In message 1195504030-17994-1-git-send-email-plagnioj@jcrosoft.com you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/post/drivers/memory.c b/post/drivers/memory.c index fbc349a..bf16157 100644 --- a/post/drivers/memory.c +++ b/post/drivers/memory.c @@ -207,7 +207,7 @@ static void move64(unsigned long long *src, unsigned long long *dest)
- than the test pattern. This is for detecting floating bus lines.
*/ -const static unsigned long long pattern[] = { +static unsigned long long pattern[] = { 0xaaaaaaaaaaaaaaaaULL, 0xccccccccccccccccULL, 0xf0f0f0f0f0f0f0f0ULL, @@ -221,7 +221,7 @@ const static unsigned long long pattern[] = { 0x3333333333333333ULL, 0x5555555555555555ULL }; -const unsigned long long otherpattern = 0x0123456789abcdefULL; +unsigned long long otherpattern = 0x0123456789abcdefULL;
This patch seems technically wrong to me. This data *is* constant.
Best regards,
Wolfgang Denk
participants (2)
-
Jean-Christophe PLAGNIOL-VILLARD -
Wolfgang Denk