Re: [U-Boot] [PATCH v5] nds32: Add NDS32 architecture support (header files)
Hi, Macpual
On Thu, Nov 25, 2010 at 11:12 AM, macpaul@andestech.com wrote:
Is the series of patches (v1 to v5) increamental ? Should I apply v1 first, and then v2, v3, till v5 ? If so, what is base revision to which v1 patch is applied ? Thanks for your help. MorganLet me explain for you, the patch version v1 to v5 just tagged for the revision for the same single "patch". So you just need to apply the latest patch you have. Please do not take care about the v1-v4 patches. The latest patch includes the latest update against to the main trunk (master) source code.
The patch V5 includes only some arch-depedent header files. Should I apply any previous patches ?
If you have furthor questions, please reply on the mailing list.
Hope we can work this out together.
On Fri, Nov 19, 2010 at 1:51 PM, Macpaul Lin <macpaul@andestech.com> wrote:
This patch add generic header files support for nds32architecture.
Cache, ptregs, data type and other definitions areincluded.
NDS32 is a new 32-bit RISC architecture invented byandestech.com.
NDS32 also provide N9, N10, N12 different CPU core familiesfor soft-core
and hard-core SoC design.Note: Empty headers such as config.h, memory.h, processor.h arenecessary for
compiling some device drivers. Otherwise those drivers won't be build.Best regards, Macpaul Lin
Hi Ming-Dien,
2010/12/14 Ming-Dien Chang mingdien.chang@gmail.com
Hi, Macpual
On Thu, Nov 25, 2010 at 11:12 AM, macpaul@andestech.com wrote:
Is the series of patches (v1 to v5) increamental ? Should I apply v1 first, and then v2, v3, till v5 ? If so, what is base revision to which v1 patch is applied ? Thanks for your help. MorganLet me explain for you, the patch version v1 to v5 just tagged for the revision for the same single "patch". So you just need to apply the latest patch you have. Please do not take care about the v1-v4 patches. The latest patch includes the latest update against to the main trunk (master) source code.
The patch V5 includes only some arch-depedent header files. Should I apply any previous patches ?
Yes, patch v5 only send the header file which the code is clean and might no need to be modified before it has been reviewed.
Other patches will be send individually after they have be clean since the patch might need to be revise in the future. However, those continuous patches related to cpu core and boards which might need be revised should not affect the "only" header file send out in v5.
If you really wan't to try the prior patches, you could try patch v4. However, I suggest do not do that because if you develop your u-boot code based on NDS32 patch v4, you will have a lot of clean up work to do later. The more clean up work, the more pain of your work and your company will be suffered. ;-p.
Otherwise, if your company doesn't want to open your u-boot's source code nor want to be include in the u-boot main source tree. Or you just want to try something with NDS32 "just" worked. You can apply patch v3 or patch v4 should be okay.
Hi, Macpaul
Yes, patch v5 only send the header file which the code is clean and might no
need to be modified before it has been reviewed.
Other patches will be send individually after they have be clean since the patch might need to be revise in the future. However, those continuous patches related to cpu core and boards which might need be revised should not affect the "only" header file send out in v5.
I got confused for some things:
1. The v5 patch published so far is not complete, and other parts of v5 patch will be released later !? 2. Or, the header-only patch is applicable to the master tree according to the "Changes for v5" !? However, neither the master tree nor nds32 frok contains the nds32-specific code.
Thanks for your help.
Best Regards, Morgan
Hi Ming-Dien
2010/12/16 Ming-Dien Chang mingdien.chang@gmail.com:
Hi, Macpaul
Yes, patch v5 only send the header file which the code is clean and might no need to be modified before it has been reviewed. Other patches will be send individually after they have be clean since the patch might need to be revise in the future. However, those continuous patches related to cpu core and boards which might need be revised should not affect the "only" header file send out in v5.
I got confused for some things:
- The v5 patch published so far is not complete, and other parts of v5
patch will be released later !?
Yes, due to some code is under written. Patch v5 has released the most basic header files right now.
- Or, the header-only patch is applicable to the master tree according to
the "Changes for v5" !?
No, only clean code which has been reviewed will be put into master tree or nds32 tree. Those commits which has been accepted will go into nds32 tree first, and then be merged into master tree.
However, neither the master tree nor nds32 frok contains the nds32-specific code.
Thanks for your help.
It's my pleasure. :)
Best Regards, Morgan
participants (2)
-
Macpaul Lin -
Ming-Dien Chang