[Patch v3 0/3] Enable octal read support for mt35xu* flashes
Patch series enable octal read(1-1-8) support for LX2160ARDB/QDS and LS1028ARDB/QDS which have mt35xu512aba and mt35xu02g flashes respectively.
mt35xu512aba and mt35xu02g flashes support SINGLE and OCTAL I/O. Previously, 1 bit mode was used in u-boot and now use octal mode for the flashes.
Patch 1 enables octal read flag for flashes in framework. Patch 2/3 adds RX,TX buswidth in flexspi dts entries to use octal mode for LS1028ARDB/QDS, LX2160ARDB/QDS.
v3: -Patch 3 has dependency on https://patchwork.ozlabs.org/patch/1247579/. -Reword commit message for patch 2/3.
v2: -Update dependencies of the patches -Add lx2160aqds node buswidth in patch3. -Patch3 has dependency on https://patchwork.ozlabs.org/patch/1236164/.
Kuldeep Singh (3): mtd: spi-nor-ids: Enable SPI_NOR_OCTAL_READ flag for mt35xu* arm: dts: ls1028a: Use flexspi in octal I/O mode arm: dts: lx2160a: Use flexspi in octal I/O mode
arch/arm/dts/fsl-ls1028a-qds.dts | 2 ++ arch/arm/dts/fsl-ls1028a-rdb.dts | 2 ++ arch/arm/dts/fsl-lx2160a-qds.dts | 2 ++ arch/arm/dts/fsl-lx2160a-rdb.dts | 4 ++++ drivers/mtd/spi/spi-nor-ids.c | 4 ++-- 5 files changed, 12 insertions(+), 2 deletions(-)
Commit 658df8bd9464 ("mtd: spi-nor-core: Add octal mode support") enables octal mode(1-1-8) support in spi-nor framework.
mt35xu512aba and mt35xu02g supports SINGLE and OCTAL I/O. Hence, enable SPI_NOR_OCTAL_READ flag for these flashes.
Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com Reviewed-by: Vignesh Raghavendra vigneshr@ti.com --- v3: No change v2: Reword commit message
drivers/mtd/spi/spi-nor-ids.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 973b6f8..334c074 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -182,8 +182,8 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, - { INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR | SPI_NOR_4B_OPCODES) }, - { INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR | SPI_NOR_4B_OPCODES) }, + { INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ /* Spansion/Cypress -- single (large) sector size only, at least
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Kuldeep Singh Sent: Saturday, March 14, 2020 6:24 PM To: Priyanka Jain priyanka.jain@nxp.com; Jagan Teki jagan@amarulasolutions.com; Vignesh R vigneshr@ti.com; u- boot@lists.denx.de Cc: Kuldeep Singh kuldeep.singh@nxp.com Subject: [Patch v3 1/3] mtd: spi-nor-ids: Enable SPI_NOR_OCTAL_READ flag for mt35xu*
Commit 658df8bd9464 ("mtd: spi-nor-core: Add octal mode support") enables octal mode(1-1-8) support in spi-nor framework.
mt35xu512aba and mt35xu02g supports SINGLE and OCTAL I/O. Hence, enable SPI_NOR_OCTAL_READ flag for these flashes.
Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com Reviewed-by: Vignesh Raghavendra vigneshr@ti.com
v3: No change v2: Reword commit message
drivers/mtd/spi/spi-nor-ids.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 973b6f8..334c074 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -182,8 +182,8 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
- { INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR |
SPI_NOR_4B_OPCODES) },
- { INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR |
SPI_NOR_4B_OPCODES) },
- { INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR |
SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
- { INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR |
+SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ /* Spansion/Cypress -- single (large) sector size only, at least -- 2.7.4
Reviewed-by: Priyanka Jain priyanka.jain@nxp.com Jagan,
Please help to pick this patch or provide ack.
Thanks Priyanka
On Wed, Mar 18, 2020 at 4:26 PM Priyanka Jain (OSS) priyanka.jain@oss.nxp.com wrote:
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Kuldeep Singh Sent: Saturday, March 14, 2020 6:24 PM To: Priyanka Jain priyanka.jain@nxp.com; Jagan Teki jagan@amarulasolutions.com; Vignesh R vigneshr@ti.com; u- boot@lists.denx.de Cc: Kuldeep Singh kuldeep.singh@nxp.com Subject: [Patch v3 1/3] mtd: spi-nor-ids: Enable SPI_NOR_OCTAL_READ flag for mt35xu*
Commit 658df8bd9464 ("mtd: spi-nor-core: Add octal mode support") enables octal mode(1-1-8) support in spi-nor framework.
mt35xu512aba and mt35xu02g supports SINGLE and OCTAL I/O. Hence, enable SPI_NOR_OCTAL_READ flag for these flashes.
Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com Reviewed-by: Vignesh Raghavendra vigneshr@ti.com
v3: No change v2: Reword commit message
drivers/mtd/spi/spi-nor-ids.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 973b6f8..334c074 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -182,8 +182,8 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
{ INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR |SPI_NOR_4B_OPCODES) },
{ INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR |SPI_NOR_4B_OPCODES) },
{ INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR |SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
{ INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR |+SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ /* Spansion/Cypress -- single (large) sector size only, at least -- 2.7.4
Reviewed-by: Priyanka Jain priyanka.jain@nxp.com Jagan,
Please help to pick this patch or provide ack.
Yes I marked it to pick after MW.
Jagan.
On Sat, Mar 14, 2020 at 6:24 PM Kuldeep Singh kuldeep.singh@nxp.com wrote:
Commit 658df8bd9464 ("mtd: spi-nor-core: Add octal mode support") enables octal mode(1-1-8) support in spi-nor framework.
mt35xu512aba and mt35xu02g supports SINGLE and OCTAL I/O. Hence, enable SPI_NOR_OCTAL_READ flag for these flashes.
Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com Reviewed-by: Vignesh Raghavendra vigneshr@ti.com
Applied to u-boot-spi/master
Configure RX and TX bus-width values to use flexspi in octal I/O mode. If bus-widths are not specified, then single I/O mode is set by default.
Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com --- v3: Reword commit message. v2: No change.
arch/arm/dts/fsl-ls1028a-qds.dts | 2 ++ arch/arm/dts/fsl-ls1028a-rdb.dts | 2 ++ 2 files changed, 4 insertions(+)
diff --git a/arch/arm/dts/fsl-ls1028a-qds.dts b/arch/arm/dts/fsl-ls1028a-qds.dts index 3fd37be..029a8e3 100644 --- a/arch/arm/dts/fsl-ls1028a-qds.dts +++ b/arch/arm/dts/fsl-ls1028a-qds.dts @@ -49,6 +49,8 @@ compatible = "jedec,spi-nor"; spi-max-frequency = <50000000>; reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <1>; }; };
diff --git a/arch/arm/dts/fsl-ls1028a-rdb.dts b/arch/arm/dts/fsl-ls1028a-rdb.dts index a8f4085..85b4815 100644 --- a/arch/arm/dts/fsl-ls1028a-rdb.dts +++ b/arch/arm/dts/fsl-ls1028a-rdb.dts @@ -48,6 +48,8 @@ compatible = "jedec,spi-nor"; spi-max-frequency = <50000000>; reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <1>; }; };
Configure RX and TX bus-width values to use flexspi in octal I/O mode. If bus-widths are not specified, then single I/O mode is set by default.
Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com --- v3: Reword commit message. v2: No change.
arch/arm/dts/fsl-lx2160a-qds.dts | 2 ++ arch/arm/dts/fsl-lx2160a-rdb.dts | 4 ++++ 2 files changed, 6 insertions(+)
diff --git a/arch/arm/dts/fsl-lx2160a-qds.dts b/arch/arm/dts/fsl-lx2160a-qds.dts index 33bedae..592fd59 100644 --- a/arch/arm/dts/fsl-lx2160a-qds.dts +++ b/arch/arm/dts/fsl-lx2160a-qds.dts @@ -58,6 +58,8 @@ compatible = "jedec,spi-nor"; spi-max-frequency = <50000000>; reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <1>; }; };
diff --git a/arch/arm/dts/fsl-lx2160a-rdb.dts b/arch/arm/dts/fsl-lx2160a-rdb.dts index e542c69..87617ca 100644 --- a/arch/arm/dts/fsl-lx2160a-rdb.dts +++ b/arch/arm/dts/fsl-lx2160a-rdb.dts @@ -39,6 +39,8 @@ compatible = "jedec,spi-nor"; spi-max-frequency = <50000000>; reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <1>; };
mt35xu512aba1: flash@1 { @@ -47,6 +49,8 @@ compatible = "jedec,spi-nor"; spi-max-frequency = <50000000>; reg = <1>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <1>; }; };
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Kuldeep Singh Sent: Saturday, March 14, 2020 6:24 PM To: Priyanka Jain priyanka.jain@nxp.com; Jagan Teki jagan@amarulasolutions.com; Vignesh R vigneshr@ti.com; u- boot@lists.denx.de Cc: Kuldeep Singh kuldeep.singh@nxp.com Subject: [Patch v3 3/3] arm: dts: lx2160a: Use flexspi in octal I/O mode
Configure RX and TX bus-width values to use flexspi in octal I/O mode. If bus-widths are not specified, then single I/O mode is set by default.
Signed-off-by: Kuldeep Singh kuldeep.singh@nxp.com
2/3, 3/3 Applied to u-boot-fsl-qoriq. Waiting upstream
Thanks Priyanka
participants (3)
-
Jagan Teki -
Kuldeep Singh -
Priyanka Jain (OSS)