[U-Boot] [PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig
The config name enabling the rk3399-pinctrl driver is spelled wrong, so it does not get built. This causes SPL to fail during board init.
Make rk3399-firefly boot by enabling the pinctrl driver via the correct config name.
Signed-off-by: Alex Hixon alex@alexhixon.com --- configs/firefly-rk3399_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig index f30f131f34..0a4d005975 100644 --- a/configs/firefly-rk3399_defconfig +++ b/configs/firefly-rk3399_defconfig @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y CONFIG_PINCTRL=y CONFIG_SPL_PINCTRL=y -CONFIG_ROCKCHIP_RK3399_PINCTRL=y +CONFIG_PINCTRL_ROCKCHIP_RK3399=y CONFIG_DM_PMIC=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y
On Mon, May 15, 2017 at 10:01:32PM +1000, Alex Hixon wrote:
The config name enabling the rk3399-pinctrl driver is spelled wrong, so it does not get built. This causes SPL to fail during board init.
Make rk3399-firefly boot by enabling the pinctrl driver via the correct config name.
Signed-off-by: Alex Hixon alex@alexhixon.com
configs/firefly-rk3399_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig index f30f131f34..0a4d005975 100644 --- a/configs/firefly-rk3399_defconfig +++ b/configs/firefly-rk3399_defconfig @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y CONFIG_PINCTRL=y CONFIG_SPL_PINCTRL=y -CONFIG_ROCKCHIP_RK3399_PINCTRL=y +CONFIG_PINCTRL_ROCKCHIP_RK3399=y CONFIG_DM_PMIC=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y
Shouldn't the RK3399 pinctrl driver at least by default y? Or imply'd ?
On 15 May 2017 at 06:30, Tom Rini trini@konsulko.com wrote:
On Mon, May 15, 2017 at 10:01:32PM +1000, Alex Hixon wrote:
The config name enabling the rk3399-pinctrl driver is spelled wrong, so it does not get built. This causes SPL to fail during board init.
Make rk3399-firefly boot by enabling the pinctrl driver via the correct config name.
Signed-off-by: Alex Hixon alex@alexhixon.com
configs/firefly-rk3399_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig index f30f131f34..0a4d005975 100644 --- a/configs/firefly-rk3399_defconfig +++ b/configs/firefly-rk3399_defconfig @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y CONFIG_PINCTRL=y CONFIG_SPL_PINCTRL=y -CONFIG_ROCKCHIP_RK3399_PINCTRL=y +CONFIG_PINCTRL_ROCKCHIP_RK3399=y CONFIG_DM_PMIC=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y
Shouldn't the RK3399 pinctrl driver at least by default y? Or imply'd ?
Yes that sounds good!
Reviewed-by: Simon Glass sjg@chromium.org
From: Alex Hixon alex@alexhixon.com Date: Mon, 15 May 2017 22:01:32 +1000
The config name enabling the rk3399-pinctrl driver is spelled wrong, so it does not get built. This causes SPL to fail during board init.
Make rk3399-firefly boot by enabling the pinctrl driver via the correct config name.
Signed-off-by: Alex Hixon alex@alexhixon.com
Reviewed-by: Mark Kettenis kettenis@openbsd.org
configs/firefly-rk3399_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig index f30f131f34..0a4d005975 100644 --- a/configs/firefly-rk3399_defconfig +++ b/configs/firefly-rk3399_defconfig @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y CONFIG_PINCTRL=y CONFIG_SPL_PINCTRL=y -CONFIG_ROCKCHIP_RK3399_PINCTRL=y +CONFIG_PINCTRL_ROCKCHIP_RK3399=y CONFIG_DM_PMIC=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y -- 2.11.0
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Hi Alex,
Thanks for your patch, but this patch is just the same with the one from Heiko[0], right?
Thanks,
- Kever
[0] https://patchwork.ozlabs.org/patch/758272/
On 05/15/2017 08:01 PM, Alex Hixon wrote:
The config name enabling the rk3399-pinctrl driver is spelled wrong, so it does not get built. This causes SPL to fail during board init.
Make rk3399-firefly boot by enabling the pinctrl driver via the correct config name.
Signed-off-by: Alex Hixon alex@alexhixon.com
configs/firefly-rk3399_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig index f30f131f34..0a4d005975 100644 --- a/configs/firefly-rk3399_defconfig +++ b/configs/firefly-rk3399_defconfig @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y CONFIG_PINCTRL=y CONFIG_SPL_PINCTRL=y -CONFIG_ROCKCHIP_RK3399_PINCTRL=y +CONFIG_PINCTRL_ROCKCHIP_RK3399=y CONFIG_DM_PMIC=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y
Hi Kever,
Ahh, yup! You're totally right! I didn't see Heiko's patch earlier.
My mistake.
Cheers, Alex
On 18 May 2017 12:38 PM, "Kever Yang" kever.yang@rock-chips.com wrote:
Hi Alex,
Thanks for your patch, but this patch is just the same with the one from Heiko[0], right?
Thanks,
- Kever
[0] https://patchwork.ozlabs.org/patch/758272/
On 05/15/2017 08:01 PM, Alex Hixon wrote:
The config name enabling the rk3399-pinctrl driver is spelled wrong, so it does not get built. This causes SPL to fail during board init.
Make rk3399-firefly boot by enabling the pinctrl driver via the correct config name.
Signed-off-by: Alex Hixon alex@alexhixon.com
configs/firefly-rk3399_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig index f30f131f34..0a4d005975 100644 --- a/configs/firefly-rk3399_defconfig +++ b/configs/firefly-rk3399_defconfig @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y CONFIG_PINCTRL=y CONFIG_SPL_PINCTRL=y -CONFIG_ROCKCHIP_RK3399_PINCTRL=y +CONFIG_PINCTRL_ROCKCHIP_RK3399=y CONFIG_DM_PMIC=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y
participants (5)
-
Alex Hixon -
Kever Yang -
Mark Kettenis -
Simon Glass -
Tom Rini