[U-Boot] [PATCH 1/2] Revert "powerpc/p1_p2_rdb_pc: Fix endian access issue on EHCI intinalization"
There was an EHCI endian accessor issue. Now it's fixed by commit 9829ce2ff25c ("usb: ehci: Fix accessors for big-endian platforms and descriptors"). Revert commit 0f2296bab141 ("powerpc/p1_p2_rdb_pc: Fix endian access issue on EHCI intinalization") due to it fix that issue in a wrong way. Actually, on P1 P2 platforms, USB EHCI register use little endian.
Signed-off-by: Ran Wang ran.wang_1@nxp.com --- include/configs/p1_p2_rdb_pc.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h index 624f9eb..180a1eb 100644 --- a/include/configs/p1_p2_rdb_pc.h +++ b/include/configs/p1_p2_rdb_pc.h @@ -771,7 +771,6 @@ #ifdef CONFIG_USB_EHCI_HCD #define CONFIG_EHCI_HCD_INIT_AFTER_RESET #define CONFIG_USB_EHCI_FSL -#define CONFIG_EHCI_DESC_BIG_ENDIAN #endif #endif
There was an EHCI endian accessor issue. Now it's fixed by commit 9829ce2ff25c ("usb: ehci: Fix accessors for big-endian platforms and descriptors") Revert commit e6a727fffec7b2002e ("powerpc/T104xRDB: Fix endian access issue on EHCI intinalization") due to it fix that issue in a wrong way. Actually, on T104x platform, USB EHCI register use little endian.
Signed-off-by: Ran Wang ran.wang_1@nxp.com --- include/configs/T104xRDB.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/T104xRDB.h b/include/configs/T104xRDB.h index a054b97..6ef662b 100644 --- a/include/configs/T104xRDB.h +++ b/include/configs/T104xRDB.h @@ -624,7 +624,6 @@ $(SRCTREE)/board/freescale/t104xrdb/t1042d4_sd_rcw.cfg #ifdef CONFIG_USB_EHCI_HCD #define CONFIG_USB_EHCI_FSL #define CONFIG_EHCI_HCD_INIT_AFTER_RESET -#define CONFIG_EHCI_DESC_BIG_ENDIAN #endif #endif
On 06/13/2018 07:46 PM, Ran Wang wrote:
There was an EHCI endian accessor issue. Now it's fixed by commit 9829ce2ff25c ("usb: ehci: Fix accessors for big-endian platforms and descriptors") Revert commit e6a727fffec7b2002e ("powerpc/T104xRDB: Fix endian access issue on EHCI intinalization") due to it fix that issue in a wrong way. Actually, on T104x platform, USB EHCI register use little endian.
Signed-off-by: Ran Wang ran.wang_1@nxp.com
Applied to mpc85xx, awaiting upstream. Thanks.
York
On 06/13/2018 07:46 PM, Ran Wang wrote:
There was an EHCI endian accessor issue. Now it's fixed by commit 9829ce2ff25c ("usb: ehci: Fix accessors for big-endian platforms and descriptors"). Revert commit 0f2296bab141 ("powerpc/p1_p2_rdb_pc: Fix endian access issue on EHCI intinalization") due to it fix that issue in a wrong way. Actually, on P1 P2 platforms, USB EHCI register use little endian.
Signed-off-by: Ran Wang ran.wang_1@nxp.com
Applied to mpc85xx, awaiting upstream. Thanks.
York
participants (2)
-
Ran Wang -
York Sun