[U-Boot] [PATCH 1/1] arm: bcm235xx: avoid possible NULL dereference

It does not make sense to first dereference c and then check if it is NULL.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- arch/arm/cpu/armv7/bcm235xx/clk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv7/bcm235xx/clk-core.c b/arch/arm/cpu/armv7/bcm235xx/clk-core.c index 79fafa08ed..ee4b34574a 100644 --- a/arch/arm/cpu/armv7/bcm235xx/clk-core.c +++ b/arch/arm/cpu/armv7/bcm235xx/clk-core.c @@ -479,9 +479,9 @@ unsigned long clk_get_rate(struct clk *c) { unsigned long rate;
- debug("%s: %s\n", __func__, c->name); if (!c || !c->ops || !c->ops->get_rate) return 0; + debug("%s: %s\n", __func__, c->name);
rate = c->ops->get_rate(c); debug("%s: rate = %ld\n", __func__, rate);

On Sun, Jul 30, 2017 at 08:15:51PM +0200, xypron.glpk@gmx.de wrote:
It does not make sense to first dereference c and then check if it is NULL.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Applied to u-boot/master, thanks!
participants (2)
-
Heinrich Schuchardt
-
Tom Rini