[U-Boot] [PATCH v2 3/5] CVE-2019-14194/CVE-2019-14198: nfs: fix unbounded memcpy with a failed length check at nfs_read_reply //RE: [PATCH 3/5] CVE-2019-14194/CVE-2019-14198: nfs: fix unbounded memcpy with a failed length check at nfs_read_reply

Changes in v2: - Add reported-by tag for patch 3/5 -------------------------------------------------------------------------------------------------------------- CVE-2019-14194/CVE-2019-14198: nfs: fix unbounded memcpy with a failed length check at nfs_read_reply
This patch adds a check to rpc_pkt.u.reply.data at nfs_read_reply.
Signed-off-by: Cheng Liu liucheng32@huawei.com Reported-by: Fermín Serna fermin@semmle.com --- net/nfs.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/net/nfs.c b/net/nfs.c index b7cf3b3..11941fa 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -701,6 +701,9 @@ static int nfs_read_reply(uchar *pkt, unsigned len) &(rpc_pkt.u.reply.data[4 + nfsv3_data_offset]); }
+ if (((uchar *)&(rpc_pkt.u.reply.data[0]) - (uchar *)(&rpc_pkt) + rlen) > len) + return -9999; + if (store_block(data_ptr, nfs_offset, rlen)) return -9999;

On Thu, Aug 29, 2019 at 8:50 AM liucheng (G) liucheng32@huawei.com wrote:
Changes in v2:
- Add reported-by tag for patch 3/5
CVE-2019-14194/CVE-2019-14198: nfs: fix unbounded memcpy with a failed length check at nfs_read_reply
This patch adds a check to rpc_pkt.u.reply.data at nfs_read_reply.
Signed-off-by: Cheng Liu liucheng32@huawei.com Reported-by: Fermín Serna fermin@semmle.com
Acked-by: Joe Hershberger joe.hershberger@ni.com

Hi liucheng,
https://patchwork.ozlabs.org/patch/1155277/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks! -Joe
participants (2)
-
Joe Hershberger
-
liucheng (G)