[U-Boot] [PATCH 1/1] dwc3-generic: Don't fail probe if clk/reset entries are absent
Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.
This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer") Reported-by: Sam Protsenko semen.protsenko@linaro.org Signed-off-by: Vignesh Raghavendra vigneshr@ti.com --- drivers/usb/dwc3/dwc3-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 406bf0b3628b..d76cd7a4c5ca 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev, int ret;
ret = reset_get_bulk(dev, &glue->resets); - if (ret == -ENOTSUPP) + if (ret == -ENOTSUPP || ret == -ENOENT) return 0; else if (ret) return ret; @@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev, int ret;
ret = clk_get_bulk(dev, &glue->clks); - if (ret == -ENOSYS) + if (ret == -ENOSYS || ret == -ENOENT) return 0; if (ret) return ret;
On 25/10/2019 11:18, Vignesh Raghavendra wrote:
Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.
This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer") Reported-by: Sam Protsenko semen.protsenko@linaro.org Signed-off-by: Vignesh Raghavendra vigneshr@ti.com
Thanks for the patch.
Tested-by: Tero Kristo t-kristo@ti.com
drivers/usb/dwc3/dwc3-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 406bf0b3628b..d76cd7a4c5ca 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev, int ret;
ret = reset_get_bulk(dev, &glue->resets);
- if (ret == -ENOTSUPP)
- if (ret == -ENOTSUPP || ret == -ENOENT) return 0; else if (ret) return ret;
@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev, int ret;
ret = clk_get_bulk(dev, &glue->clks);
- if (ret == -ENOSYS)
- if (ret == -ENOSYS || ret == -ENOENT) return 0; if (ret) return ret;
-- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Vignesh,
On Fri, Oct 25, 2019 at 11:17 AM Vignesh Raghavendra vigneshr@ti.com wrote:
Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.
This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer") Reported-by: Sam Protsenko semen.protsenko@linaro.org Signed-off-by: Vignesh Raghavendra vigneshr@ti.com
Tested-by: Sam Protsenko semen.protsenko@linaro.org Reviewed-by: Sam Protsenko semen.protsenko@linaro.org
drivers/usb/dwc3/dwc3-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 406bf0b3628b..d76cd7a4c5ca 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev, int ret;
ret = reset_get_bulk(dev, &glue->resets);
if (ret == -ENOTSUPP)
if (ret == -ENOTSUPP || ret == -ENOENT) return 0; else if (ret) return ret;@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev, int ret;
ret = clk_get_bulk(dev, &glue->clks);
if (ret == -ENOSYS)
if (ret == -ENOSYS || ret == -ENOENT) return 0; if (ret) return ret;-- 2.23.0
+ Praneeth
On Fri, Oct 25, 2019 at 1:08 PM Sam Protsenko semen.protsenko@linaro.org wrote:
Hi Vignesh,
On Fri, Oct 25, 2019 at 11:17 AM Vignesh Raghavendra vigneshr@ti.com wrote:
Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.
This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Fixes: e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer") Reported-by: Sam Protsenko semen.protsenko@linaro.org Signed-off-by: Vignesh Raghavendra vigneshr@ti.com
Tested-by: Sam Protsenko semen.protsenko@linaro.org Reviewed-by: Sam Protsenko semen.protsenko@linaro.org
drivers/usb/dwc3/dwc3-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 406bf0b3628b..d76cd7a4c5ca 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev, int ret;
ret = reset_get_bulk(dev, &glue->resets);
if (ret == -ENOTSUPP)
if (ret == -ENOTSUPP || ret == -ENOENT) return 0; else if (ret) return ret;@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev, int ret;
ret = clk_get_bulk(dev, &glue->clks);
if (ret == -ENOSYS)
if (ret == -ENOSYS || ret == -ENOENT) return 0; if (ret) return ret;-- 2.23.0
On 10/25/19 10:18 AM, Vignesh Raghavendra wrote:
Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.
This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx
Applied, thanks.
participants (4)
-
Marek Vasut -
Sam Protsenko -
Tero Kristo -
Vignesh Raghavendra