[PATCH] ARM: dts: stm32: Define FMC2 base address
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com --- arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach-stm32mp/include/mach/stm32.h index f0636005e5..62d95d7f88 100644 --- a/arch/arm/mach-stm32mp/include/mach/stm32.h +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h @@ -13,6 +13,7 @@ #define STM32_RCC_BASE 0x50000000 #define STM32_PWR_BASE 0x50001000 #define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000 #define STM32_TZC_BASE 0x5C006000 #define STM32_ETZPC_BASE 0x5C007000 #define STM32_STGEN_BASE 0x5C008000
Hi Marek
On 3/26/20 4:57 PM, Marek Vasut wrote:
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com
arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach-stm32mp/include/mach/stm32.h index f0636005e5..62d95d7f88 100644 --- a/arch/arm/mach-stm32mp/include/mach/stm32.h +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h @@ -13,6 +13,7 @@ #define STM32_RCC_BASE 0x50000000 #define STM32_PWR_BASE 0x50001000 #define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000 #define STM32_TZC_BASE 0x5C006000 #define STM32_ETZPC_BASE 0x5C007000 #define STM32_STGEN_BASE 0x5C008000
Reviewed-by: Patrice Chotard patrice.chotard@st.com
Thanks
Patrice
Hi Marek,
From: Marek Vasut marex@denx.de Sent: jeudi 26 mars 2020 16:57
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com
arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach- stm32mp/include/mach/stm32.h index f0636005e5..62d95d7f88 100644 --- a/arch/arm/mach-stm32mp/include/mach/stm32.h +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h @@ -13,6 +13,7 @@ #define STM32_RCC_BASE 0x50000000 #define STM32_PWR_BASE 0x50001000 #define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000
For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the device defined here.
But normally it is not the case for FMC2, even if I understand the current need, without FMC2 bus driver.... I will take this patch only it is not possible to get FMC2 address from device tree.
#define STM32_TZC_BASE 0x5C006000 #define STM32_ETZPC_BASE 0x5C007000
#define STM32_STGEN_BASE 0x5C008000
2.25.1
Regards
Patrick
On 4/1/20 3:45 PM, Patrick DELAUNAY wrote:
Hi Marek,
Hi,
From: Marek Vasut marex@denx.de Sent: jeudi 26 mars 2020 16:57
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com
arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach- stm32mp/include/mach/stm32.h index f0636005e5..62d95d7f88 100644 --- a/arch/arm/mach-stm32mp/include/mach/stm32.h +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h @@ -13,6 +13,7 @@ #define STM32_RCC_BASE 0x50000000 #define STM32_PWR_BASE 0x50001000 #define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000
For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the device defined here.
But normally it is not the case for FMC2, even if I understand the current need, without FMC2 bus driver.... I will take this patch only it is not possible to get FMC2 address from device tree.
I can parse this information from the DT, but what would be the benefit? Slower boot due to the need to traverse DT and more complex code?
Dear,
From: Marek Vasut marex@denx.de Sent: jeudi 9 avril 2020 13:23
On 4/1/20 3:45 PM, Patrick DELAUNAY wrote:
Hi Marek,
Hi,
From: Marek Vasut marex@denx.de Sent: jeudi 26 mars 2020 16:57
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com
arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach- stm32mp/include/mach/stm32.h index f0636005e5..62d95d7f88 100644 --- a/arch/arm/mach-stm32mp/include/mach/stm32.h +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h @@ -13,6 +13,7 @@ #define STM32_RCC_BASE 0x50000000 #define STM32_PWR_BASE 0x50001000 #define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000
For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the
device defined here.
But normally it is not the case for FMC2, even if I understand the current need,
without FMC2 bus driver....
I will take this patch only it is not possible to get FMC2 address from device
tree.
I can parse this information from the DT, but what would be the benefit? Slower boot due to the need to traverse DT and more complex code?
I am convinced now (thanks to Christophe) because the correct FMC bus driver is not yet ready...
It will be clean-up later when no more used.
Reviewed-by: Patrick Delaunay patrick.delaunay@st.com
Thanks
Patrick
Hi
On 4/9/20 7:31 PM, Patrick DELAUNAY wrote:
Dear,
From: Marek Vasut marex@denx.de Sent: jeudi 9 avril 2020 13:23
On 4/1/20 3:45 PM, Patrick DELAUNAY wrote:
Hi Marek,
Hi,
From: Marek Vasut marex@denx.de Sent: jeudi 26 mars 2020 16:57
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com
arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-stm32mp/include/mach/stm32.h b/arch/arm/mach- stm32mp/include/mach/stm32.h index f0636005e5..62d95d7f88 100644 --- a/arch/arm/mach-stm32mp/include/mach/stm32.h +++ b/arch/arm/mach-stm32mp/include/mach/stm32.h @@ -13,6 +13,7 @@ #define STM32_RCC_BASE 0x50000000 #define STM32_PWR_BASE 0x50001000 #define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000
For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the
device defined here.
But normally it is not the case for FMC2, even if I understand the current need,
without FMC2 bus driver....
I will take this patch only it is not possible to get FMC2 address from device
tree.
I can parse this information from the DT, but what would be the benefit? Slower boot due to the need to traverse DT and more complex code?
I am convinced now (thanks to Christophe) because the correct FMC bus driver is not yet ready...
It will be clean-up later when no more used.
Reviewed-by: Patrick Delaunay patrick.delaunay@st.com
Thanks
Patrick
Applied to u-boot-stm/next
Thanks
Patrice
participants (3)
-
Marek Vasut -
Patrice CHOTARD -
Patrick DELAUNAY