[PATCH v3] rockchip: px30-board-tpl: Sync ifdef guards with full TPL
From: Lukasz Czechowski lukasz.czechowski@thaumatec.com
Display TPL init information message only when TPL_BANNER_PRINT configuration entry is set. This allows to disable information message in case logs on UART are unwanted. Update parent ifdef condition to check also CONFIG_TPL_SERIAL to match logic of the non-PX30 TPL implementation.
Signed-off-by: Lukasz Czechowski lukasz.czechowski@thaumatec.com
--- Changes for v2: - Updated parent ifdef condition
Changes for v3: - Updated commit title --- arch/arm/mach-rockchip/px30-board-tpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/px30-board-tpl.c b/arch/arm/mach-rockchip/px30-board-tpl.c index 637a5e1b18..db368a7b8c 100644 --- a/arch/arm/mach-rockchip/px30-board-tpl.c +++ b/arch/arm/mach-rockchip/px30-board-tpl.c @@ -36,7 +36,7 @@ void board_init_f(ulong dummy) { int ret;
-#ifdef CONFIG_DEBUG_UART +#if defined(CONFIG_DEBUG_UART) && defined(CONFIG_TPL_SERIAL) debug_uart_init(); /* * Debug UART can be used from here if required: @@ -46,7 +46,9 @@ void board_init_f(ulong dummy) * printhex8(0x1234); * printascii("string"); */ +#if CONFIG_TPL_BANNER_PRINT printascii("U-Boot TPL board init\n"); +#endif #endif
secure_timer_init();
Hi Lukasz,
On 4/17/24 13:21, lukasz.czechowski@thaumatec.com wrote:
From: Lukasz Czechowski lukasz.czechowski@thaumatec.com
Display TPL init information message only when TPL_BANNER_PRINT configuration entry is set. This allows to disable information message in case logs on UART are unwanted. Update parent ifdef condition to check also CONFIG_TPL_SERIAL to match logic of the non-PX30 TPL implementation.
Signed-off-by: Lukasz Czechowski lukasz.czechowski@thaumatec.com
When someone gives a tag (Acked-by, Reviewed-by, Tested-by, ...) on a version and you send a new one, it's best to include this in the commit log now (above your Signed-off-by if I remember correctly) if and only if the content only changed a bit (like no big logic change or rewrite). So here, my Reviewed-by would have been nice since I gave it in the v2 :) (please do not send a v4 for this :) )
b4 does this with `b4 trailers -u` automatically by the way :)
Reviewed-by: Quentin Schulz quentin.schulz@theobroma-systems.com
Thanks, Quentin
On 2024/4/17 19:21, lukasz.czechowski@thaumatec.com wrote:
From: Lukasz Czechowski lukasz.czechowski@thaumatec.com
Display TPL init information message only when TPL_BANNER_PRINT configuration entry is set. This allows to disable information message in case logs on UART are unwanted. Update parent ifdef condition to check also CONFIG_TPL_SERIAL to match logic of the non-PX30 TPL implementation.
Signed-off-by: Lukasz Czechowski lukasz.czechowski@thaumatec.com
Reviewed-by: Kever Yang kever.yang@rock-chips.com
Thanks, - Kever
Changes for v2:
- Updated parent ifdef condition
Changes for v3:
- Updated commit title
arch/arm/mach-rockchip/px30-board-tpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/px30-board-tpl.c b/arch/arm/mach-rockchip/px30-board-tpl.c index 637a5e1b18..db368a7b8c 100644 --- a/arch/arm/mach-rockchip/px30-board-tpl.c +++ b/arch/arm/mach-rockchip/px30-board-tpl.c @@ -36,7 +36,7 @@ void board_init_f(ulong dummy) { int ret;
-#ifdef CONFIG_DEBUG_UART +#if defined(CONFIG_DEBUG_UART) && defined(CONFIG_TPL_SERIAL) debug_uart_init(); /* * Debug UART can be used from here if required: @@ -46,7 +46,9 @@ void board_init_f(ulong dummy) * printhex8(0x1234); * printascii("string"); */ +#if CONFIG_TPL_BANNER_PRINT printascii("U-Boot TPL board init\n"); +#endif #endif
secure_timer_init();
participants (3)
-
Kever Yang -
lukasz.czechowski＠thaumatec.com -
Quentin Schulz