[U-Boot] [PATCH 1/2] Makefile: add u-boot-spl.srec target

The u-boot-spl.srec is needed for some platforms, add target to generate this file.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Tom Rini trini@konsulko.com --- Makefile | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/Makefile b/Makefile index 57cb4b87d9..a3ce04947a 100644 --- a/Makefile +++ b/Makefile @@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec u-boot.hex u-boot.srec: u-boot FORCE $(call if_changed,objcopy)
+OBJCOPYFLAGS_u-boot-spl.srec = $(OBJCOPYFLAGS_u-boot.srec) + +spl/u-boot-spl.srec: spl/u-boot-spl FORCE + $(call if_changed,objcopy) + OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \ $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)

The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Tom Rini trini@konsulko.com --- include/configs/rcar-gen2-common.h | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h index 1ceee9a429..6069220406 100644 --- a/include/configs/rcar-gen2-common.h +++ b/include/configs/rcar-gen2-common.h @@ -15,6 +15,10 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG
+#ifdef CONFIG_SPL +#define CONFIG_SPL_TARGET "spl/u-boot-spl.srec" +#endif + #undef CONFIG_SHOW_BOOT_PROGRESS
#define CONFIG_ARCH_CPU_INIT

On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:
The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Tom Rini trini@konsulko.com
include/configs/rcar-gen2-common.h | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h index 1ceee9a429..6069220406 100644 --- a/include/configs/rcar-gen2-common.h +++ b/include/configs/rcar-gen2-common.h @@ -15,6 +15,10 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG
+#ifdef CONFIG_SPL +#define CONFIG_SPL_TARGET "spl/u-boot-spl.srec" +#endif
#undef CONFIG_SHOW_BOOT_PROGRESS
#define CONFIG_ARCH_CPU_INIT
Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!

On 02/26/2018 09:00 PM, Tom Rini wrote:
On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:
The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Tom Rini trini@konsulko.com
include/configs/rcar-gen2-common.h | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h index 1ceee9a429..6069220406 100644 --- a/include/configs/rcar-gen2-common.h +++ b/include/configs/rcar-gen2-common.h @@ -15,6 +15,10 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG
+#ifdef CONFIG_SPL +#define CONFIG_SPL_TARGET "spl/u-boot-spl.srec" +#endif
#undef CONFIG_SHOW_BOOT_PROGRESS
#define CONFIG_ARCH_CPU_INIT
Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!
Yeah, after the release. I dont plan to mess with it before the release. Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?

On Mon, Feb 26, 2018 at 09:50:44PM +0100, Marek Vasut wrote:
On 02/26/2018 09:00 PM, Tom Rini wrote:
On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:
The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Tom Rini trini@konsulko.com
include/configs/rcar-gen2-common.h | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h index 1ceee9a429..6069220406 100644 --- a/include/configs/rcar-gen2-common.h +++ b/include/configs/rcar-gen2-common.h @@ -15,6 +15,10 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG
+#ifdef CONFIG_SPL +#define CONFIG_SPL_TARGET "spl/u-boot-spl.srec" +#endif
#undef CONFIG_SHOW_BOOT_PROGRESS
#define CONFIG_ARCH_CPU_INIT
Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!
Yeah, after the release. I dont plan to mess with it before the release. Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?
I would be happy enough to take both of those at this point, yes, as they can be easily verified. Thanks!

On 02/27/2018 01:00 AM, Tom Rini wrote:
On Mon, Feb 26, 2018 at 09:50:44PM +0100, Marek Vasut wrote:
On 02/26/2018 09:00 PM, Tom Rini wrote:
On Mon, Feb 26, 2018 at 08:25:36PM +0100, Marek Vasut wrote:
The u-boot-spl.srec is needed for the minimon update on Gen2 SoCs, conveniently generate this file if SPL is enabled.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Tom Rini trini@konsulko.com
include/configs/rcar-gen2-common.h | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/include/configs/rcar-gen2-common.h b/include/configs/rcar-gen2-common.h index 1ceee9a429..6069220406 100644 --- a/include/configs/rcar-gen2-common.h +++ b/include/configs/rcar-gen2-common.h @@ -15,6 +15,10 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG
+#ifdef CONFIG_SPL +#define CONFIG_SPL_TARGET "spl/u-boot-spl.srec" +#endif
#undef CONFIG_SHOW_BOOT_PROGRESS
#define CONFIG_ARCH_CPU_INIT
Can you please convert CONFIG_SPL_TARGET to CONFIG_SPL_BUILD_TARGET, to match CONFIG_BUILD_TARGET and migrate it after CONFIG_BUILD_TARGET? Thanks!
Yeah, after the release. I dont plan to mess with it before the release. Or are you planning to convert BUILD_TARGET to Kconfig _before_ ?
I would be happy enough to take both of those at this point, yes, as they can be easily verified. Thanks!
I'll add it to my todo ...

On Mon, Feb 26, 2018 at 08:25:35PM +0100, Marek Vasut wrote:
The u-boot-spl.srec is needed for some platforms, add target to generate this file.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Nobuhiro Iwamatsu iwamatsu@nigauri.org Cc: Tom Rini trini@konsulko.com
Reviewed-by: Tom Rini trini@konsulko.com
participants (2)
-
Marek Vasut
-
Tom Rini