[U-Boot] [PATCH] command.c: Fix auto-completion for the full commands list case

Compiling of full list of commands does not advance the counter, so it always results in an empty list. This seems to be (inadvertently?) introduced by commit 6c7c946cadfafdea80eb930e3181085b907a0362.
Signed-off-by: Andrew Gabbasov andrew_gabbasov@mentor.com --- common/command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/command.c b/common/command.c index 625571d..597ab4c 100644 --- a/common/command.c +++ b/common/command.c @@ -184,10 +184,10 @@ static int complete_cmdv(int argc, char * const argv[], char last_char, int maxv /* output full list of commands */ for (; cmdtp != cmdend; cmdtp++) { if (n_found >= maxv - 2) { - cmdv[n_found] = "..."; + cmdv[n_found++] = "..."; break; } - cmdv[n_found] = cmdtp->name; + cmdv[n_found++] = cmdtp->name; } cmdv[n_found] = NULL; return n_found;

On Fri, Dec 27, 2013 at 10:05:14AM -0600, Andrew Gabbasov wrote:
Compiling of full list of commands does not advance the counter, so it always results in an empty list. This seems to be (inadvertently?) introduced by commit 6c7c946cadfafdea80eb930e3181085b907a0362.
Signed-off-by: Andrew Gabbasov andrew_gabbasov@mentor.com
Applied to u-boot/master, thanks!
participants (2)
-
Andrew Gabbasov
-
Tom Rini