[U-Boot] [PATCH] checkpatch: fix left brace warning

using checkpatch with Perl 5.22.0 generates a warning, this is fixed in linux through commit:
commit 4e5d56bdf892e18832a6540b63ebf709966bce2a Author: Eddie Kovsky ewk@edkovsky.org Date: Wed Sep 9 15:37:52 2015 -0700
checkpatch: fix left brace warning
Using checkpatch.pl with Perl 5.22.0 generates the following warning:
Unescaped left brace in regex is deprecated, passed through in regex;
This patch fixes the warnings by escaping occurrences of the left brace inside the regular expression.
Adapt it for U-Boot.
Signed-off-by: Heiko Schocher hs@denx.de ---
scripts/checkpatch.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 74db2e2..24831b3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2825,8 +2825,8 @@ sub process {
# function brace can't be on same line, except for #defines of do while, # or if closed on same line - if (($line=~/$Type\s*$Ident(.*).*\s{/) and - !($line=~/#\s*define.*do\s{/) and !($line=~/}/)) { + if (($line=~/$Type\s*$Ident(.*).*\s{/) and + !($line=~/#\s*define.*do\s{/) and !($line=~/}/)) { ERROR("OPEN_BRACE", "open brace '{' following function declarations go on the next line\n" . $herecurr); } @@ -3259,8 +3259,8 @@ sub process { ## }
#need space before brace following if, while, etc - if (($line =~ /(.*){/ && $line !~ /($Type){/) || - $line =~ /do{/) { + if (($line =~ /(.*){/ && $line !~ /($Type){/) || + $line =~ /do{/) { if (ERROR("SPACING", "space required before the open brace '{'\n" . $herecurr) && $fix) { @@ -3633,7 +3633,7 @@ sub process { $dstat !~ /^for\s*$Constant$/ && # for (...) $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ && # for (...) bar() $dstat !~ /^do\s*{/ && # do {... - $dstat !~ /^({/ && # ({... + $dstat !~ /^({/ && # ({... $ctx !~ /^.\s*#\s*define\s+TRACE_(?:SYSTEM|INCLUDE_FILE|INCLUDE_PATH)\b/) { $ctx =~ s/\n*$//;

On Mon, Jan 04, 2016 at 09:17:19AM +0100, Heiko Schocher wrote:
using checkpatch with Perl 5.22.0 generates a warning, this is fixed in linux through commit:
commit 4e5d56bdf892e18832a6540b63ebf709966bce2a Author: Eddie Kovsky ewk@edkovsky.org Date: Wed Sep 9 15:37:52 2015 -0700
checkpatch: fix left brace warning
Using checkpatch.pl with Perl 5.22.0 generates the following warning:
Unescaped left brace in regex is deprecated, passed through in regex;
This patch fixes the warnings by escaping occurrences of the left brace inside the regular expression.
Adapt it for U-Boot.
Signed-off-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!

Dear Heiko Schocher,
In message 1451895439-20798-1-git-send-email-hs@denx.de you wrote:
using checkpatch with Perl 5.22.0 generates a warning, this is fixed in linux through commit:
commit 4e5d56bdf892e18832a6540b63ebf709966bce2a Author: Eddie Kovsky ewk@edkovsky.org Date: Wed Sep 9 15:37:52 2015 -0700
checkpatch: fix left brace warning
Using checkpatch.pl with Perl 5.22.0 generates the following warning:
Unescaped left brace in regex is deprecated, passed through in regex;
This patch fixes the warnings by escaping occurrences of the left brace inside the regular expression.
Adapt it for U-Boot.
Signed-off-by: Heiko Schocher hs@denx.de
scripts/checkpatch.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by: Wolfgang Denk wd@denx.de
participants (3)
-
Heiko Schocher
-
Tom Rini
-
Wolfgang Denk