[PATCH v1] fix patman --limit-cc option

patman's --limit-cc option parses its argument to an integer and uses that to trim the list of CC recipients to a particular maximum. but that only works if the cc variable is a list, which it is not.
Signed-off-by: Bernhard Kirchen bernhard.kirchen@mbconnectline.com ---
tools/patman/series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/patman/series.py b/tools/patman/series.py index a6746e87c4..41a11732fc 100644 --- a/tools/patman/series.py +++ b/tools/patman/series.py @@ -271,7 +271,7 @@ class Series(dict): cc += get_maintainer.GetMaintainer(dir_list, commit.patch) for x in set(cc) & set(settings.bounces): print(col.Color(col.YELLOW, 'Skipping "%s"' % x)) - cc = set(cc) - set(settings.bounces) + cc = list(set(cc) - set(settings.bounces)) if limit is not None: cc = cc[:limit] all_ccs += cc

Hi Bernhard,
On Fri, 29 Jan 2021 at 07:10, Bernhard Kirchen bernhard.kirchen@mbconnectline.com wrote:
patman's --limit-cc option parses its argument to an integer and uses that to trim the list of CC recipients to a particular maximum. but that only works if the cc variable is a list, which it is not.
Signed-off-by: Bernhard Kirchen bernhard.kirchen@mbconnectline.com
tools/patman/series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
A test would be useful for this please as it is obviously missing...

Hi Bernhard,
On Fri, 29 Jan 2021 at 07:10, Bernhard Kirchen bernhard.kirchen@mbconnectline.com wrote:
patman's --limit-cc option parses its argument to an integer and uses that to trim the list of CC recipients to a particular maximum. but that only works if the cc variable is a list, which it is not.
Signed-off-by: Bernhard Kirchen bernhard.kirchen@mbconnectline.com
tools/patman/series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
A test would be useful for this please as it is obviously missing...
Applied to u-boot-dm, thanks!
participants (2)
-
Bernhard Kirchen
-
Simon Glass