[PATCH 0/3] Add PCIe support for Iomega iConnect board
The Iomega iConnect board has an internal mPCIe slot. - Add PCIe support to enable the mPCIe slot to accept devices such as Wifi card or mSATA. - Add SYS_THUMB_BUILD to keep u-boot image size within 512K - Add myself as maintainer. Luka no longer has this board and wishes to see someone maintaining it actively
Tony Dinh (3): arm: kirkwood: iConnect : Add PCIe related configs arm: kirkwood: iConnect : Add PCIe late init arm: kirkwood: iConnect : Update board maintainer
board/iomega/iconnect/MAINTAINERS | 1 + board/iomega/iconnect/iconnect.c | 7 +++++++ configs/iconnect_defconfig | 5 +++++ 3 files changed, 13 insertions(+)
- Add MVEBU PCIe configs - Also add SYS_THUMB_BUILD to keep u-boot image size within 512K
Signed-off-by: Tony Dinh mibodhi@gmail.com ---
configs/iconnect_defconfig | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/configs/iconnect_defconfig b/configs/iconnect_defconfig index d8593bcdd2..bc44dbd218 100644 --- a/configs/iconnect_defconfig +++ b/configs/iconnect_defconfig @@ -2,6 +2,7 @@ CONFIG_ARM=y CONFIG_SKIP_LOWLEVEL_INIT=y CONFIG_SYS_DCACHE_OFF=y CONFIG_ARCH_CPU_INIT=y +CONFIG_SYS_THUMB_BUILD=y CONFIG_ARCH_KIRKWOOD=y CONFIG_SYS_TEXT_BASE=0x600000 CONFIG_NR_DRAM_BANKS=2 @@ -15,9 +16,11 @@ CONFIG_SYS_LOAD_ADDR=0x800000 CONFIG_BOOTDELAY=3 CONFIG_USE_PREBOOT=y # CONFIG_DISPLAY_BOARDINFO is not set +CONFIG_BOARD_LATE_INIT=y CONFIG_SYS_PROMPT="iconnect => " # CONFIG_CMD_FLASH is not set CONFIG_CMD_NAND=y +CONFIG_CMD_PCI=y CONFIG_CMD_USB=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_MII=y @@ -40,6 +43,8 @@ CONFIG_MTD=y CONFIG_MTD_RAW_NAND=y CONFIG_MVGBE=y CONFIG_MII=y +CONFIG_PCI=y +CONFIG_PCI_MVEBU=y CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y
On 1/2/22 05:57, Tony Dinh wrote:
- Add MVEBU PCIe configs
- Also add SYS_THUMB_BUILD to keep u-boot image size within 512K
Signed-off-by: Tony Dinh mibodhi@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
configs/iconnect_defconfig | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/configs/iconnect_defconfig b/configs/iconnect_defconfig index d8593bcdd2..bc44dbd218 100644 --- a/configs/iconnect_defconfig +++ b/configs/iconnect_defconfig @@ -2,6 +2,7 @@ CONFIG_ARM=y CONFIG_SKIP_LOWLEVEL_INIT=y CONFIG_SYS_DCACHE_OFF=y CONFIG_ARCH_CPU_INIT=y +CONFIG_SYS_THUMB_BUILD=y CONFIG_ARCH_KIRKWOOD=y CONFIG_SYS_TEXT_BASE=0x600000 CONFIG_NR_DRAM_BANKS=2 @@ -15,9 +16,11 @@ CONFIG_SYS_LOAD_ADDR=0x800000 CONFIG_BOOTDELAY=3 CONFIG_USE_PREBOOT=y # CONFIG_DISPLAY_BOARDINFO is not set +CONFIG_BOARD_LATE_INIT=y CONFIG_SYS_PROMPT="iconnect => " # CONFIG_CMD_FLASH is not set CONFIG_CMD_NAND=y +CONFIG_CMD_PCI=y CONFIG_CMD_USB=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_MII=y @@ -40,6 +43,8 @@ CONFIG_MTD=y CONFIG_MTD_RAW_NAND=y CONFIG_MVGBE=y CONFIG_MII=y +CONFIG_PCI=y +CONFIG_PCI_MVEBU=y CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y
Viele Grüße, Stefan Roese
- Add board_late_init function to enable pci_init
Signed-off-by: Tony Dinh mibodhi@gmail.com ---
board/iomega/iconnect/iconnect.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/board/iomega/iconnect/iconnect.c b/board/iomega/iconnect/iconnect.c index fe4be28b13..9e123aab00 100644 --- a/board/iomega/iconnect/iconnect.c +++ b/board/iomega/iconnect/iconnect.c @@ -92,3 +92,10 @@ int board_init(void)
return 0; } + +int board_late_init(void) +{ + /* Do late init to ensure successful enumeration of PCIe devices */ + pci_init(); + return 0; +}
On 1/2/22 05:57, Tony Dinh wrote:
- Add board_late_init function to enable pci_init
Signed-off-by: Tony Dinh mibodhi@gmail.com
board/iomega/iconnect/iconnect.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/board/iomega/iconnect/iconnect.c b/board/iomega/iconnect/iconnect.c index fe4be28b13..9e123aab00 100644 --- a/board/iomega/iconnect/iconnect.c +++ b/board/iomega/iconnect/iconnect.c @@ -92,3 +92,10 @@ int board_init(void)
return 0; }
+int board_late_init(void) +{
- /* Do late init to ensure successful enumeration of PCIe devices */
- pci_init();
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
- return 0;
+}
Viele Grüße, Stefan Roese
Add myself as maintainer.
Signed-off-by: Tony Dinh mibodhi@gmail.com ---
board/iomega/iconnect/MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
diff --git a/board/iomega/iconnect/MAINTAINERS b/board/iomega/iconnect/MAINTAINERS index 167cf074b9..a1b018e816 100644 --- a/board/iomega/iconnect/MAINTAINERS +++ b/board/iomega/iconnect/MAINTAINERS @@ -1,4 +1,5 @@ ICONNECT BOARD +M: Tony Dinh mibodhi@gmail.com M: Luka Perkov luka@openwrt.org S: Maintained F: board/iomega/iconnect/
On 1/2/22 05:57, Tony Dinh wrote:
Add myself as maintainer.
Signed-off-by: Tony Dinh mibodhi@gmail.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
board/iomega/iconnect/MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
diff --git a/board/iomega/iconnect/MAINTAINERS b/board/iomega/iconnect/MAINTAINERS index 167cf074b9..a1b018e816 100644 --- a/board/iomega/iconnect/MAINTAINERS +++ b/board/iomega/iconnect/MAINTAINERS @@ -1,4 +1,5 @@ ICONNECT BOARD +M: Tony Dinh mibodhi@gmail.com M: Luka Perkov luka@openwrt.org S: Maintained F: board/iomega/iconnect/
Viele Grüße, Stefan Roese
On Saturday 01 January 2022 20:57:36 Tony Dinh wrote:
The Iomega iConnect board has an internal mPCIe slot.
- Add PCIe support to enable the mPCIe slot to accept devices such as Wifi card or mSATA.
- Add SYS_THUMB_BUILD to keep u-boot image size within 512K
- Add myself as maintainer. Luka no longer has this board and wishes
to see someone maintaining it actively
I guess that this series requires kirkwood patch which I sent recently: https://patchwork.ozlabs.org/project/uboot/patch/20220113132804.7814-1-pali@...
Anyway, this patch series looks good, so:
Reviewed-by: Pali Rohár pali@kernel.org
Tony Dinh (3): arm: kirkwood: iConnect : Add PCIe related configs arm: kirkwood: iConnect : Add PCIe late init arm: kirkwood: iConnect : Update board maintainer
board/iomega/iconnect/MAINTAINERS | 1 + board/iomega/iconnect/iconnect.c | 7 +++++++ configs/iconnect_defconfig | 5 +++++ 3 files changed, 13 insertions(+)
-- 2.30.2
On 1/2/22 05:57, Tony Dinh wrote:
The Iomega iConnect board has an internal mPCIe slot.
- Add PCIe support to enable the mPCIe slot to accept devices such as Wifi card or mSATA.
- Add SYS_THUMB_BUILD to keep u-boot image size within 512K
- Add myself as maintainer. Luka no longer has this board and wishes
to see someone maintaining it actively
Tony Dinh (3): arm: kirkwood: iConnect : Add PCIe related configs arm: kirkwood: iConnect : Add PCIe late init arm: kirkwood: iConnect : Update board maintainer
board/iomega/iconnect/MAINTAINERS | 1 + board/iomega/iconnect/iconnect.c | 7 +++++++ configs/iconnect_defconfig | 5 +++++ 3 files changed, 13 insertions(+)
Applied to u-boot-marvell/master
Thanks, Stefan
participants (3)
-
Pali Rohár -
Stefan Roese -
Tony Dinh