[U-Boot] [PATCH v2 1/2] net: mvneta: dcache flush TX descriptors at init

From: Rabeeh Khoury rabeeh@solid-run.com
This fixes sporadic timeout on initial packet Tx (usually ARP), with an error message like:
timeout: packet not sent
Reviewed-by: Stefan Roese sr@denx.de Tested-by: Chris Packham judge.packham@gmail.com Acked-by: Joe Hershberger joe.hershberger@ni.com Signed-off-by: Rabeeh Khoury rabeeh@solid-run.com Signed-off-by: Baruch Siach baruch@tkos.co.il --- v2: Make the patch checkpatch compliant (Stefan Roese) --- drivers/net/mvneta.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c index 45e5eda95522..254dd04697db 100644 --- a/drivers/net/mvneta.c +++ b/drivers/net/mvneta.c @@ -1702,6 +1702,7 @@ static int mvneta_probe(struct udevice *dev)
/* Align buffer area for descs and rx_buffers to 1MiB */ bd_space = memalign(1 << MMU_SECTION_SHIFT, BD_SPACE); + flush_dcache_range((ulong)bd_space, (ulong)bd_space + BD_SPACE); mmu_set_region_dcache_behaviour((phys_addr_t)bd_space, BD_SPACE, DCACHE_OFF); buffer_loc.tx_descs = (struct mvneta_tx_desc *)bd_space;

From: Rabeeh Khoury rabeeh@solid-run.com
Make the initialization sequence consistent with the Linux kernel driver.
Reviewed-by: Stefan Roese sr@denx.de Acked-by: Joe Hershberger joe.hershberger@ni.com Signed-off-by: Rabeeh Khoury rabeeh@solid-run.com Signed-off-by: Baruch Siach baruch@tkos.co.il --- v2: No change --- drivers/net/mvneta.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c index 254dd04697db..ab697b9bc76e 100644 --- a/drivers/net/mvneta.c +++ b/drivers/net/mvneta.c @@ -1708,6 +1708,7 @@ static int mvneta_probe(struct udevice *dev) buffer_loc.tx_descs = (struct mvneta_tx_desc *)bd_space; size = roundup(MVNETA_MAX_TXD * sizeof(struct mvneta_tx_desc), ARCH_DMA_MINALIGN); + memset(buffer_loc.tx_descs, 0, size); buffer_loc.rx_descs = (struct mvneta_rx_desc *) ((phys_addr_t)bd_space + size); size += roundup(MVNETA_MAX_RXD * sizeof(struct mvneta_rx_desc),

Hi Baruch,
https://patchwork.ozlabs.org/patch/931795/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks! -Joe

Hi Baruch,
https://patchwork.ozlabs.org/patch/931797/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks! -Joe
participants (2)
-
Baruch Siach
-
Joe Hershberger