sandbox: "Reset Status: WARM Reset Status: COLD"

Hello Simon,
the sandbox prints the following line when started: "Reset Status: WARM Reset Status: COLD"
This does not make much sense. Either the last reset was WARM or COLD but not both.
sandbox_sysreset_get_status() and sandbox_warm_sysreset_get_status() should determine the reset status before printing anything incorrect.
After executing the reset command
state->last_sysreset == 4
This cannot be correct. It seems to be due to:
arch/sandbox/cpu/state.c:365: state->last_sysreset = SYSRESET_COUNT;
state_reset_for_test() should only be called in tests.
Best regards
Heinrich

Hi Heinrich,
On Thu, 29 Dec 2022 at 03:18, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Hello Simon,
the sandbox prints the following line when started: "Reset Status: WARM Reset Status: COLD"
This seems to be when you use the -T flag.
This does not make much sense. Either the last reset was WARM or COLD but not both.
Indeed!
sandbox_sysreset_get_status() and sandbox_warm_sysreset_get_status() should determine the reset status before printing anything incorrect.
After executing the reset command
state->last_sysreset == 4
This cannot be correct. It seems to be due to:
arch/sandbox/cpu/state.c:365: state->last_sysreset = SYSRESET_COUNT;
state_reset_for_test() should only be called in tests.
It needs to be called at init also. But actually the name is confusing. How about state_reset_common() or something like that?
For testing we have two sysreset devices. Perhaps print_resetinfo() should only print the first?
Regards, Simon
participants (2)
-
Heinrich Schuchardt
-
Simon Glass