[PATCH] net: eth-phy: Demote missing phy-handle log message to debug

Reduce the missing phy-handle log message to debug message. It is possible for ethernet DT node to have no phy-handle e.g. in case of a fixed-link connection. Furthermore, drop the FEC: prefix, which is a copy-paste error and rather print the ethernet device name.
Signed-off-by: Marek Vasut marex@denx.de Cc: Ramon Fried rfried.dev@gmail.com --- drivers/net/eth-phy-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/eth-phy-uclass.c b/drivers/net/eth-phy-uclass.c index a9b358ee234..1f285f7afd2 100644 --- a/drivers/net/eth-phy-uclass.c +++ b/drivers/net/eth-phy-uclass.c @@ -103,7 +103,7 @@ struct mii_dev *eth_phy_get_mdio_bus(struct udevice *eth_dev) return uc_priv->mdio_bus; } } else { - log_notice("FEC: can't find phy-handle\n"); + log_debug("Can't find phy-handle for %s\n", eth_dev->name); }
return NULL;

On Sat, Jan 1, 2022 at 9:12 PM Marek Vasut marex@denx.de wrote:
Reduce the missing phy-handle log message to debug message. It is possible for ethernet DT node to have no phy-handle e.g. in case of a fixed-link connection. Furthermore, drop the FEC: prefix, which is a copy-paste error and rather print the ethernet device name.
Signed-off-by: Marek Vasut marex@denx.de Cc: Ramon Fried rfried.dev@gmail.com
drivers/net/eth-phy-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/eth-phy-uclass.c b/drivers/net/eth-phy-uclass.c index a9b358ee234..1f285f7afd2 100644 --- a/drivers/net/eth-phy-uclass.c +++ b/drivers/net/eth-phy-uclass.c @@ -103,7 +103,7 @@ struct mii_dev *eth_phy_get_mdio_bus(struct udevice *eth_dev) return uc_priv->mdio_bus; } } else {
log_notice("FEC: can't find phy-handle\n");
log_debug("Can't find phy-handle for %s\n", eth_dev->name); } return NULL;
-- 2.34.1
Reviewed-by: Ramon Fried rfried.dev@gmail.com

On Sun, Jan 2, 2022 at 11:19 AM Ramon Fried rfried.dev@gmail.com wrote:
On Sat, Jan 1, 2022 at 9:12 PM Marek Vasut marex@denx.de wrote:
Reduce the missing phy-handle log message to debug message. It is possible for ethernet DT node to have no phy-handle e.g. in case of a fixed-link connection. Furthermore, drop the FEC: prefix, which is a copy-paste error and rather print the ethernet device name.
Signed-off-by: Marek Vasut marex@denx.de Cc: Ramon Fried rfried.dev@gmail.com
drivers/net/eth-phy-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/eth-phy-uclass.c b/drivers/net/eth-phy-uclass.c index a9b358ee234..1f285f7afd2 100644 --- a/drivers/net/eth-phy-uclass.c +++ b/drivers/net/eth-phy-uclass.c @@ -103,7 +103,7 @@ struct mii_dev *eth_phy_get_mdio_bus(struct udevice *eth_dev) return uc_priv->mdio_bus; } } else {
log_notice("FEC: can't find phy-handle\n");
log_debug("Can't find phy-handle for %s\n", eth_dev->name); } return NULL;
-- 2.34.1
Reviewed-by: Ramon Fried rfried.dev@gmail.com
Applied to u-boot-net/next Thanks !
participants (2)
-
Marek Vasut
-
Ramon Fried