[U-Boot] [PATCH v2] common: fix compiler warning on wrong printf format

From: Alexey Brodkin Alexey.Brodkin@synopsys.com
bounce_buffer->len_aligned is of type "size_t" so use "%zd".
this fixes following warning: --->--- common/bouncebuf.c: In function "addr_aligned": common/bouncebuf.c:26:3: warning: format "%d" expects argument of type "int", but argument 2 has type "size_t" [-Wformat=] debug("Unaligned buffer length %d\n", /*(int)*/state->len); ^ --->---
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com Cc: Vasili Galka vvv444@gmail.com Cc: Tom Rini trini@ti.com cc: Chris Packham judge.packham@gmail.com --- Compared to v1 proper format (%zd) is used in string instead of type casting. --- common/bouncebuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/bouncebuf.c b/common/bouncebuf.c index 9eece6d..8dde8fd 100644 --- a/common/bouncebuf.c +++ b/common/bouncebuf.c @@ -23,7 +23,7 @@ static int addr_aligned(struct bounce_buffer *state)
/* Check if length is aligned */ if (state->len != state->len_aligned) { - debug("Unaligned buffer length %d\n", state->len); + debug("Unaligned buffer length %zd\n", state->len); return 0; }

On Thu, Aug 28, 2014 at 4:15 PM, Alexey Brodkin <Alexey.Brodkin@synopsys.com
wrote:
From: Alexey Brodkin Alexey.Brodkin@synopsys.com
bounce_buffer->len_aligned is of type "size_t" so use "%zd".
this fixes following warning: --->--- common/bouncebuf.c: In function "addr_aligned": common/bouncebuf.c:26:3: warning: format "%d" expects argument of type "int", but argument 2 has type "size_t" [-Wformat=] debug("Unaligned buffer length %d\n", /*(int)*/state->len); ^ --->---
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com Cc: Vasili Galka vvv444@gmail.com Cc: Tom Rini trini@ti.com cc: Chris Packham judge.packham@gmail.com
Compared to v1 proper format (%zd) is used in string instead of type casting.
common/bouncebuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/bouncebuf.c b/common/bouncebuf.c index 9eece6d..8dde8fd 100644 --- a/common/bouncebuf.c +++ b/common/bouncebuf.c @@ -23,7 +23,7 @@ static int addr_aligned(struct bounce_buffer *state)
/* Check if length is aligned */ if (state->len != state->len_aligned) {
debug("Unaligned buffer length %d\n", state->len);
debug("Unaligned buffer length %zd\n", state->len); return 0; }
-- 1.9.3
Hmm, why not just use my original patch which included exactly this? http://patchwork.ozlabs.org/patch/383041/

Hi Vasili,
On Thu, 2014-08-28 at 17:17 +0300, Vasili Galka wrote:
On Thu, Aug 28, 2014 at 4:15 PM, Alexey Brodkin Alexey.Brodkin@synopsys.com wrote: From: Alexey Brodkin Alexey.Brodkin@synopsys.com
bounce_buffer->len_aligned is of type "size_t" so use "%zd". this fixes following warning: --->--- common/bouncebuf.c: In function "addr_aligned": common/bouncebuf.c:26:3: warning: format "%d" expects argument of type "int", but argument 2 has type "size_t" [-Wformat=] debug("Unaligned buffer length %d\n", /*(int)*/state->len); ^ --->---
Hmm, why not just use my original patch which included exactly this? http://patchwork.ozlabs.org/patch/383041/
Well, I'm not following all the messages sent to this mailing list so didn't know about your patch.
So as soon as I observed a problem I created a patch and sent it.
I see your patch fixes more things so definitely it should be applied instead.
Sorry for noise.
-Alexey

On Thu, Aug 28, 2014 at 5:33 PM, Alexey Brodkin < Alexey.Brodkin@synopsys.com> wrote:
Hi Vasili,
On Thu, 2014-08-28 at 17:17 +0300, Vasili Galka wrote:
On Thu, Aug 28, 2014 at 4:15 PM, Alexey Brodkin Alexey.Brodkin@synopsys.com wrote: From: Alexey Brodkin Alexey.Brodkin@synopsys.com
bounce_buffer->len_aligned is of type "size_t" so use "%zd". this fixes following warning: --->--- common/bouncebuf.c: In function "addr_aligned": common/bouncebuf.c:26:3: warning: format "%d" expects argument of type "int", but argument 2 has type "size_t" [-Wformat=] debug("Unaligned buffer length %d\n", /*(int)*/state->len); ^ --->---
Hmm, why not just use my original patch which included exactly this? http://patchwork.ozlabs.org/patch/383041/
Well, I'm not following all the messages sent to this mailing list so didn't know about your patch.
So as soon as I observed a problem I created a patch and sent it.
I see your patch fixes more things so definitely it should be applied instead.
Sorry for noise.
-Alexey
Oh, I thought you Cc'ed me because you seen it but decided to fix it in alternative way. Never mind, MY applogies for the noise :-)
Best, Vasili
participants (2)
-
Alexey Brodkin
-
Vasili Galka