[U-Boot] [PATCH] sunxi: sinovoip: Use proper naming convention for BPI boards
From: Jagan Teki jagan@amarulasolutions.com
- Rename Sinovoip BPI defconfigs to use small letter - To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker' - Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.
Cc: Icenowy Zheng icenowy@aosc.io Cc: Chen-Yu Tsai wens@csie.org Cc: VishnuPatekar vishnupatekar0510@gmail.com Signed-off-by: Jagan Teki jagan@amarulasolutions.com --- board/sunxi/MAINTAINERS | 10 +++++----- .../{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig} | 0 ...ip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} | 0 ...napi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} | 0 .../{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig} | 0 5 files changed, 5 insertions(+), 5 deletions(-) rename configs/{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig} (100%) rename configs/{Sinovoip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} (100%) rename configs/{Bananapi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} (100%) rename configs/{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig} (100%)
diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS index a512a20..61d1479 100644 --- a/board/sunxi/MAINTAINERS +++ b/board/sunxi/MAINTAINERS @@ -41,7 +41,7 @@ F: configs/CSQ_CS908_defconfig F: configs/inet_q972_defconfig F: configs/Mele_A1000G_quad_defconfig F: configs/Mele_M9_defconfig -F: configs/Sinovoip_BPI_M2_defconfig +F: configs/sinovoip_bpi_m2_defconfig F: include/configs/sun7i.h F: configs/A20-OLinuXino_MICRO_defconfig F: configs/Bananapi_defconfig @@ -108,10 +108,10 @@ M: Paul Kocialkowski contact@paulk.fr S: Maintained F: configs/Ampe_A76_defconfig
-BANANAPI M2 ULTRA BOARD +SINOVOIP BANANAPI M2 ULTRA BOARD M: Chen-Yu Tsai wens@csie.org S: Maintained -F: configs/Bananapi_M2_Ultra_defconfig +F: configs/sinovoip_bpi_m2_ultra_defconfig F: arch/arm/dts/sun8i-r40-bananapi-m2-ultra.dts
COLOMBUS BOARD @@ -287,12 +287,12 @@ W: http://linux-sunxi.org/Sinlinx_SinA33 SINOVOIP BPI M2 PLUS H3 BOARD M: Icenowy Zheng icenowy@aosc.io S: Maintained -F: configs/Sinovoip_BPI_M2_Plus_defconfig +F: configs/sinovoip_bpi_m2_Plus_defconfig
SINOVOIP BPI M3 A83T BOARD M: VishnuPatekar vishnupatekar0510@gmail.com S: Maintained -F: configs/Sinovoip_BPI_M3_defconfig +F: configs/sinovoip_bpi_m3_defconfig
SUNCHIP CX-A99 BOARD M: Rask Ingemann Lambertsen rask@formelder.dk diff --git a/configs/Sinovoip_BPI_M2_defconfig b/configs/sinovoip_bpi_m2_defconfig similarity index 100% rename from configs/Sinovoip_BPI_M2_defconfig rename to configs/sinovoip_bpi_m2_defconfig diff --git a/configs/Sinovoip_BPI_M2_Plus_defconfig b/configs/sinovoip_bpi_m2_plus_defconfig similarity index 100% rename from configs/Sinovoip_BPI_M2_Plus_defconfig rename to configs/sinovoip_bpi_m2_plus_defconfig diff --git a/configs/Bananapi_M2_Ultra_defconfig b/configs/sinovoip_bpi_m2_ultra_defconfig similarity index 100% rename from configs/Bananapi_M2_Ultra_defconfig rename to configs/sinovoip_bpi_m2_ultra_defconfig diff --git a/configs/Sinovoip_BPI_M3_defconfig b/configs/sinovoip_bpi_m3_defconfig similarity index 100% rename from configs/Sinovoip_BPI_M3_defconfig rename to configs/sinovoip_bpi_m3_defconfig
On Mon, May 29, 2017 at 10:24 PM, Jagan Teki jagan@openedev.com wrote:
From: Jagan Teki jagan@amarulasolutions.com
- Rename Sinovoip BPI defconfigs to use small letter
- To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker'
- Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.
No. The proper solution is to just get rid of the Sinovoip and LeMaker bullshit. The brand name has been and will continue to be "Banana Pi". Apart from the trademark legal drama between LeMaker, Sinovoip, and Foxconn, the boards are now consistently named "BPI-xyz". The original "Banana Pi" is now the "BPI-M1". The only incompatible outlier is the LeMaker made BananaPro.
LeMaker and Sinovoip are distributors. Maybe they manufacture(d) as well, but I'm not so sure.
Also, see https://www.spinics.net/lists/devicetree/msg176001.html
Note that "BIPAI KEJI LIMITED" is just a translation for BPI Technologies limited. BIPAI is the phonetics for B-PI in English. KEJI is the phonetics for "technology" in Chinese.
Finally, is there a preference for all lowercase defconfig file names?
Regards ChenYu
Cc: Icenowy Zheng icenowy@aosc.io Cc: Chen-Yu Tsai wens@csie.org Cc: VishnuPatekar vishnupatekar0510@gmail.com Signed-off-by: Jagan Teki jagan@amarulasolutions.com
board/sunxi/MAINTAINERS | 10 +++++----- .../{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig} | 0 ...ip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} | 0 ...napi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} | 0 .../{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig} | 0 5 files changed, 5 insertions(+), 5 deletions(-) rename configs/{Sinovoip_BPI_M2_defconfig => sinovoip_bpi_m2_defconfig} (100%) rename configs/{Sinovoip_BPI_M2_Plus_defconfig => sinovoip_bpi_m2_plus_defconfig} (100%) rename configs/{Bananapi_M2_Ultra_defconfig => sinovoip_bpi_m2_ultra_defconfig} (100%) rename configs/{Sinovoip_BPI_M3_defconfig => sinovoip_bpi_m3_defconfig} (100%)
diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS index a512a20..61d1479 100644 --- a/board/sunxi/MAINTAINERS +++ b/board/sunxi/MAINTAINERS @@ -41,7 +41,7 @@ F: configs/CSQ_CS908_defconfig F: configs/inet_q972_defconfig F: configs/Mele_A1000G_quad_defconfig F: configs/Mele_M9_defconfig -F: configs/Sinovoip_BPI_M2_defconfig +F: configs/sinovoip_bpi_m2_defconfig F: include/configs/sun7i.h F: configs/A20-OLinuXino_MICRO_defconfig F: configs/Bananapi_defconfig @@ -108,10 +108,10 @@ M: Paul Kocialkowski contact@paulk.fr S: Maintained F: configs/Ampe_A76_defconfig
-BANANAPI M2 ULTRA BOARD +SINOVOIP BANANAPI M2 ULTRA BOARD M: Chen-Yu Tsai wens@csie.org S: Maintained -F: configs/Bananapi_M2_Ultra_defconfig +F: configs/sinovoip_bpi_m2_ultra_defconfig F: arch/arm/dts/sun8i-r40-bananapi-m2-ultra.dts
COLOMBUS BOARD @@ -287,12 +287,12 @@ W: http://linux-sunxi.org/Sinlinx_SinA33 SINOVOIP BPI M2 PLUS H3 BOARD M: Icenowy Zheng icenowy@aosc.io S: Maintained -F: configs/Sinovoip_BPI_M2_Plus_defconfig +F: configs/sinovoip_bpi_m2_Plus_defconfig
SINOVOIP BPI M3 A83T BOARD M: VishnuPatekar vishnupatekar0510@gmail.com S: Maintained -F: configs/Sinovoip_BPI_M3_defconfig +F: configs/sinovoip_bpi_m3_defconfig
SUNCHIP CX-A99 BOARD M: Rask Ingemann Lambertsen rask@formelder.dk diff --git a/configs/Sinovoip_BPI_M2_defconfig b/configs/sinovoip_bpi_m2_defconfig similarity index 100% rename from configs/Sinovoip_BPI_M2_defconfig rename to configs/sinovoip_bpi_m2_defconfig diff --git a/configs/Sinovoip_BPI_M2_Plus_defconfig b/configs/sinovoip_bpi_m2_plus_defconfig similarity index 100% rename from configs/Sinovoip_BPI_M2_Plus_defconfig rename to configs/sinovoip_bpi_m2_plus_defconfig diff --git a/configs/Bananapi_M2_Ultra_defconfig b/configs/sinovoip_bpi_m2_ultra_defconfig similarity index 100% rename from configs/Bananapi_M2_Ultra_defconfig rename to configs/sinovoip_bpi_m2_ultra_defconfig diff --git a/configs/Sinovoip_BPI_M3_defconfig b/configs/sinovoip_bpi_m3_defconfig similarity index 100% rename from configs/Sinovoip_BPI_M3_defconfig rename to configs/sinovoip_bpi_m3_defconfig -- 1.9.1
On Mon, May 29, 2017 at 8:27 PM, Chen-Yu Tsai wens@csie.org wrote:
On Mon, May 29, 2017 at 10:24 PM, Jagan Teki jagan@openedev.com wrote:
From: Jagan Teki jagan@amarulasolutions.com
- Rename Sinovoip BPI defconfigs to use small letter
- To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker'
- Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.
No. The proper solution is to just get rid of the Sinovoip and LeMaker bullshit. The brand name has been and will continue to be "Banana Pi". Apart from the trademark legal drama between LeMaker, Sinovoip, and Foxconn, the boards are now consistently named "BPI-xyz". The original "Banana Pi" is now the "BPI-M1". The only incompatible outlier is the LeMaker made BananaPro.
But there is one board Bananapi_defconfig which is from LeMaker, which will conflict if we skip these and use binanapi for rest.
LeMaker and Sinovoip are distributors. Maybe they manufacture(d) as well, but I'm not so sure.
Also, see https://www.spinics.net/lists/devicetree/msg176001.html
Note that "BIPAI KEJI LIMITED" is just a translation for BPI Technologies limited. BIPAI is the phonetics for B-PI in English. KEJI is the phonetics for "technology" in Chinese.
Thanks for the info.
Finally, is there a preference for all lowercase defconfig file names?
Yes, for newly supported and/or longer stable defconfigs/boards follow lower-case defconfig file names in U-Boot.
thanks!
On Mon, May 29, 2017 at 11:37 PM, Jagan Teki jagannadh.teki@gmail.com wrote:
On Mon, May 29, 2017 at 8:27 PM, Chen-Yu Tsai wens@csie.org wrote:
On Mon, May 29, 2017 at 10:24 PM, Jagan Teki jagan@openedev.com wrote:
From: Jagan Teki jagan@amarulasolutions.com
- Rename Sinovoip BPI defconfigs to use small letter
- To avoid naming conflict with 'LeMaker' add sinovoip prefix to BPI M2 Ultra defconfig since bananapi is also name used by 'LeMaker'
- Add 'SINOVOIP' prefix 'BANANAPI M2 ULTRA BOARD' under board/sunxi/MAINTAINERS file.
No. The proper solution is to just get rid of the Sinovoip and LeMaker bullshit. The brand name has been and will continue to be "Banana Pi". Apart from the trademark legal drama between LeMaker, Sinovoip, and Foxconn, the boards are now consistently named "BPI-xyz". The original "Banana Pi" is now the "BPI-M1". The only incompatible outlier is the LeMaker made BananaPro.
But there is one board Bananapi_defconfig which is from LeMaker, which will conflict if we skip these and use binanapi for rest.
There's nothing that conflicts. Just like for the Cubieboards, Bananapi serves as the prefix. So the defconfigs would be named:
- Bananapi_defconfig (or Bananapi_M1_defconfig if you prefer) - Bananapi_M1_Plus_defconfig - Bananapi_M2_defconfig
and the list goes on.
LeMaker and Sinovoip are distributors. Maybe they manufacture(d) as well, but I'm not so sure.
Also, see https://www.spinics.net/lists/devicetree/msg176001.html
Note that "BIPAI KEJI LIMITED" is just a translation for BPI Technologies limited. BIPAI is the phonetics for B-PI in English. KEJI is the phonetics for "technology" in Chinese.
Thanks for the info.
Finally, is there a preference for all lowercase defconfig file names?
Yes, for newly supported and/or longer stable defconfigs/boards follow lower-case defconfig file names in U-Boot.
I see. Thanks!
ChenYu
participants (3)
-
Chen-Yu Tsai -
Jagan Teki -
Jagan Teki