Re: [U-Boot] [PATCH 2/3] colibri_t20: enable early pmic rail configuration
On 20 Aug 2015 22:01, Stephen Warren swarren@wwwdotorg.org wrote:
Rather than enable this with yet another CONFIG_ option, perhaps we can put this code into a C file dedicated to the colibri_t20 board, and then have the common code call it (and implement a weak function that does nothing to satisfy the linker on other boards).
I'm fine with that but during my initial investigation I noticed that there are at least 3 to 4 different ways how the early PMIC configuration could be realised just within the Tegra's and your proposal is not even one of them.
On 08/20/2015 05:13 PM, Marcel Ziswiler wrote:
On 20 Aug 2015 22:01, Stephen Warren swarren@wwwdotorg.org wrote:
Rather than enable this with yet another CONFIG_ option, perhaps we can put this code into a C file dedicated to the colibri_t20 board, and then have the common code call it (and implement a weak function that does nothing to satisfy the linker on other boards).
I'm fine with that but during my initial investigation I noticed that there are at least 3 to 4 different ways how the early PMIC configuration could be realised just within the Tegra's and your proposal is not even one of them.
My proposal has nothing to do with how the PMIC code is implemented, simply where to invoke it. This ensures that board-specific code doesn't get dumped into core files.
participants (2)
-
Marcel Ziswiler -
Stephen Warren