[U-Boot] [PATCH v5 2/2] OMAP3: igep00x0: add boot status GPIO LED
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk ---
Changes since v4: - Since gpio_direction_output() sets the value, there is no need to call gpio_set_value() as suggested by Igor Grinberg.
Changes since v3: - Avoid code duplication but having a single show_boot_progress() function as suggested by Wolfgang Denk.
Changes since v2: - Use show_boot_progress() instead implementing yet another boot status signalling as suggested by Wolfgang Denk.
Changes since v1: - Don't set gd->bd->bi_arch_number since is done in arch/arm/lib/board.c - Use CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020 instead of check bi_arch_number as suggested by Igor Grinberg.
board/isee/igep00x0/igep00x0.c | 13 +++++++++++++ board/isee/igep00x0/igep00x0.h | 8 ++++++++ include/configs/igep00x0.h | 3 +++ 3 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c index fe3522a..931416a 100644 --- a/board/isee/igep00x0/igep00x0.c +++ b/board/isee/igep00x0/igep00x0.c @@ -60,6 +60,19 @@ int board_init(void) return 0; }
+#if defined(CONFIG_SHOW_BOOT_PROGRESS) && !defined(CONFIG_SPL_BUILD) +void show_boot_progress(int val) +{ + if (val < 0) { + /* something went wrong */ + return; + } + + if (!gpio_request(IGEP00X0_GPIO_LED, "")) + gpio_direction_output(IGEP00X0_GPIO_LED, 1); +} +#endif + #ifdef CONFIG_SPL_BUILD /* * Routine: omap_rev_string diff --git a/board/isee/igep00x0/igep00x0.h b/board/isee/igep00x0/igep00x0.h index 3133e41..fefdb89 100644 --- a/board/isee/igep00x0/igep00x0.h +++ b/board/isee/igep00x0/igep00x0.h @@ -23,6 +23,14 @@ #ifndef _IGEP00X0_H_ #define _IGEP00X0_H_
+#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020) +#define IGEP00X0_GPIO_LED 27 +#endif + +#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030) +#define IGEP00X0_GPIO_LED 16 +#endif + const omap3_sysinfo sysinfo = { DDR_STACKED, #if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020) diff --git a/include/configs/igep00x0.h b/include/configs/igep00x0.h index 15e233b..47f637e 100644 --- a/include/configs/igep00x0.h +++ b/include/configs/igep00x0.h @@ -82,6 +82,9 @@ #define CONFIG_OMAP_HSMMC 1 #define CONFIG_DOS_PARTITION 1
+/* define to enable boot progress via leds */ +#define CONFIG_SHOW_BOOT_PROGRESS + /* USB */ #define CONFIG_MUSB_UDC 1 #define CONFIG_USB_OMAP3 1
On 12/27/12 15:36, Javier Martinez Canillas wrote:
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk
Acked-by: Igor Grinberg grinberg@compulab.co.il
On Thu, Dec 27, 2012 at 3:25 PM, Igor Grinberg grinberg@compulab.co.il wrote:
On 12/27/12 15:36, Javier Martinez Canillas wrote:
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk
Acked-by: Igor Grinberg grinberg@compulab.co.il
Hello Tom,
Any news of merging this patch?
Thanks a lot and best regards, Javier
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 04:43 AM, Javier Martinez Canillas wrote:
On Thu, Dec 27, 2012 at 3:25 PM, Igor Grinberg grinberg@compulab.co.il wrote:
On 12/27/12 15:36, Javier Martinez Canillas wrote:
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk
Acked-by: Igor Grinberg grinberg@compulab.co.il
Hello Tom,
Any news of merging this patch?
Things look good, sorry. I'm going to try and get to starting a next branch but I might not get a chance before the next release.
- -- Tom
On Thu, Jan 10, 2013 at 4:35 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 04:43 AM, Javier Martinez Canillas wrote:
On Thu, Dec 27, 2012 at 3:25 PM, Igor Grinberg grinberg@compulab.co.il wrote:
On 12/27/12 15:36, Javier Martinez Canillas wrote:
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk
Acked-by: Igor Grinberg grinberg@compulab.co.il
Hello Tom,
Any news of merging this patch?
Things look good, sorry. I'm going to try and get to starting a next branch but I might not get a chance before the next release.
Tom
Great, waiting for the next release is not an issue.
There are also two more patches for IGEP boards that were acked but not picked for this release:
[U-Boot,v2,1/2] OMAP3: use a single board file for IGEP devices [1] [U-Boot,1/1] OMAP3: igep00x0: add CONFIG_SPL_BOARD_INIT for CONFIG_SPL_NAND_SUPPORT [2]
Thanks a lot and best regards, Javier
[1]: http://patchwork.ozlabs.org/patch/208296/ [2]: http://patchwork.ozlabs.org/patch/208481/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 11:16 AM, Javier Martinez Canillas wrote:
On Thu, Jan 10, 2013 at 4:35 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 04:43 AM, Javier Martinez Canillas wrote:
On Thu, Dec 27, 2012 at 3:25 PM, Igor Grinberg grinberg@compulab.co.il wrote:
On 12/27/12 15:36, Javier Martinez Canillas wrote:
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk
Acked-by: Igor Grinberg grinberg@compulab.co.il
Hello Tom,
Any news of merging this patch?
Things look good, sorry. I'm going to try and get to starting a next branch but I might not get a chance before the next release.
- -- Tom
Great, waiting for the next release is not an issue.
There are also two more patches for IGEP boards that were acked but not picked for this release:
[U-Boot,v2,1/2] OMAP3: use a single board file for IGEP devices [1] [U-Boot,1/1] OMAP3: igep00x0: add CONFIG_SPL_BOARD_INIT for CONFIG_SPL_NAND_SUPPORT [2]
For the second path, did SPL+NAND for the IGEP devices get added already?
- -- Tom
On Thu, Jan 10, 2013 at 6:26 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 11:16 AM, Javier Martinez Canillas wrote:
On Thu, Jan 10, 2013 at 4:35 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 04:43 AM, Javier Martinez Canillas wrote:
On Thu, Dec 27, 2012 at 3:25 PM, Igor Grinberg grinberg@compulab.co.il wrote:
On 12/27/12 15:36, Javier Martinez Canillas wrote:
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk
Acked-by: Igor Grinberg grinberg@compulab.co.il
Hello Tom,
Any news of merging this patch?
Things look good, sorry. I'm going to try and get to starting a next branch but I might not get a chance before the next release.
- -- Tom
Great, waiting for the next release is not an issue.
There are also two more patches for IGEP boards that were acked but not picked for this release:
[U-Boot,v2,1/2] OMAP3: use a single board file for IGEP devices [1] [U-Boot,1/1] OMAP3: igep00x0: add CONFIG_SPL_BOARD_INIT for CONFIG_SPL_NAND_SUPPORT [2]
For the second path, did SPL+NAND for the IGEP devices get added already?
Tom
Yes, it was added on mainline commit d271a6114 "OMAP3: igep00x0: add SPL support for IGEP-based boards"
Before posting that patch I only tested SPL booting from the uSD/MMC and later when trying SPL boot from NAND I realized that CONFIG_SPL_BOARD_INIT was missing to initialize the GPMC.
Sorry, my bad. I should have tested both MMC and NAND booting before posting the SPL support patch.
Thanks a lot and best regards, Javier
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 02:26 PM, Javier Martinez Canillas wrote:
On Thu, Jan 10, 2013 at 6:26 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 11:16 AM, Javier Martinez Canillas wrote:
On Thu, Jan 10, 2013 at 4:35 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/10/2013 04:43 AM, Javier Martinez Canillas wrote:
On Thu, Dec 27, 2012 at 3:25 PM, Igor Grinberg grinberg@compulab.co.il wrote:
On 12/27/12 15:36, Javier Martinez Canillas wrote: > This patch adds an GPIO LED boot status for IGEP > boards. > > The GPIO LED used is the red LED0 while the Linux > kernel uses the green LED0 as the boot status. > > By using different GPIO LEDs, the user can know in > which step of the boot process the board currently is. > > Signed-off-by: Javier Martinez Canillas > javier.martinez@collabora.co.uk
Acked-by: Igor Grinberg grinberg@compulab.co.il
Hello Tom,
Any news of merging this patch?
Things look good, sorry. I'm going to try and get to starting a next branch but I might not get a chance before the next release.
- -- Tom
Great, waiting for the next release is not an issue.
There are also two more patches for IGEP boards that were acked but not picked for this release:
[U-Boot,v2,1/2] OMAP3: use a single board file for IGEP devices [1] [U-Boot,1/1] OMAP3: igep00x0: add CONFIG_SPL_BOARD_INIT for CONFIG_SPL_NAND_SUPPORT [2]
For the second path, did SPL+NAND for the IGEP devices get added already?
- -- Tom
Yes, it was added on mainline commit d271a6114 "OMAP3: igep00x0: add SPL support for IGEP-based boards"
Before posting that patch I only tested SPL booting from the uSD/MMC and later when trying SPL boot from NAND I realized that CONFIG_SPL_BOARD_INIT was missing to initialize the GPMC.
Sorry, my bad. I should have tested both MMC and NAND booting before posting the SPL support patch.
OK, that makes it a bugfix. Albert, OK if I pull a bugfix patch (adding a #define to a config) for a TI platform into master or do you want it to go via u-boot-ti -> u-boot-arm ? Thanks!
- -- Tom
On Thu, Dec 27, 2012 at 03:36:01AM -0000, Javier Martinez Canillas wrote:
This patch adds an GPIO LED boot status for IGEP boards.
The GPIO LED used is the red LED0 while the Linux kernel uses the green LED0 as the boot status.
By using different GPIO LEDs, the user can know in which step of the boot process the board currently is.
Signed-off-by: Javier Martinez Canillas javier.martinez@collabora.co.uk Acked-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot-ti/master, thanks!
participants (3)
-
Igor Grinberg -
Javier Martinez Canillas -
Tom Rini