[U-Boot-Users] FWD: SNTP support patch
[Forwarded on behalf of Masami Komiya.]
------- Forwarded Message
Date: Wed, 30 Mar 2005 16:42:03 +0900 From: Masami Komiya mkomiya@sonare.it To: Wolfgang Denk wd@denx.de cc: "Sonare IT - Komiya" mkomiya@sonare.it Subject: SNTP support patch
Dear Wolfgang,
No time see you.
I make a patch to add SNTP support and expand time server and time offset fields of DHCP support. (The roundtrip delay is ignored :-)
I want to send this patch to ML, but the mail server of SourceForge does not accept from me ;_;) If you think this is useful for U-BOOT, please forward to ML.
To use SNTP support, please add the define CFG_CMD_SNTP to CONFIG_COMMANDS in the configuration file of the board.
The "sntp" command gets network time from NTP time server and syncronize RTC of the board. This command needs the command line parameter of server's IP address or environment variable "timeserverip". The network time is sent as UTC. So if you want to set local time to RTC, set the offset in second from UTC to the enviroment variable "time offset".
If DHCP server provides time server's IP or time offset, you don't need to set the above environment variables yourself.
Any advice or comment are wellcome!!
Best regards.
Masami Komiya
------- End of Forwarded Message
There are some wrong code about DHCP expansion in the last patch to add SNTP support. Please apply attached patch too.
The name of environment variable for NTP time server IP address is changed to "ntpserverip".
The current limitation of SNTP support is : 1. The roundtrip time is ignored. 2. Only 1st NTP server IP, in the option ntp-servers of DHCP, is effective.
Thank you for your any advice.
Masami Komiya
Wolfgang Denk wrote:
[Forwarded on behalf of Masami Komiya.]
------- Forwarded Message
Date: Wed, 30 Mar 2005 16:42:03 +0900 From: Masami Komiya mkomiya@sonare.it To: Wolfgang Denk wd@denx.de cc: "Sonare IT - Komiya" mkomiya@sonare.it Subject: SNTP support patch
Dear Wolfgang,
No time see you.
I make a patch to add SNTP support and expand time server and time offset fields of DHCP support. (The roundtrip delay is ignored :-)
I want to send this patch to ML, but the mail server of SourceForge does not accept from me ;_;) If you think this is useful for U-BOOT, please forward to ML.
To use SNTP support, please add the define CFG_CMD_SNTP to CONFIG_COMMANDS in the configuration file of the board.
The "sntp" command gets network time from NTP time server and syncronize RTC of the board. This command needs the command line parameter of server's IP address or environment variable "timeserverip". The network time is sent as UTC. So if you want to set local time to RTC, set the offset in second from UTC to the enviroment variable "time offset".
If DHCP server provides time server's IP or time offset, you don't need to set the above environment variables yourself.
Any advice or comment are wellcome!!
Best regards.
Masami Komiya
------- End of Forwarded Message
In message 424BAFC4.7030009@sonare.it you wrote:
There are some wrong code about DHCP expansion in the last patch to add SNTP support. Please apply attached patch too.
Done. Thanks.
Best regards,
Wolfgang Denk
In message 20050330205446.E062AC108D@atlas.denx.de you wrote:
I make a patch to add SNTP support and expand time server and time offset fields of DHCP support. (The roundtrip delay is ignored :-)
Added, thanks.
Best regards,
Wolfgang Denk
On Wed, Mar 30, 2005 at 10:54:41PM +0200, Wolfgang Denk wrote:
[Forwarded on behalf of Masami Komiya.]
------- Forwarded Message
Date: Wed, 30 Mar 2005 16:42:03 +0900 From: Masami Komiya mkomiya@sonare.it To: Wolfgang Denk wd@denx.de cc: "Sonare IT - Komiya" mkomiya@sonare.it Subject: SNTP support patch
Dear Wolfgang,
No time see you.
I make a patch to add SNTP support and expand time server and time offset fields of DHCP support. (The roundtrip delay is ignored :-)
Extenting proto_t enum rings bell here. Please consider applying following inliner.
Index: common/cmd_net.c =================================================================== RCS file: /cvsroot/u-boot/u-boot/common/cmd_net.c,v retrieving revision 1.15 diff -u -r1.15 cmd_net.c --- common/cmd_net.c 2 Apr 2005 22:37:55 -0000 1.15 +++ common/cmd_net.c 5 Apr 2005 14:44:42 -0000 @@ -33,7 +33,7 @@
extern int do_bootm (cmd_tbl_t *, int, int, char *[]);
-static int netboot_common (int, cmd_tbl_t *, int , char *[]); +static int netboot_common (proto_t, cmd_tbl_t *, int , char *[]);
int do_bootp (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) { @@ -152,7 +152,7 @@ }
static int -netboot_common (int proto, cmd_tbl_t *cmdtp, int argc, char *argv[]) +netboot_common (proto_t proto, cmd_tbl_t *cmdtp, int argc, char *argv[]) { char *s; int rcode = 0;
In message 20050405145127.GA9944@orphique you wrote:
Extenting proto_t enum rings bell here. Please consider applying following inliner.
Thanks, added.
But please provide a proper patch next time (CHANGELOG entry).
Best regards,
Wolfgang Denk
participants (3)
-
Ladislav Michl -
Masami Komiya -
Wolfgang Denk