Re: [U-Boot] [PATCH] ARM: board: cm-fx6: fix mmc for old revisions of utilite
Hi Nikita,
On 06/15/2016 05:15 PM, Nikita Kiryanov wrote:
Hi CHristopher,
On Wed, Jun 08, 2016 at 09:02:36PM +0200, Christopher Spinrath wrote:
Old revisions of Utilite (based on cmfx6) do not have a dedicated card detect pin. But the card is removable by the user and card detection can be realized with polling (e.g. supported by Linux).
Add the broken-cd property to the mmc device tree instead of the non-removable property to make card detection possible if polling is supported.
Acked-by: Nikita Kiryanov nikita@compulab.co.il
How is this patch (and, in general, patches for Utilite/cm-fx6) supposed to be merged? Due to get_maintainers your are (the only) maintainer related to the cm-fx6 board. Do you want me to resend the patch (without the Fixes: tag)?
One nit-pick below:
Fixes: 41855186afd3 ("arm: mx6: cm-fx6: modify device tree for old revisions of utilite")
This isn't technically a fix; you're enabling new functionality. The original behavior wasn't buggy, it just lacked the card detect feature.
Well, the card is clearly removable. So IMHO adding the non-removable property is wrong and this patch corrects/fixes it. But I'm fine either way.
Thanks, Christopher
Signed-off-by: Christopher Spinrath christopher.spinrath@rwth-aachen.de
board/compulab/cm_fx6/cm_fx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
-- 2.8.3
Regards, Nikita Kiryanov
Hi Christopher,
On 06/15/2016 06:38 PM, Christopher Spinrath wrote:
Hi Nikita,
On 06/15/2016 05:15 PM, Nikita Kiryanov wrote:
Hi CHristopher,
On Wed, Jun 08, 2016 at 09:02:36PM +0200, Christopher Spinrath wrote:
Old revisions of Utilite (based on cmfx6) do not have a dedicated card detect pin. But the card is removable by the user and card detection can be realized with polling (e.g. supported by Linux).
Add the broken-cd property to the mmc device tree instead of the non-removable property to make card detection possible if polling is supported.
Acked-by: Nikita Kiryanov nikita@compulab.co.il
How is this patch (and, in general, patches for Utilite/cm-fx6) supposed to be merged?
Well, you've done this almost correctly. You just need to add Stefano Babic sbabic@denx.de (who is the maintainer of imx) to "cc" or "to" list. Added now.
Due to get_maintainers your are (the only) maintainer related to the cm-fx6 board.
That is a separate discussion (e.g. how boards of a specific vendor, but different architectures/platforms should be listed in the MAINTAINERS files).
Do you want me to resend the patch (without the Fixes: tag)?
One nit-pick below:
Fixes: 41855186afd3 ("arm: mx6: cm-fx6: modify device tree for old revisions of utilite")
This isn't technically a fix; you're enabling new functionality. The original behavior wasn't buggy, it just lacked the card detect feature.
Well, the card is clearly removable. So IMHO adding the non-removable property is wrong and this patch corrects/fixes it. But I'm fine either way.
Just a little explanation... Mechanically the card _is_ removable, but for revisions < 1.3, it will result in errors on the bus as no removal event will be sent to the subsystem. Moreover, if I'm not mistaken, you have the PRO model, right? In PRO model, you have internal storage (e.g. SSD) which makes the SD card an additional and sensibly removable device... There are additional Utilite models which have the SD card as the only storage device and those models have the rootfs on the SD card. In such case, IMO, it is much more appropriate to state that it should be non-removable.
Hi Christopher,
On Wed, Jun 15, 2016 at 05:38:10PM +0200, Christopher Spinrath wrote:
Hi Nikita,
On 06/15/2016 05:15 PM, Nikita Kiryanov wrote:
Hi CHristopher,
On Wed, Jun 08, 2016 at 09:02:36PM +0200, Christopher Spinrath wrote:
Old revisions of Utilite (based on cmfx6) do not have a dedicated card detect pin. But the card is removable by the user and card detection can be realized with polling (e.g. supported by Linux).
Add the broken-cd property to the mmc device tree instead of the non-removable property to make card detection possible if polling is supported.
Acked-by: Nikita Kiryanov nikita@compulab.co.il
How is this patch (and, in general, patches for Utilite/cm-fx6) supposed to be merged? Due to get_maintainers your are (the only) maintainer related to the cm-fx6 board. Do you want me to resend the patch (without the Fixes: tag)?
One nit-pick below:
Fixes: 41855186afd3 ("arm: mx6: cm-fx6: modify device tree for old revisions of utilite")
This isn't technically a fix; you're enabling new functionality. The original behavior wasn't buggy, it just lacked the card detect feature.
Well, the card is clearly removable. So IMHO adding the non-removable property is wrong and this patch corrects/fixes it. But I'm fine either way.
I prefer it without the "Fixes" line, because to me it implies a bug fix whereas the behavior in the linked patch was an intentional compromise.
Regards, Nikita Kiryanov
participants (3)
-
Christopher Spinrath -
Igor Grinberg -
Nikita Kiryanov