[U-Boot] [PATCH] Revert "imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS"

Commit c1ebf54868359005 ("imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS") causes SPL breakage on wandboard:
ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ** First descriptor is NOT a primary desc on 0:1 ** spl: no partition table found SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ###
This error is seen when SPL and u-boot.img are stored in the raw SD card partition.
This reverts commit c1ebf54868359005c32944c1473668d5fcaca158.
Signed-off-by: Breno Lima breno.lima@nxp.com --- arch/arm/imx-common/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/imx-common/spl.c b/arch/arm/imx-common/spl.c index 0c1e401..bdcda7d 100644 --- a/arch/arm/imx-common/spl.c +++ b/arch/arm/imx-common/spl.c @@ -76,7 +76,7 @@ u32 spl_boot_mode(const u32 boot_device) /* for MMC return either RAW or FAT mode */ case BOOT_DEVICE_MMC1: case BOOT_DEVICE_MMC2: -#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT) +#if defined(CONFIG_SPL_FAT_SUPPORT) return MMCSD_MODE_FS; #elif defined(CONFIG_SUPPORT_EMMC_BOOT) return MMCSD_MODE_EMMCBOOT;

On Wed, Jul 20, 2016 at 4:55 PM, Breno Lima breno.lima@nxp.com wrote:
Commit c1ebf54868359005 ("imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS") causes SPL breakage on wandboard:
ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ** First descriptor is NOT a primary desc on 0:1 ** spl: no partition table found SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ###
This error is seen when SPL and u-boot.img are stored in the raw SD card partition.
This reverts commit c1ebf54868359005c32944c1473668d5fcaca158.
Signed-off-by: Breno Lima breno.lima@nxp.com
Thanks for the fix:
Reviewed-by: Fabio Estevam fabio.estevam@nxp.com

Hi Breno,
Am 20.07.2016 um 22:20 schrieb Fabio Estevam:
On Wed, Jul 20, 2016 at 4:55 PM, Breno Lima breno.lima@nxp.com wrote:
Commit c1ebf54868359005 ("imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS") causes SPL breakage on wandboard:
ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ** First descriptor is NOT a primary desc on 0:1 ** spl: no partition table found SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ###
This error is seen when SPL and u-boot.img are stored in the raw SD card partition.
This reverts commit c1ebf54868359005c32944c1473668d5fcaca158.
Signed-off-by: Breno Lima breno.lima@nxp.com
Thanks for the fix:
Reviewed-by: Fabio Estevam fabio.estevam@nxp.com
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic
participants (3)
-
Breno Lima
-
Fabio Estevam
-
stefano babic