[U-Boot] [PATCH 0/3] fix: Trats/Trats2 default envs adjustement for 2014.01 release
Adjust default envs for Trats and Trats2 boards. Those changes are supposed to cleanup and improve things for v2014.01 u-boot release.
Lukasz Majewski (3): config: Update envs for trats and trats2 - new entries for new partitions ARM: trats2: dfu: Enable default Poll Timeout for Trats2 board config: Update envs for trats and trats2 - Disable L2 cache
include/configs/trats.h | 6 +++++- include/configs/trats2.h | 7 ++++++- 2 files changed, 11 insertions(+), 2 deletions(-)
This patch adds extra dfu_alt_info entries to support storing the whole BOOT , DATA and UMS partitions. This allows upgrade of uImage and device tree blob (dtb) files at once.
Now it is also possible to store ext4 rootfs prepared with well established linux tools (like mkfs.ext4).
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
--- Changes for v2: - New partions added Change-Id: I97aaa95e2745736de417bd07dbe2433dfff0f02c --- include/configs/trats.h | 5 ++++- include/configs/trats2.h | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/configs/trats.h b/include/configs/trats.h index 6cd15c2..0bdfe86 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -143,7 +143,10 @@ "u-boot mmc 80 400;" \ "uImage ext4 0 2;" \ "exynos4210-trats.dtb ext4 0 2;" \ - ""PARTS_ROOT" part 0 5\0" + ""PARTS_BOOT" part 0 2;" \ + ""PARTS_ROOT" part 0 5;" \ + ""PARTS_DATA" part 0 6;" \ + ""PARTS_UMS" part 0 7\0"
#define CONFIG_ENV_OVERWRITE #define CONFIG_SYS_CONSOLE_INFO_QUIET diff --git a/include/configs/trats2.h b/include/configs/trats2.h index c9ce828..f335280 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -173,7 +173,10 @@ "u-boot mmc 80 800;" \ "uImage ext4 0 2;" \ "exynos4412-trats2.dtb ext4 0 2;" \ - ""PARTS_ROOT" part 0 5\0" + ""PARTS_BOOT" part 0 2;" \ + ""PARTS_ROOT" part 0 5;" \ + ""PARTS_DATA" part 0 6;" \ + ""PARTS_UMS" part 0 7\0"
#define CONFIG_EXTRA_ENV_SETTINGS \ "bootk=" \
On 14/01/14 16:02, Lukasz Majewski wrote:
This patch adds extra dfu_alt_info entries to support storing the whole BOOT , DATA and UMS partitions. This allows upgrade of uImage and device tree blob (dtb) files at once.
Now it is also possible to store ext4 rootfs prepared with well established linux tools (like mkfs.ext4).
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Changes for v2:
- New partions added
Change-Id: I97aaa95e2745736de417bd07dbe2433dfff0f02c
include/configs/trats.h | 5 ++++- include/configs/trats2.h | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
Acked-by: Minkyu Kang mk7.kang@samsung.com
Thanks, Minkyu Kang.
On Tue, Jan 14, 2014 at 08:02 +0100, Lukasz Majewski wrote:
diff --git a/include/configs/trats.h b/include/configs/trats.h index 6cd15c2..0bdfe86 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -143,7 +143,10 @@ "u-boot mmc 80 400;" \ "uImage ext4 0 2;" \ "exynos4210-trats.dtb ext4 0 2;" \
- ""PARTS_ROOT" part 0 5\0"
- ""PARTS_BOOT" part 0 2;" \
- ""PARTS_ROOT" part 0 5;" \
- ""PARTS_DATA" part 0 6;" \
- ""PARTS_UMS" part 0 7\0"
Have recent compilers become stricter about string concatenation? ISTR that a space is recommended (which helps human readers as well).
virtually yours Gerhard Sittig
Hi Gerard,
On Tue, Jan 14, 2014 at 08:02 +0100, Lukasz Majewski wrote:
diff --git a/include/configs/trats.h b/include/configs/trats.h index 6cd15c2..0bdfe86 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -143,7 +143,10 @@ "u-boot mmc 80 400;" \ "uImage ext4 0 2;" \ "exynos4210-trats.dtb ext4 0 2;" \
- ""PARTS_ROOT" part 0 5\0"
- ""PARTS_BOOT" part 0 2;" \
- ""PARTS_ROOT" part 0 5;" \
- ""PARTS_DATA" part 0 6;" \
- ""PARTS_UMS" part 0 7\0"
Have recent compilers become stricter about string concatenation?
I'm using ELDK 5.3 toolchain and this code compiles without warnings. Also I've tested it with Pengutronix's OSELAS 4.8.2 (OSEALS 2013.12).
ISTR that a space is recommended (which helps human readers as well).
Could you be more specific about the missing space?
Also, since we close the release in a few days, I'd like to ask for pulling this code as it is.
Those are envs related to DFU/THOR, so probably will be changed in a near future.
virtually yours Gerhard Sittig
Best regards, Lukasz Majewski
On Wed, Jan 15, 2014 at 21:32 +0100, Lukasz Majewski wrote:
Hi Gerard,
On Tue, Jan 14, 2014 at 08:02 +0100, Lukasz Majewski wrote:
diff --git a/include/configs/trats.h b/include/configs/trats.h index 6cd15c2..0bdfe86 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -143,7 +143,10 @@ "u-boot mmc 80 400;" \ "uImage ext4 0 2;" \ "exynos4210-trats.dtb ext4 0 2;" \
- ""PARTS_ROOT" part 0 5\0"
- ""PARTS_BOOT" part 0 2;" \
- ""PARTS_ROOT" part 0 5;" \
- ""PARTS_DATA" part 0 6;" \
- ""PARTS_UMS" part 0 7\0"
Have recent compilers become stricter about string concatenation?
I'm using ELDK 5.3 toolchain and this code compiles without warnings. Also I've tested it with Pengutronix's OSELAS 4.8.2 (OSEALS 2013.12).
With "recent" I meant "so recent that they are not yet in widespread use". Can't even remember whether it was a specific version of a compiler, or a pending C language standard that was said to become stricter, my memory is failing on me. Is there someone around with better memorization capabilities? :)
ISTR that a space is recommended (which helps human readers as well).
Could you be more specific about the missing space?
What I meant is quite simple. Put whitespace between the strings that you want to have concatenated. Instead of
""PARTS_BOOT" part 0 5\0"
write something "more portable" (and more readable?) like
"" PARTS_BOOT " part 0 5\0"
which should not be too much of an issue. It's not that the semantics of string concatenation would change, it's just that syntax is expected to become stricter, and code should not (ab)use the gray areas that one currently may get away with.
Also, since we close the release in a few days, I'd like to ask for pulling this code as it is.
No problem there, I was just trying to raise or keep awareness. Just queue another editor session and follow up with a cleanup later. Even better if you will touch the code anyway.
virtually yours Gerhard Sittig
Dear Gerhard Sittig,
In message 20140116161026.GX20094@book.gsilab.sittig.org you wrote:
write something "more portable" (and more readable?) like
"" PARTS_BOOT " part 0 5\0"
What would the "" be needed for anyway?
Best regards,
Wolfgang Denk
On Thu, Jan 16, 2014 at 23:12 +0100, Wolfgang Denk wrote:
Dear Gerhard Sittig,
In message 20140116161026.GX20094@book.gsilab.sittig.org you wrote:
write something "more portable" (and more readable?) like
"" PARTS_BOOT " part 0 5\0"
What would the "" be needed for anyway?
It wouldn't. It just was there before, and could remain there since it "does nothing" (concatenates an empty string, like adding zero, or multiplying by one -- sometimes it's nice for a uniform layout, sometimes it's more confusing than helping). Removing this neutral element is an option, yet not strictly necessary. I was more concerned about potential build breakage than (function wise neutral) style issues.
virtually yours Gerhard Sittig
On Tue, Jan 14, 2014 at 08:02:24AM +0100, Łukasz Majewski wrote:
This patch adds extra dfu_alt_info entries to support storing the whole BOOT , DATA and UMS partitions. This allows upgrade of uImage and device tree blob (dtb) files at once.
Now it is also possible to store ext4 rootfs prepared with well established linux tools (like mkfs.ext4).
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Acked-by: Minkyu Kang mk7.kang@samsung.com
Applied to u-boot/master, thanks!
Provide default Poll Timeout value for Trats2 board.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
--- Changes for v2: - None Change-Id: I06ee5c228fa4f92ab445333cbdb12464944daa35 --- include/configs/trats2.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/configs/trats2.h b/include/configs/trats2.h index f335280..8e4b215 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -114,6 +114,7 @@ /* USB Composite download gadget - g_dnl */ #define CONFIG_USBDOWNLOAD_GADGET #define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M +#define DFU_DEFAULT_POLL_TIMEOUT 300 #define CONFIG_DFU_FUNCTION #define CONFIG_DFU_MMC
On 14/01/14 16:02, Lukasz Majewski wrote:
Provide default Poll Timeout value for Trats2 board.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
Changes for v2:
- None
Change-Id: I06ee5c228fa4f92ab445333cbdb12464944daa35
include/configs/trats2.h | 1 + 1 file changed, 1 insertion(+)
Acked-by: Minkyu Kang mk7.kang@samsung.com
Thanks, Minkyu Kang.
On Tue, Jan 14, 2014 at 08:02:25AM +0100, Łukasz Majewski wrote:
Provide default Poll Timeout value for Trats2 board.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Acked-by: Minkyu Kang mk7.kang@samsung.com
Applied to u-boot/master, thanks!
Disable L2 caches for Trats and Trats2 devices.
It turns out that for data downloading with thordown command L2 cache disablement brings a significant speed improvement.
rootfs - 400 MiB: - L2 cache enabled: 2.69 MiB/s - L2 cache disabled: 5.56 MiB/s
Such improvement is possible due to reduction of the need to invalidate redundant data, which resides in L2 cache.
Since the sent USB request size at once is 512B (L1 - 32 KiB in total) - one can be quite confident that it is already available in L1 and L2 can be disabled.
Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b Signed-off-by: Lukasz Majewski l.majewski@samsung.com --- include/configs/trats.h | 1 + include/configs/trats2.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/include/configs/trats.h b/include/configs/trats.h index 0bdfe86..fdd8b46 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -27,6 +27,7 @@ #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO
+#define CONFIG_SYS_L2CACHE_OFF #ifndef CONFIG_SYS_L2CACHE_OFF #define CONFIG_SYS_L2_PL310 #define CONFIG_SYS_PL310_BASE 0x10502000 diff --git a/include/configs/trats2.h b/include/configs/trats2.h index 8e4b215..83633b0 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -30,6 +30,7 @@
#define CONFIG_SYS_CACHELINE_SIZE 32
+#define CONFIG_SYS_L2CACHE_OFF #ifndef CONFIG_SYS_L2CACHE_OFF #define CONFIG_SYS_L2_PL310 #define CONFIG_SYS_PL310_BASE 0x10502000
On 14/01/14 16:02, Lukasz Majewski wrote:
Disable L2 caches for Trats and Trats2 devices.
It turns out that for data downloading with thordown command L2 cache disablement brings a significant speed improvement.
rootfs - 400 MiB:
- L2 cache enabled: 2.69 MiB/s
- L2 cache disabled: 5.56 MiB/s
Such improvement is possible due to reduction of the need to invalidate redundant data, which resides in L2 cache.
Since the sent USB request size at once is 512B (L1 - 32 KiB in total) - one can be quite confident that it is already available in L1 and L2 can be disabled.
Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b Signed-off-by: Lukasz Majewski l.majewski@samsung.com
include/configs/trats.h | 1 + include/configs/trats2.h | 1 + 2 files changed, 2 insertions(+)
Acked-by: Minkyu Kang mk7.kang@samsung.com
Thanks, Minkyu Kang.
On Tue, Jan 14, 2014 at 08:02:26AM +0100, Łukasz Majewski wrote:
Disable L2 caches for Trats and Trats2 devices.
It turns out that for data downloading with thordown command L2 cache disablement brings a significant speed improvement.
rootfs - 400 MiB:
- L2 cache enabled: 2.69 MiB/s
- L2 cache disabled: 5.56 MiB/s
Such improvement is possible due to reduction of the need to invalidate redundant data, which resides in L2 cache.
Since the sent USB request size at once is 512B (L1 - 32 KiB in total) - one can be quite confident that it is already available in L1 and L2 can be disabled.
Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b Signed-off-by: Lukasz Majewski l.majewski@samsung.com Acked-by: Minkyu Kang mk7.kang@samsung.com
Applied to u-boot/master, thanks!
Hi Tom,
Adjust default envs for Trats and Trats2 boards. Those changes are supposed to cleanup and improve things for v2014.01 u-boot release.
Lukasz Majewski (3): config: Update envs for trats and trats2 - new entries for new partitions ARM: trats2: dfu: Enable default Poll Timeout for Trats2 board config: Update envs for trats and trats2 - Disable L2 cache
include/configs/trats.h | 6 +++++- include/configs/trats2.h | 7 ++++++- 2 files changed, 11 insertions(+), 2 deletions(-)
Could you apply those patches to v2014.01?
Minkyu has already ACKed them.
participants (6)
-
Gerhard Sittig -
Lukasz Majewski -
Lukasz Majewski -
Minkyu Kang -
Tom Rini -
Wolfgang Denk