[U-Boot] Pull request: u-boot-net.git master

Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
---------------------------------------------------------------- Chris Brandt (3): net: sh-eth: fix inl and outl definitions net: sh-eth: remove sh_eth_offset_rz table net: miiphybb: fix casting error
Florian Fainelli (4): net: phy: Add Broadcom BCM53xx switch driver net: designware: Pad small packets net: phy: b53: Add b53_reg read/write commands configs: Update Lamobo_R1 with B53 switch options
Jason Brown (1): net: mvneta - Fixed recv() when multiple packets have arrived.
Joe Hershberger (4): net: Fix buffer overrun error in netconsole net: Remove nfs.h include from bootp.c net: Correct size of NFS buffers net: dhcp: Allow "MAY_FAIL" to still try each adapter
Lukasz Majewski (1): net: phy: marvell: Add functions to read PHY's extended registers
Nobuhiro Iwamatsu (5): net: sh-eth: Fix coding style checked by checkpatch.pl net: sh-eth: Remove bd_t from sh_eth_config() net: sh-eth: Change read/write() param to struct sh_eth_info net: sh-eth: Fix misaligned cache operation warning net: sh-eth: Add to Kconfig and convert
Patrice Chotard (2): dm: core: add missing dev_count_phandle_with_args() net: designware: add clock support
Wilson Lee (1): net: macb: Add support for Xilinx Zynq SoC
Zhao Qiang (1): phy: atheros: set auto-negotiation for AR8021
configs/Lamobo_R1_defconfig | 3 + configs/alt_defconfig | 3 +- configs/ap_sh4a_4a_defconfig | 3 +- configs/armadillo-800eva_defconfig | 3 +- configs/ecovec_defconfig | 3 +- configs/espt_defconfig | 3 +- configs/gose_defconfig | 3 +- configs/koelsch_defconfig | 3 +- configs/lager_defconfig | 3 +- configs/porter_defconfig | 3 +- configs/r0p7734_defconfig | 3 +- configs/sh7752evb_defconfig | 3 +- configs/sh7753evb_defconfig | 3 +- configs/sh7757lcr_defconfig | 3 +- configs/sh7763rdp_defconfig | 3 +- configs/silk_defconfig | 3 +- configs/stout_defconfig | 3 +- drivers/core/read.c | 7 + drivers/net/Kconfig | 13 + drivers/net/designware.c | 48 +++ drivers/net/designware.h | 4 + drivers/net/macb.c | 91 ++++- drivers/net/macb.h | 1 + drivers/net/mvneta.c | 6 +- drivers/net/netconsole.c | 7 +- drivers/net/phy/Kconfig | 17 + drivers/net/phy/Makefile | 1 + drivers/net/phy/atheros.c | 1 + drivers/net/phy/b53.c | 768 +++++++++++++++++++++++++++++++++++++ drivers/net/phy/marvell.c | 29 ++ drivers/net/phy/miiphybb.c | 2 +- drivers/net/phy/phy.c | 3 + drivers/net/sh_eth.c | 155 ++++---- drivers/net/sh_eth.h | 76 +--- include/configs/alt.h | 1 - include/configs/ap_sh4a_4a.h | 1 - include/configs/armadillo-800eva.h | 1 - include/configs/ecovec.h | 1 - include/configs/espt.h | 1 - include/configs/gose.h | 1 - include/configs/koelsch.h | 1 - include/configs/lager.h | 1 - include/configs/porter.h | 1 - include/configs/r0p7734.h | 1 - include/configs/sh7752evb.h | 1 - include/configs/sh7753evb.h | 1 - include/configs/sh7757lcr.h | 1 - include/configs/sh7763rdp.h | 1 - include/configs/silk.h | 1 - include/configs/stout.h | 1 - include/phy.h | 1 + net/bootp.c | 18 +- net/nfs.h | 4 +- scripts/config_whitelist.txt | 1 - 54 files changed, 1133 insertions(+), 187 deletions(-) create mode 100644 drivers/net/phy/b53.c
Thanks! -Joe

On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
Chris Brandt (3): net: sh-eth: fix inl and outl definitions net: sh-eth: remove sh_eth_offset_rz table net: miiphybb: fix casting error
Florian Fainelli (4): net: phy: Add Broadcom BCM53xx switch driver net: designware: Pad small packets net: phy: b53: Add b53_reg read/write commands configs: Update Lamobo_R1 with B53 switch options
Jason Brown (1): net: mvneta - Fixed recv() when multiple packets have arrived.
Joe Hershberger (4): net: Fix buffer overrun error in netconsole net: Remove nfs.h include from bootp.c net: Correct size of NFS buffers net: dhcp: Allow "MAY_FAIL" to still try each adapter
Lukasz Majewski (1): net: phy: marvell: Add functions to read PHY's extended registers
Nobuhiro Iwamatsu (5): net: sh-eth: Fix coding style checked by checkpatch.pl net: sh-eth: Remove bd_t from sh_eth_config() net: sh-eth: Change read/write() param to struct sh_eth_info net: sh-eth: Fix misaligned cache operation warning net: sh-eth: Add to Kconfig and convert
Patrice Chotard (2): dm: core: add missing dev_count_phandle_with_args() net: designware: add clock support
Wilson Lee (1): net: macb: Add support for Xilinx Zynq SoC
Zhao Qiang (1): phy: atheros: set auto-negotiation for AR8021
As-is, this is too close to the release for all of this. Should I wait until after release, or do you want to re-work this for just critical fixes? Thanks!

Hi Tom,
On Wed, Jan 3, 2018 at 7:09 PM, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
Chris Brandt (3): net: sh-eth: fix inl and outl definitions net: sh-eth: remove sh_eth_offset_rz table net: miiphybb: fix casting error
Florian Fainelli (4): net: phy: Add Broadcom BCM53xx switch driver net: designware: Pad small packets net: phy: b53: Add b53_reg read/write commands configs: Update Lamobo_R1 with B53 switch options
Jason Brown (1): net: mvneta - Fixed recv() when multiple packets have arrived.
Joe Hershberger (4): net: Fix buffer overrun error in netconsole net: Remove nfs.h include from bootp.c net: Correct size of NFS buffers net: dhcp: Allow "MAY_FAIL" to still try each adapter
Lukasz Majewski (1): net: phy: marvell: Add functions to read PHY's extended registers
Nobuhiro Iwamatsu (5): net: sh-eth: Fix coding style checked by checkpatch.pl net: sh-eth: Remove bd_t from sh_eth_config() net: sh-eth: Change read/write() param to struct sh_eth_info net: sh-eth: Fix misaligned cache operation warning net: sh-eth: Add to Kconfig and convert
Patrice Chotard (2): dm: core: add missing dev_count_phandle_with_args() net: designware: add clock support
Wilson Lee (1): net: macb: Add support for Xilinx Zynq SoC
Zhao Qiang (1): phy: atheros: set auto-negotiation for AR8021
As-is, this is too close to the release for all of this. Should I wait until after release, or do you want to re-work this for just critical fixes? Thanks!
Sure, waiting until after release is fine. There aren't any "critical" fixes in this.
Thanks, -Joe

On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
NAK. The following change (via git bisect'ing): commit 003eaf15a043cf6f9c21d757a93610575d9b7ba2 Author: Joe Hershberger joe.hershberger@ni.com Date: Wed Aug 30 17:42:26 2017 -0500
net: Correct size of NFS buffers
Reported-by: Coverity (CID: 152888) Signed-off-by: Joe Hershberger joe.hershberger@ni.com is breaking NFS for me on my am335x_evm: 12:58:46 ----------------------------- Captured stdout call ----------------------------- 12:58:46 => nfs 80400000 /tftpboot/1MiBtest.bin 12:58:46 link up on port 0, speed 1000, full duplex 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ########## 12:58:46 done 12:58:46 Bytes transferred = 1048576 (100000 hex) 12:58:46 => => crc32 80400000 $filesize 12:58:46 crc32 for 80400000 ... 804fffff ==> 1edf15ed 12:58:46 => 12:58:46 =============== 1 failed, 78 passed, 25 skipped in 32.80 seconds ===============
I can't point to any SW-only tests that show this as they're passing. Any ideas? Thanks!

Hi Tom,
On Tue, Jan 9, 2018 at 12:06 PM, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
NAK. The following change (via git bisect'ing): commit 003eaf15a043cf6f9c21d757a93610575d9b7ba2 Author: Joe Hershberger joe.hershberger@ni.com Date: Wed Aug 30 17:42:26 2017 -0500
net: Correct size of NFS buffers Reported-by: Coverity (CID: 152888) Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
is breaking NFS for me on my am335x_evm: 12:58:46 ----------------------------- Captured stdout call ----------------------------- 12:58:46 => nfs 80400000 /tftpboot/1MiBtest.bin 12:58:46 link up on port 0, speed 1000, full duplex 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ########## 12:58:46 done 12:58:46 Bytes transferred = 1048576 (100000 hex) 12:58:46 => => crc32 80400000 $filesize 12:58:46 crc32 for 80400000 ... 804fffff ==> 1edf15ed 12:58:46 => 12:58:46 =============== 1 failed, 78 passed, 25 skipped in 32.80 seconds ===============
I can't point to any SW-only tests that show this as they're passing. Any ideas? Thanks!
I can't see any obvious reason for the error, so it will need debugging. I've sent a new PR with this dropped for now. I'll look into fixing it for real when I can get to it.
Are these tests you're running possible to include in travis?
Thanks, -Joe

On Mon, Jan 15, 2018 at 12:10:17PM -0600, Joe Hershberger wrote:
Hi Tom,
On Tue, Jan 9, 2018 at 12:06 PM, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
NAK. The following change (via git bisect'ing): commit 003eaf15a043cf6f9c21d757a93610575d9b7ba2 Author: Joe Hershberger joe.hershberger@ni.com Date: Wed Aug 30 17:42:26 2017 -0500
net: Correct size of NFS buffers Reported-by: Coverity (CID: 152888) Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
is breaking NFS for me on my am335x_evm: 12:58:46 ----------------------------- Captured stdout call ----------------------------- 12:58:46 => nfs 80400000 /tftpboot/1MiBtest.bin 12:58:46 link up on port 0, speed 1000, full duplex 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ########## 12:58:46 done 12:58:46 Bytes transferred = 1048576 (100000 hex) 12:58:46 => => crc32 80400000 $filesize 12:58:46 crc32 for 80400000 ... 804fffff ==> 1edf15ed 12:58:46 => 12:58:46 =============== 1 failed, 78 passed, 25 skipped in 32.80 seconds ===============
I can't point to any SW-only tests that show this as they're passing. Any ideas? Thanks!
I can't see any obvious reason for the error, so it will need debugging. I've sent a new PR with this dropped for now. I'll look into fixing it for real when I can get to it.
Are these tests you're running possible to include in travis?
So, that's part of the problem. These are the standard tests we do run in Travis, in QEMU, and they pass. It's only on real hardware where it fails.

On Mon, Jan 15, 2018 at 12:13 PM, Tom Rini trini@konsulko.com wrote:
On Mon, Jan 15, 2018 at 12:10:17PM -0600, Joe Hershberger wrote:
Hi Tom,
On Tue, Jan 9, 2018 at 12:06 PM, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
NAK. The following change (via git bisect'ing): commit 003eaf15a043cf6f9c21d757a93610575d9b7ba2 Author: Joe Hershberger joe.hershberger@ni.com Date: Wed Aug 30 17:42:26 2017 -0500
net: Correct size of NFS buffers Reported-by: Coverity (CID: 152888) Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
is breaking NFS for me on my am335x_evm: 12:58:46 ----------------------------- Captured stdout call ----------------------------- 12:58:46 => nfs 80400000 /tftpboot/1MiBtest.bin 12:58:46 link up on port 0, speed 1000, full duplex 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ########## 12:58:46 done 12:58:46 Bytes transferred = 1048576 (100000 hex) 12:58:46 => => crc32 80400000 $filesize 12:58:46 crc32 for 80400000 ... 804fffff ==> 1edf15ed 12:58:46 => 12:58:46 =============== 1 failed, 78 passed, 25 skipped in 32.80 seconds ===============
I can't point to any SW-only tests that show this as they're passing. Any ideas? Thanks!
I can't see any obvious reason for the error, so it will need debugging. I've sent a new PR with this dropped for now. I'll look into fixing it for real when I can get to it.
Are these tests you're running possible to include in travis?
So, that's part of the problem. These are the standard tests we do run in Travis, in QEMU, and they pass. It's only on real hardware where it fails.
OK, good to know. Any particular arch? or just all that you have tried?

On Mon, Jan 15, 2018 at 12:15:24PM -0600, Joe Hershberger wrote:
On Mon, Jan 15, 2018 at 12:13 PM, Tom Rini trini@konsulko.com wrote:
On Mon, Jan 15, 2018 at 12:10:17PM -0600, Joe Hershberger wrote:
Hi Tom,
On Tue, Jan 9, 2018 at 12:06 PM, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
NAK. The following change (via git bisect'ing): commit 003eaf15a043cf6f9c21d757a93610575d9b7ba2 Author: Joe Hershberger joe.hershberger@ni.com Date: Wed Aug 30 17:42:26 2017 -0500
net: Correct size of NFS buffers Reported-by: Coverity (CID: 152888) Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
is breaking NFS for me on my am335x_evm: 12:58:46 ----------------------------- Captured stdout call ----------------------------- 12:58:46 => nfs 80400000 /tftpboot/1MiBtest.bin 12:58:46 link up on port 0, speed 1000, full duplex 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ########## 12:58:46 done 12:58:46 Bytes transferred = 1048576 (100000 hex) 12:58:46 => => crc32 80400000 $filesize 12:58:46 crc32 for 80400000 ... 804fffff ==> 1edf15ed 12:58:46 => 12:58:46 =============== 1 failed, 78 passed, 25 skipped in 32.80 seconds ===============
I can't point to any SW-only tests that show this as they're passing. Any ideas? Thanks!
I can't see any obvious reason for the error, so it will need debugging. I've sent a new PR with this dropped for now. I'll look into fixing it for real when I can get to it.
Are these tests you're running possible to include in travis?
So, that's part of the problem. These are the standard tests we do run in Travis, in QEMU, and they pass. It's only on real hardware where it fails.
OK, good to know. Any particular arch? or just all that you have tried?
It honestly failed on the first real board I tried it on, so I didn't try others. I suppose since I have a faster local box than I used to, I might look at turning my real HW tests in jenkins into a matrix rather than a single job. It failed on am335x_evm which is ARM.

On Mon, Jan 15, 2018 at 12:22 PM, Tom Rini trini@konsulko.com wrote:
On Mon, Jan 15, 2018 at 12:15:24PM -0600, Joe Hershberger wrote:
On Mon, Jan 15, 2018 at 12:13 PM, Tom Rini trini@konsulko.com wrote:
On Mon, Jan 15, 2018 at 12:10:17PM -0600, Joe Hershberger wrote:
Hi Tom,
On Tue, Jan 9, 2018 at 12:06 PM, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
Hi Tom,
The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
NAK. The following change (via git bisect'ing): commit 003eaf15a043cf6f9c21d757a93610575d9b7ba2 Author: Joe Hershberger joe.hershberger@ni.com Date: Wed Aug 30 17:42:26 2017 -0500
net: Correct size of NFS buffers Reported-by: Coverity (CID: 152888) Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
is breaking NFS for me on my am335x_evm: 12:58:46 ----------------------------- Captured stdout call ----------------------------- 12:58:46 => nfs 80400000 /tftpboot/1MiBtest.bin 12:58:46 link up on port 0, speed 1000, full duplex 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ################################################################# 12:58:46 ########## 12:58:46 done 12:58:46 Bytes transferred = 1048576 (100000 hex) 12:58:46 => => crc32 80400000 $filesize 12:58:46 crc32 for 80400000 ... 804fffff ==> 1edf15ed 12:58:46 => 12:58:46 =============== 1 failed, 78 passed, 25 skipped in 32.80 seconds ===============
I can't point to any SW-only tests that show this as they're passing. Any ideas? Thanks!
I can't see any obvious reason for the error, so it will need debugging. I've sent a new PR with this dropped for now. I'll look into fixing it for real when I can get to it.
Are these tests you're running possible to include in travis?
So, that's part of the problem. These are the standard tests we do run in Travis, in QEMU, and they pass. It's only on real hardware where it fails.
OK, good to know. Any particular arch? or just all that you have tried?
It honestly failed on the first real board I tried it on, so I didn't try others. I suppose since I have a faster local box than I used to, I might look at turning my real HW tests in jenkins into a matrix rather than a single job. It failed on am335x_evm which is ARM.
Thanks.
participants (3)
-
Joe Hershberger
-
Joe Hershberger
-
Tom Rini