Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV
On 2/10/22 14:38, Siarhei Siamashka wrote:
On Thu, Feb 10, 2022 at 6:35 AM Jesse Taube mr.bossman075@gmail.com wrote: [...]
case SUNIV_BOOTED_FROM_NAND:case SUNIV_BOOTED_FROM_SPI:return BOOT_DEVICE_SPI;Is it really okay to lump SPI and NAND together and return BOOT_DEVICE_SPI for both?
Booting from SPI NAND. I can change it to BOOT_DEVICE_NAND.
What's the NAND support story on this device?
I thought BOOT_DEVICE_NAND was for parallel NAND but I may be wrong could come one clarify please?
Thanks, Jesse Taube
On Thu, 10 Feb 2022 14:51:11 -0500 Jesse Taube mr.bossman075@gmail.com wrote:
On 2/10/22 14:38, Siarhei Siamashka wrote:
On Thu, Feb 10, 2022 at 6:35 AM Jesse Taube mr.bossman075@gmail.com wrote: [...]
case SUNIV_BOOTED_FROM_NAND:case SUNIV_BOOTED_FROM_SPI:return BOOT_DEVICE_SPI;Is it really okay to lump SPI and NAND together and return BOOT_DEVICE_SPI for both?
Booting from SPI NAND. I can change it to BOOT_DEVICE_NAND.
Ah, sorry, I missed that. So SPI NAND is different from both SPI NOR and parallel NAND, and we just don't support it (yet). So just bail out in this case, ideally with a message.
Cheers, Andre
What's the NAND support story on this device?
I thought BOOT_DEVICE_NAND was for parallel NAND but I may be wrong could come one clarify please?
Thanks, Jesse Taube
participants (2)
-
Andre Przywara -
Jesse Taube