[U-Boot] most efficient way to submit patches that are typo/grammar fixes?
given my pedantic nature, i've run across the occasional spelling mistake or grammar glitch and want to know the best way to submit a patch (or patches) for that. naturally, this stuff is scattered across the u-boot tree, so is it better to try to submit a separate patch per subsystem, or just one big one?
most of this stuff is in comments so it doesn't represent any functional change and therefore shouldn't hurt anything ... stuff like spellings of "environent" or "volitle", stuff like that.
best way to do this? thanks.
rday
Dear "Robert P. J. Day",
In message alpine.DEB.2.02.1309140615150.14699@oneiric you wrote:
given my pedantic nature, i've run across the occasional spelling mistake or grammar glitch and want to know the best way to submit a patch (or patches) for that. naturally, this stuff is scattered across the u-boot tree, so is it better to try to submit a separate patch per subsystem, or just one big one?
most of this stuff is in comments so it doesn't represent any functional change and therefore shouldn't hurt anything ... stuff like spellings of "environent" or "volitle", stuff like that.
best way to do this? thanks.
It's usually a good idea not to combine too many unrelated changes into a huge single patch. But then, there is also no need to split spelling fixes across sub-systems. I recommend to use common sense.
It's probably a good idea to add a flag like "[COSMETIC]" to the patch subject, so we know immediately that this does not contain any functional changes.
Best regards,
Wolfgang Denk
Hi Wolfgang,
On Sun, 15 Sep 2013 01:28:12 +0200, Wolfgang Denk wd@denx.de wrote:
Dear "Robert P. J. Day",
In message alpine.DEB.2.02.1309140615150.14699@oneiric you wrote:
given my pedantic nature, i've run across the occasional spelling mistake or grammar glitch and want to know the best way to submit a patch (or patches) for that. naturally, this stuff is scattered across the u-boot tree, so is it better to try to submit a separate patch per subsystem, or just one big one?
most of this stuff is in comments so it doesn't represent any functional change and therefore shouldn't hurt anything ... stuff like spellings of "environent" or "volitle", stuff like that.
best way to do this? thanks.
It's usually a good idea not to combine too many unrelated changes into a huge single patch. But then, there is also no need to split spelling fixes across sub-systems. I recommend to use common sense.
It's probably a good idea to add a flag like "[COSMETIC]" to the patch subject, so we know immediately that this does not contain any functional changes.
Maybe rather a "cosmetic:" tag so that the patch is also seen as such inside Git, where the "[...]" flag won't show up.
Best regards,
Wolfgang Denk
Amicalement,
On Sun, 15 Sep 2013, Albert ARIBAUD wrote:
Hi Wolfgang,
On Sun, 15 Sep 2013 01:28:12 +0200, Wolfgang Denk wd@denx.de wrote:
Dear "Robert P. J. Day",
In message alpine.DEB.2.02.1309140615150.14699@oneiric you wrote:
given my pedantic nature, i've run across the occasional spelling mistake or grammar glitch and want to know the best way to submit a patch (or patches) for that. naturally, this stuff is scattered across the u-boot tree, so is it better to try to submit a separate patch per subsystem, or just one big one?
most of this stuff is in comments so it doesn't represent any functional change and therefore shouldn't hurt anything ... stuff like spellings of "environent" or "volitle", stuff like that.
best way to do this? thanks.
It's usually a good idea not to combine too many unrelated changes into a huge single patch. But then, there is also no need to split spelling fixes across sub-systems. I recommend to use common sense.
It's probably a good idea to add a flag like "[COSMETIC]" to the patch subject, so we know immediately that this does not contain any functional changes.
Maybe rather a "cosmetic:" tag so that the patch is also seen as such inside Git, where the "[...]" flag won't show up.
ok, i can go with that, thanks.
rday
participants (3)
-
Albert ARIBAUD -
Robert P. J. Day -
Wolfgang Denk