[U-Boot] [PATCH 1/1] common: print \n in initr_scsi()
Typically init_scsi() does not output anything. So initr_scsi() should provide a \n or we may see borked output like
SCSI: Net: No ethernet found.
as observed with sandbox_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- common/board_r.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/board_r.c b/common/board_r.c index 6b297068bd..23b5d2c21b 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -553,6 +553,7 @@ static int initr_scsi(void) { puts("SCSI: "); scsi_init(); + puts("\n");
return 0; }
Hi Heinrich,
On 14 June 2018 at 23:01, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Typically init_scsi() does not output anything. So initr_scsi() should provide a \n or we may see borked output like
SCSI: Net: No ethernet found.as observed with sandbox_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
common/board_r.c | 1 + 1 file changed, 1 insertion(+)
Instead of this, we should enable DM_SCSI on sandbox.
Regards, Simon
On 06/20/2018 12:03 AM, Simon Glass wrote:
Hi Heinrich,
On 14 June 2018 at 23:01, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Typically init_scsi() does not output anything. So initr_scsi() should provide a \n or we may see borked output like
SCSI: Net: No ethernet found.as observed with sandbox_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
common/board_r.c | 1 + 1 file changed, 1 insertion(+)
Instead of this, we should enable DM_SCSI on sandbox.
Regards, Simon
The function initr_scsi() is built for #if defined(CONFIG_SCSI) && !defined(CONFIG_DM_SCSI)
Once all boards that support CONFIG_SCSI can be configured with CONFIG_DM_SCSI we should remove the symbol CONFIG_SCSI and function initr_scsi(). But we have not even enabled BLK for all supported boards. BLK is required for DM_SCSI.
Till then problem I observed will be reproducible on other architectures than sandbox if no SCSI disk is attached.
Best regards
Heinrich
On Fri, Jun 15, 2018 at 07:01:26AM +0200, Heinrich Schuchardt wrote:
Typically init_scsi() does not output anything. So initr_scsi() should provide a \n or we may see borked output like
SCSI: Net: No ethernet found.
as observed with sandbox_defconfig.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Applied to u-boot/master, thanks!
participants (3)
-
Heinrich Schuchardt -
Simon Glass -
Tom Rini