[PATCH v2] board: ea: mx7ulp_com: move setting CONFIG_BOOTCOMMAND to defconfig

From: Ricardo Salveti ricardo@foundries.io
Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file. It also allows replacing the default CONFIG_BOOTCOMMAND without code modification.
Signed-off-by: Ricardo Salveti ricardo@foundries.io Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io ---
Changes in v2: - move setting the command to defconfig
configs/mx7ulp_com_defconfig | 2 ++ include/configs/mx7ulp_com.h | 5 ----- 2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/configs/mx7ulp_com_defconfig b/configs/mx7ulp_com_defconfig index 62992fecdf..5fcf25a7fb 100644 --- a/configs/mx7ulp_com_defconfig +++ b/configs/mx7ulp_com_defconfig @@ -9,6 +9,8 @@ CONFIG_DEFAULT_DEVICE_TREE="imx7ulp-com" CONFIG_LDO_ENABLED_MODE=y CONFIG_TARGET_MX7ULP_COM=y CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/ea/mx7ulp_com/imximage.cfg" +CONFIG_USE_BOOTCOMMAND=y +CONFIG_BOOTCOMMAND="if run loadimage; then run mmcboot; fi" CONFIG_DEFAULT_FDT_FILE="imx7ulp-com" CONFIG_BOARD_EARLY_INIT_F=y CONFIG_HUSH_PARSER=y diff --git a/include/configs/mx7ulp_com.h b/include/configs/mx7ulp_com.h index 28672c4f94..3ef41e565a 100644 --- a/include/configs/mx7ulp_com.h +++ b/include/configs/mx7ulp_com.h @@ -69,11 +69,6 @@ "bootz ${loadaddr} - ${fdt_addr}; " \ "fi;\0" \
-#define CONFIG_BOOTCOMMAND \ - "if run loadimage; then " \ - "run mmcboot; " \ - "fi; " \ - #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
#define CONFIG_SYS_INIT_RAM_ADDR IRAM_BASE_ADDR

Hi Oleksandr,
On Thu, Aug 26, 2021 at 8:04 AM Oleksandr Suvorov oleksandr.suvorov@foundries.io wrote:
From: Ricardo Salveti ricardo@foundries.io
Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file. It also allows replacing the default CONFIG_BOOTCOMMAND without code modification.
Signed-off-by: Ricardo Salveti ricardo@foundries.io Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io
Changes in v2:
- move setting the command to defconfig
Reviewed-by: Fabio Estevam festevam@gmail.com

On Thu, Aug 26, 2021 at 02:04:24PM +0300, Oleksandr Suvorov wrote:
From: Ricardo Salveti ricardo@foundries.io
Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file. It also allows replacing the default CONFIG_BOOTCOMMAND without code modification.
Signed-off-by: Ricardo Salveti ricardo@foundries.io Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io
Reviewed-by: Tom Rini trini@konsulko.com

From: Ricardo Salveti ricardo@foundries.io Move setting CONFIG_BOOTCOMMAND to the mx7ulp_com_defconfig file. It also allows replacing the default CONFIG_BOOTCOMMAND without code modification. Signed-off-by: Ricardo Salveti ricardo@foundries.io Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@foundries.io Reviewed-by: Fabio Estevam festevam@gmail.com Reviewed-by: Tom Rini trini@konsulko.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
participants (4)
-
Fabio Estevam
-
Oleksandr Suvorov
-
sbabic@denx.de
-
Tom Rini