[PATCH] lib: rsa: cosmetic: fix building warning

add initialization of variable 'node',this can aviod the building warning:
'node' may be used uninitialized [-Wmaybe-uninitialized]
Signed-off-by: Haijun Qin qinhaijun@eswincomputing.com --- lib/rsa/rsa-sign.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c index b2a21199e4..d20bdb58a5 100644 --- a/lib/rsa/rsa-sign.c +++ b/lib/rsa/rsa-sign.c @@ -608,7 +608,7 @@ int rsa_add_verify_data(struct image_sign_info *info, void *keydest) BIGNUM *modulus, *r_squared; uint64_t exponent; uint32_t n0_inv; - int parent, node; + int parent, node = -FDT_ERR_NOTFOUND; char name[100]; int ret; int bits;
base-commit: d2c5607edde2544e059fa871927877213f6bd532

On Wed, 7 Dec 2022 at 03:50, Haijun Qin qinhaijun@eswincomputing.com wrote:
add initialization of variable 'node',this can aviod the building warning:
'node' may be used uninitialized [-Wmaybe-uninitialized]
Signed-off-by: Haijun Qin qinhaijun@eswincomputing.com
lib/rsa/rsa-sign.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
What toolchain is this?
diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c index b2a21199e4..d20bdb58a5 100644 --- a/lib/rsa/rsa-sign.c +++ b/lib/rsa/rsa-sign.c @@ -608,7 +608,7 @@ int rsa_add_verify_data(struct image_sign_info *info, void *keydest) BIGNUM *modulus, *r_squared; uint64_t exponent; uint32_t n0_inv;
int parent, node;
int parent, node = -FDT_ERR_NOTFOUND; char name[100]; int ret; int bits;
base-commit: d2c5607edde2544e059fa871927877213f6bd532
2.17.1

Hi,Simon
The toolchain source code we use comes from here(https://github.com/riscv-collab/riscv-gnu-toolchain), but we have made some changes.
On Wed, 7 Dec 2022 at 03:50, Haijun Qin qinhaijun@eswincomputing.com wrote:
add initialization of variable 'node',this can aviod the building warning:
'node' may be used uninitialized [-Wmaybe-uninitialized]
Signed-off-by: Haijun Qin qinhaijun@eswincomputing.com
lib/rsa/rsa-sign.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
What toolchain is this?
diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c index b2a21199e4..d20bdb58a5 100644 --- a/lib/rsa/rsa-sign.c +++ b/lib/rsa/rsa-sign.c @@ -608,7 +608,7 @@ int rsa_add_verify_data(struct image_sign_info *info, void *keydest) BIGNUM *modulus, *r_squared; uint64_t exponent; uint32_t n0_inv;
int parent, node;
int parent, node = -FDT_ERR_NOTFOUND; char name[100]; int ret; int bits;
base-commit: d2c5607edde2544e059fa871927877213f6bd532
2.17.1

On Tue, Dec 06, 2022 at 03:41:37PM +0800, Haijun Qin wrote:
add initialization of variable 'node',this can aviod the building warning:
'node' may be used uninitialized [-Wmaybe-uninitialized]
Signed-off-by: Haijun Qin qinhaijun@eswincomputing.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (3)
-
Haijun Qin
-
Simon Glass
-
Tom Rini