[U-Boot] console_buffer
yet another potential cleanup:
I see both: extern char console_buffer[]; and extern char console_buffer[CONFIG_SYS_CBSIZE];
(and in fact console_buffer is declared as: char console_buffer[CONFIG_SYS_CBSIZE + 1]; /* console I/O buffer */ so with a +1).
Questions: is the first or the 2nd form preferred? and if it is the 2nd form should it not have the +1? and wouldn't it be better to have this extern in a .h file (and if so which one)?
Frans
Hi Frans,
On 3/24/2010 12:52 PM, Frans Meulenbroeks wrote:
yet another potential cleanup:
I see both: extern char console_buffer[]; and extern char console_buffer[CONFIG_SYS_CBSIZE];
(and in fact console_buffer is declared as: char console_buffer[CONFIG_SYS_CBSIZE + 1]; /* console I/O buffer */ so with a +1).
Questions: is the first or the 2nd form preferred? and if it is the 2nd form should it not have the +1? and wouldn't it be better to have this extern in a .h file (and if so which one)?
Your interest is definitely appreciated. As a general remark, you're more likely to get meaningful feedback if you just submit what you think is best. You'll get more feedback when people don't like what you did, but any EE will tell you that negative feedback is the path to stability :)
Frans
regards, Ben
Dear Ben,
In message 4BAA6F5C.5060002@gmail.com you wrote:
... You'll get more feedback when people don't like what you did,but any EE will tell you that negative feedback is the path to stability :)
May I add this to my list of signature quotes?
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de In a survey taken several years ago, all incoming freshmen at MIT were asked if they expected to graduate in the top half of their class. Ninety-seven percent responded that they did.
On 3/24/2010 2:08 PM, Wolfgang Denk wrote:
Dear Ben,
In message4BAA6F5C.5060002@gmail.com you wrote:
... You'll get more feedback when people don't like what you did,but any EE will tell you that negative feedback is the path to stability :)
May I add this to my list of signature quotes?
Sure, under GPL v3 ;)
Best regards,
Wolfgang Denk
regards, Ben
participants (3)
-
Ben Warren -
Frans Meulenbroeks -
Wolfgang Denk