[U-Boot] Build issues with a number of 83xx boards
Dear Kim & Kumar,
are you aware that a number of 83xx boards don't build any more? I see errors like these:
Configuring for MPC8313ERDB_NAND_33 - Board: MPC8313ERDB, Options: SYS_33MHZ,NAND_U_BOOT ppc_6xx-ld: cannot open linker script file u-boot.lds: No such file or directory make[1]: *** [/work/wd/tmp-ppc/nand_spl/u-boot-spl] Error 1
Best regards,
Wolfgang Denk
Hi all,
In message 20110331091915.D9B19EDFFD7@gemini.denx.de I wrote:
are you aware that a number of 83xx boards don't build any more? I see errors like these:
Configuring for MPC8313ERDB_NAND_33 - Board: MPC8313ERDB, Options: SYS_33MHZ,NAND_U_BOOT ppc_6xx-ld: cannot open linker script file u-boot.lds: No such file or directory make[1]: *** [/work/wd/tmp-ppc/nand_spl/u-boot-spl] Error 1
The culprit is this commit:
6dc1eceb9c5f42216f1ba0e0ef538015b0aa10bc is the first bad commit commit 6dc1eceb9c5f42216f1ba0e0ef538015b0aa10bc Author: Haiying Wang Haiying.Wang@freescale.com Date: Tue Feb 22 16:38:05 2011 -0500
Introduce a new linker flag LDFLAGS_FINAL
It appears this has never been tested with out-of-tree builds!
Best regards,
Wolfgang Denk
Commit 6dc1ece "Introduce a new linker flag LDFLAGS_FINAL" modified a number of Makefiles in a way that broke out-of-tree builds. The problem was that $(nandobj) was used before it got defined.
Fix this.
Signed-off-by: Wolfgang Denk wd@denx.de --- nand_spl/board/amcc/acadia/Makefile | 6 +++--- nand_spl/board/amcc/bamboo/Makefile | 6 +++--- nand_spl/board/amcc/canyonlands/Makefile | 6 +++--- nand_spl/board/amcc/kilauea/Makefile | 6 +++--- nand_spl/board/amcc/sequoia/Makefile | 6 +++--- nand_spl/board/freescale/mpc8313erdb/Makefile | 6 +++--- nand_spl/board/freescale/mpc8315erdb/Makefile | 6 +++--- nand_spl/board/freescale/mpc8536ds/Makefile | 6 +++--- nand_spl/board/freescale/mpc8569mds/Makefile | 6 +++--- nand_spl/board/freescale/mpc8572ds/Makefile | 6 +++--- nand_spl/board/sheldon/simpc8313/Makefile | 6 +++--- 11 files changed, 33 insertions(+), 33 deletions(-)
diff --git a/nand_spl/board/amcc/acadia/Makefile b/nand_spl/board/amcc/acadia/Makefile index f4323d5..84cb8ab 100644 --- a/nand_spl/board/amcc/acadia/Makefile +++ b/nand_spl/board/amcc/acadia/Makefile @@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -36,9 +38,7 @@ COBJS = gpio.o nand_boot.o nand_ecc.o memory.o ndfc.o pll.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin \ $(nandobj)System.map diff --git a/nand_spl/board/amcc/bamboo/Makefile b/nand_spl/board/amcc/bamboo/Makefile index 15af860..6430219 100644 --- a/nand_spl/board/amcc/bamboo/Makefile +++ b/nand_spl/board/amcc/bamboo/Makefile @@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -36,9 +38,7 @@ COBJS = nand_boot.o nand_ecc.o ndfc.o sdram.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/amcc/canyonlands/Makefile b/nand_spl/board/amcc/canyonlands/Makefile index 62c77d8..509a46e 100644 --- a/nand_spl/board/amcc/canyonlands/Makefile +++ b/nand_spl/board/amcc/canyonlands/Makefile @@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -41,9 +43,7 @@ COBJS += ndfc.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/amcc/kilauea/Makefile b/nand_spl/board/amcc/kilauea/Makefile index 1053ce3..104b7e2 100644 --- a/nand_spl/board/amcc/kilauea/Makefile +++ b/nand_spl/board/amcc/kilauea/Makefile @@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -36,9 +38,7 @@ COBJS = 44x_spd_ddr2.o nand_boot.o nand_ecc.o ndfc.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/amcc/sequoia/Makefile b/nand_spl/board/amcc/sequoia/Makefile index 9516b5c..54e8a12 100644 --- a/nand_spl/board/amcc/sequoia/Makefile +++ b/nand_spl/board/amcc/sequoia/Makefile @@ -24,6 +24,8 @@ include $(TOPDIR)/config.mk include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -36,9 +38,7 @@ COBJS = denali_data_eye.o nand_boot.o nand_ecc.o ndfc.o sdram.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/freescale/mpc8313erdb/Makefile b/nand_spl/board/freescale/mpc8313erdb/Makefile index 2f83e2b..cff2a43 100644 --- a/nand_spl/board/freescale/mpc8313erdb/Makefile +++ b/nand_spl/board/freescale/mpc8313erdb/Makefile @@ -27,6 +27,8 @@ PAD_TO := 0xfff04000
include $(TOPDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) \ $(LDFLAGS) $(LDFLAGS_FINAL) @@ -40,9 +42,7 @@ COBJS = nand_boot_fsl_elbc.o $(BOARD).o sdram.o ns16550.o nand_init.o \ SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/freescale/mpc8315erdb/Makefile b/nand_spl/board/freescale/mpc8315erdb/Makefile index 2f83e2b..cff2a43 100644 --- a/nand_spl/board/freescale/mpc8315erdb/Makefile +++ b/nand_spl/board/freescale/mpc8315erdb/Makefile @@ -27,6 +27,8 @@ PAD_TO := 0xfff04000
include $(TOPDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) \ $(LDFLAGS) $(LDFLAGS_FINAL) @@ -40,9 +42,7 @@ COBJS = nand_boot_fsl_elbc.o $(BOARD).o sdram.o ns16550.o nand_init.o \ SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/freescale/mpc8536ds/Makefile b/nand_spl/board/freescale/mpc8536ds/Makefile index 7ed6cea..a0e1455 100644 --- a/nand_spl/board/freescale/mpc8536ds/Makefile +++ b/nand_spl/board/freescale/mpc8536ds/Makefile @@ -29,6 +29,8 @@ PAD_TO := 0xfff01000
include $(TOPDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/$(CPUDIR)/u-boot-nand_spl.lds LDFLAGS := -T $(LDSCRIPT) -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -42,9 +44,7 @@ COBJS = cache.o cpu_init_early.o cpu_init_nand.o fsl_law.o law.o \ SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/freescale/mpc8569mds/Makefile b/nand_spl/board/freescale/mpc8569mds/Makefile index 7ed6cea..a0e1455 100644 --- a/nand_spl/board/freescale/mpc8569mds/Makefile +++ b/nand_spl/board/freescale/mpc8569mds/Makefile @@ -29,6 +29,8 @@ PAD_TO := 0xfff01000
include $(TOPDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/$(CPUDIR)/u-boot-nand_spl.lds LDFLAGS := -T $(LDSCRIPT) -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -42,9 +44,7 @@ COBJS = cache.o cpu_init_early.o cpu_init_nand.o fsl_law.o law.o \ SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/freescale/mpc8572ds/Makefile b/nand_spl/board/freescale/mpc8572ds/Makefile index 862c014..092ce14 100644 --- a/nand_spl/board/freescale/mpc8572ds/Makefile +++ b/nand_spl/board/freescale/mpc8572ds/Makefile @@ -29,6 +29,8 @@ PAD_TO := 0xfff01000
include $(TOPDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/$(CPUDIR)/u-boot-nand_spl.lds LDFLAGS := -T $(LDSCRIPT) -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) $(LDFLAGS) \ $(LDFLAGS_FINAL) @@ -42,9 +44,7 @@ COBJS = cache.o cpu_init_early.o cpu_init_nand.o fsl_law.o law.o \ SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
diff --git a/nand_spl/board/sheldon/simpc8313/Makefile b/nand_spl/board/sheldon/simpc8313/Makefile index aacbd04..2a3ddac 100644 --- a/nand_spl/board/sheldon/simpc8313/Makefile +++ b/nand_spl/board/sheldon/simpc8313/Makefile @@ -27,6 +27,8 @@ NAND_SPL := y
include $(TOPDIR)/config.mk
+nandobj := $(OBJTREE)/nand_spl/ + LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) \ $(LDFLAGS) $(LDFLAGS_FINAL) @@ -40,9 +42,7 @@ COBJS = nand_boot_fsl_elbc.o $(BOARD).o sdram.o ns16550.o nand_init.o \ SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) __OBJS := $(SOBJS) $(COBJS) -LNDIR := $(OBJTREE)/nand_spl/board/$(BOARDDIR) - -nandobj := $(OBJTREE)/nand_spl/ +LNDIR := $(nandobj)board/$(BOARDDIR)
ALL = $(nandobj)u-boot-spl $(nandobj)u-boot-spl.bin $(nandobj)u-boot-spl-16k.bin
Dear Wolfgang, On Thu, 2011-03-31 at 16:52 +0200, Wolfgang Denk wrote:
Commit 6dc1ece "Introduce a new linker flag LDFLAGS_FINAL" modified a number of Makefiles in a way that broke out-of-tree builds. The problem was that $(nandobj) was used before it got defined.
What is "out-of-tree builds"? Why did LDFLAGS_FINAL patch break it? the $(nandobj) was defined in those Makefiles in that way before applying LDFLAGS_FINAL patch. Why could the out-of-tree builds passed before applying LDFLAG_FINAL patch?
Thanks.
Haiying
Dear Haiying Wang,
In message 1301583985.1991.4.camel@haiying-laptop you wrote:
What is "out-of-tree builds"? Why did LDFLAGS_FINAL patch break it? the
out-of-tree building means that you store all build results in some other directory, outside of the source tree. See item 3 under Notes at http://www.denx.de/wiki/U-Boot/Patches
Your patch broke it because it referenced $(nandobj) before defining it - aslong as the build directory and the source directory are the same, this makes no difference. But for out-of-tree builds...
$(nandobj) was defined in those Makefiles in that way before applying LDFLAGS_FINAL patch. Why could the out-of-tree builds passed before applying LDFLAG_FINAL patch?
Have a look at the changes introduced by your commit, and you will see. The problem is a bit buried in the changes of "=" into ":=" and "$(PLATFORM_LDFLAGS)" into "$(LDFLAGS) $(LDFLAGS_FINAL)" in lines like these:
-LDFLAGS = -Bstatic -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(PLATFORM_LDFLAGS) +LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ + $(LDFLAGS_FINAL)
[It is a bit strange to append to LDFLAGS line that.]
Best regards,
Wolfgang Denk
On Thu, 2011-03-31 at 17:37 +0200, Wolfgang Denk wrote:
$(nandobj) was defined in those Makefiles in that way before applying LDFLAGS_FINAL patch. Why could the out-of-tree builds passed before applying LDFLAG_FINAL patch?
Have a look at the changes introduced by your commit, and you will see. The problem is a bit buried in the changes of "=" into ":=" and "$(PLATFORM_LDFLAGS)" into "$(LDFLAGS) $(LDFLAGS_FINAL)" in lines like these:
-LDFLAGS = -Bstatic -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(PLATFORM_LDFLAGS) +LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \
$(LDFLAGS_FINAL)
Oh,yes, I got it now. ":=" will expand the variables immediately and "=" will delay the expansion until the new variable is referenced, which can explain the $(nandobj)worked before this patch.
[It is a bit strange to append to LDFLAGS line that.]
The reason I used ":=" was because I added "LDFLAGS_FINAL += -Bstatic $(LDFLAGS)" in my first version of this patch, but it seems that it is not necessary to do so after I remove $(LDFLAGS) for LDFLAGS_FINAL.
Thanks for pointing it out.
Haiying
On Thu, 31 Mar 2011 16:52:31 +0200 Wolfgang Denk wd@denx.de wrote:
Commit 6dc1ece "Introduce a new linker flag LDFLAGS_FINAL" modified a number of Makefiles in a way that broke out-of-tree builds. The problem was that $(nandobj) was used before it got defined.
Fix this.
Signed-off-by: Wolfgang Denk wd@denx.de
nand_spl/board/amcc/acadia/Makefile | 6 +++--- nand_spl/board/amcc/bamboo/Makefile | 6 +++--- nand_spl/board/amcc/canyonlands/Makefile | 6 +++--- nand_spl/board/amcc/kilauea/Makefile | 6 +++--- nand_spl/board/amcc/sequoia/Makefile | 6 +++--- nand_spl/board/freescale/mpc8313erdb/Makefile | 6 +++--- nand_spl/board/freescale/mpc8315erdb/Makefile | 6 +++--- nand_spl/board/freescale/mpc8536ds/Makefile | 6 +++--- nand_spl/board/freescale/mpc8569mds/Makefile | 6 +++--- nand_spl/board/freescale/mpc8572ds/Makefile | 6 +++--- nand_spl/board/sheldon/simpc8313/Makefile | 6 +++--- 11 files changed, 33 insertions(+), 33 deletions(-)
Also needed in da8xxevm, tx25, smdk6400, and mx31pdk.
Should also be done in p1_p2_rdb for consistency (it doesn't use nandobj in LDFLAGS, but neither do the ohter 85xx that got updated).
-Scott
On Thu, 31 Mar 2011 11:19:15 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Kim & Kumar,
are you aware that a number of 83xx boards don't build any more? I see errors like these:
Configuring for MPC8313ERDB_NAND_33 - Board: MPC8313ERDB, Options: SYS_33MHZ,NAND_U_BOOT ppc_6xx-ld: cannot open linker script file u-boot.lds: No such file or directory make[1]: *** [/work/wd/tmp-ppc/nand_spl/u-boot-spl] Error 1
this isn't 83xx-specific; the nand_spl target was source tree build dependent. Scott already has a fix in his next branch:
http://git.denx.de/?p=u-boot/u-boot-nand-flash.git;a=commit;h=f13a375e5875ac...
Scott, please push this commit upstream to fix out of source tree NAND builds.
Kim
Dear Kim Phillips,
In message 20110331103141.80162901.kim.phillips@freescale.com you wrote:
On Thu, 31 Mar 2011 11:19:15 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Kim & Kumar,
are you aware that a number of 83xx boards don't build any more? I see errors like these:
Configuring for MPC8313ERDB_NAND_33 - Board: MPC8313ERDB, Options: SYS_33MHZ,NAND_U_BOOT ppc_6xx-ld: cannot open linker script file u-boot.lds: No such file or directory make[1]: *** [/work/wd/tmp-ppc/nand_spl/u-boot-spl] Error 1
this isn't 83xx-specific; the nand_spl target was source tree build dependent. Scott already has a fix in his next branch:
http://git.denx.de/?p=u-boot/u-boot-nand-flash.git;a=commit;h=f13a375e5875ac...
Scott, please push this commit upstream to fix out of source tree NAND builds.
See my previous mail with a fix.
Why put such fiuxes into a NEXT branch when we're trying to get a release ot?
That's ...
Best regards,
Wolfgang Denk
On Thu, 31 Mar 2011 17:40:17 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Kim Phillips,
In message 20110331103141.80162901.kim.phillips@freescale.com you wrote:
On Thu, 31 Mar 2011 11:19:15 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Kim & Kumar,
are you aware that a number of 83xx boards don't build any more? I see errors like these:
Configuring for MPC8313ERDB_NAND_33 - Board: MPC8313ERDB, Options: SYS_33MHZ,NAND_U_BOOT ppc_6xx-ld: cannot open linker script file u-boot.lds: No such file or directory make[1]: *** [/work/wd/tmp-ppc/nand_spl/u-boot-spl] Error 1
this isn't 83xx-specific; the nand_spl target was source tree build dependent. Scott already has a fix in his next branch:
http://git.denx.de/?p=u-boot/u-boot-nand-flash.git;a=commit;h=f13a375e5875ac...
Scott, please push this commit upstream to fix out of source tree NAND builds.
See my previous mail with a fix.
Why put such fiuxes into a NEXT branch when we're trying to get a release ot?
That's ...
The patch Kim quoted, which is in my next branch, is unrelated to the above error. It is a cleanup patch.
I don't see the above error with top-of-tree:
$ CROSS_COMPILE=~/ppc-tc-4.5/bin/powerpc-linux-gnu- ./MAKEALL MPC8313ERDB_NAND_33 Configuring for MPC8313ERDB_NAND_33 - Board: MPC8313ERDB, Options: SYS_33MHZ,NAND_U_BOOT text data bss dec hex filename 250372 27944 42056 320372 4e374 ./u-boot
--------------------- SUMMARY ---------------------------- Boards compiled: 1 ----------------------------------------------------------
$ git describe HEAD v2011.03-rc2-6-gb12fee0
-Scott
On Thu, 31 Mar 2011 11:21:09 -0500 Scott Wood scottwood@freescale.com wrote:
On Thu, 31 Mar 2011 17:40:17 +0200 Wolfgang Denk wd@denx.de wrote:
In message 20110331103141.80162901.kim.phillips@freescale.com you wrote:
Scott, please push this commit upstream to fix out of source tree NAND builds.
See my previous mail with a fix.
Why put such fiuxes into a NEXT branch when we're trying to get a release ot?
That's ...
The patch Kim quoted, which is in my next branch, is unrelated to the above error. It is a cleanup patch.
it prepends the build directory $(obj) to the nand_spl target. But now WD has posted another patch (that seems more invasive than the one I quoted).
I don't see the above error with top-of-tree:
$ CROSS_COMPILE=~/ppc-tc-4.5/bin/powerpc-linux-gnu- ./MAKEALL MPC8313ERDB_NAND_33
try BUILD_DIR=/tmp/hah ./MAKEALL MPC8313ERDB_NAND_33
Kim
On Thu, 31 Mar 2011 11:51:30 -0500 Kim Phillips kim.phillips@freescale.com wrote:
On Thu, 31 Mar 2011 11:21:09 -0500 Scott Wood scottwood@freescale.com wrote:
On Thu, 31 Mar 2011 17:40:17 +0200 Wolfgang Denk wd@denx.de wrote:
In message 20110331103141.80162901.kim.phillips@freescale.com you wrote:
Scott, please push this commit upstream to fix out of source tree NAND builds.
See my previous mail with a fix.
Why put such fiuxes into a NEXT branch when we're trying to get a release ot?
That's ...
The patch Kim quoted, which is in my next branch, is unrelated to the above error. It is a cleanup patch.
it prepends the build directory $(obj) to the nand_spl target.
The build directory was always prepended to the nand_spl target. That patch just moves where the target was defined.
The problem is with $(nandobj) in the nand_spl makefiles.
But now WD has posted another patch (that seems more invasive than the one I quoted).
It's solving a different problem, and it's the right fix -- it's better to avoid depending on deferred evaluation if we can do so reasonably.
I don't see the above error with top-of-tree:
$ CROSS_COMPILE=~/ppc-tc-4.5/bin/powerpc-linux-gnu- ./MAKEALL MPC8313ERDB_NAND_33
try BUILD_DIR=/tmp/hah ./MAKEALL MPC8313ERDB_NAND_33
Right, I saw afterward that it was an out-of-tree build. I see the same thing in my next branch, once I rebase onto Wolfgang's current master which has the LDFLAGS_FINAL patch.
"Fix NAND_SPL and ONENAND_IPL in Makefile" has nothing to do with this.
-Scott
Dear Scott Wood,
In message 20110331112109.12162cb9@schlenkerla.am.freescale.net you wrote:
I don't see the above error with top-of-tree:
$ CROSS_COMPILE=~/ppc-tc-4.5/bin/powerpc-linux-gnu- ./MAKEALL MPC8313ERDB_NAND_33 Configuring for MPC8313ERDB_NAND_33 - Board: MPC8313ERDB, Options: SYS_33MHZ,NAND_U_BOOT text data bss dec hex filename 250372 27944 42056 320372 4e374 ./u-boot
No, you don't see it, because you're not building out of tree.
Best regards,
Wolfgang Denk
participants (4)
-
Haiying Wang -
Kim Phillips -
Scott Wood -
Wolfgang Denk