[U-Boot] [PATCH] ARM: remove unused ATAG

ATAG_VIDEOLFB is not used anywhere. The belowing warning is occurred due to this ATAG.
[ 0.000000] Ignoring unrecognised tag 0x54410008
This patch fixed it.
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com --- arch/arm/lib/bootm.c | 43 +++---------------------------------------- 1 files changed, 3 insertions(+), 40 deletions(-)
diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index 128b7e3..5ac1302 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -33,9 +33,7 @@ DECLARE_GLOBAL_DATA_PTR; defined (CONFIG_CMDLINE_TAG) || \ defined (CONFIG_INITRD_TAG) || \ defined (CONFIG_SERIAL_TAG) || \ - defined (CONFIG_REVISION_TAG) || \ - defined (CONFIG_VFD) || \ - defined (CONFIG_LCD) + defined (CONFIG_REVISION_TAG) static void setup_start_tag (bd_t *bd);
# ifdef CONFIG_SETUP_MEMORY_TAGS @@ -49,10 +47,6 @@ static void setup_initrd_tag (bd_t *bd, ulong initrd_start, # endif static void setup_end_tag (bd_t *bd);
-# if defined (CONFIG_VFD) || defined (CONFIG_LCD) -static void setup_videolfb_tag (gd_t *gd); -# endif - static struct tag *params; #endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */
@@ -87,9 +81,7 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) defined (CONFIG_CMDLINE_TAG) || \ defined (CONFIG_INITRD_TAG) || \ defined (CONFIG_SERIAL_TAG) || \ - defined (CONFIG_REVISION_TAG) || \ - defined (CONFIG_LCD) || \ - defined (CONFIG_VFD) + defined (CONFIG_REVISION_TAG) setup_start_tag (bd); #ifdef CONFIG_SERIAL_TAG setup_serial_tag (¶ms); @@ -107,9 +99,6 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) if (images->rd_start && images->rd_end) setup_initrd_tag (bd, images->rd_start, images->rd_end); #endif -#if defined (CONFIG_VFD) || defined (CONFIG_LCD) - setup_videolfb_tag ((gd_t *) gd); -#endif setup_end_tag (bd); #endif
@@ -136,9 +125,7 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) defined (CONFIG_CMDLINE_TAG) || \ defined (CONFIG_INITRD_TAG) || \ defined (CONFIG_SERIAL_TAG) || \ - defined (CONFIG_REVISION_TAG) || \ - defined (CONFIG_LCD) || \ - defined (CONFIG_VFD) + defined (CONFIG_REVISION_TAG) static void setup_start_tag (bd_t *bd) { params = (struct tag *) bd->bi_boot_params; @@ -214,30 +201,6 @@ static void setup_initrd_tag (bd_t *bd, ulong initrd_start, ulong initrd_end) } #endif /* CONFIG_INITRD_TAG */
- -#if defined (CONFIG_VFD) || defined (CONFIG_LCD) -extern ulong calc_fbsize (void); -static void setup_videolfb_tag (gd_t *gd) -{ - /* An ATAG_VIDEOLFB node tells the kernel where and how large - * the framebuffer for video was allocated (among other things). - * Note that a _physical_ address is passed ! - * - * We only use it to pass the address and size, the other entries - * in the tag_videolfb are not of interest. - */ - params->hdr.tag = ATAG_VIDEOLFB; - params->hdr.size = tag_size (tag_videolfb); - - params->u.videolfb.lfb_base = (u32) gd->fb_base; - /* Fb size is calculated according to parameters for our panel - */ - params->u.videolfb.lfb_size = calc_fbsize(); - - params = tag_next (params); -} -#endif /* CONFIG_VFD || CONFIG_LCD */ - #ifdef CONFIG_SERIAL_TAG void setup_serial_tag (struct tag **tmp) {

Dear Minkyu Kang,
In message 4C1B4AEE.8090500@samsung.com you wrote:
ATAG_VIDEOLFB is not used anywhere.
... not any more, that is.
The belowing warning is occurred due to this ATAG.
[ 0.000000] Ignoring unrecognised tag 0x54410008
This patch fixed it.
I think we should try to find another way to fix this.
- defined (CONFIG_VFD) || \
- defined (CONFIG_LCD)
- defined (CONFIG_REVISION_TAG)
static void setup_start_tag (bd_t *bd);
...
-# if defined (CONFIG_VFD) || defined (CONFIG_LCD) -static void setup_videolfb_tag (gd_t *gd); -# endif
...
- defined (CONFIG_REVISION_TAG) || \
- defined (CONFIG_LCD) || \
- defined (CONFIG_VFD)
- defined (CONFIG_REVISION_TAG)
...
-#if defined (CONFIG_VFD) || defined (CONFIG_LCD)
- setup_videolfb_tag ((gd_t *) gd);
-#endif
...
etc.
By removing all references to CONFIG_VFD you break support for the board using this feature. As far as I know this board is stillrunnign a 2.4.27-vrs1 kernel, which hdas ATAG_VIDEOLFB defined and used in include/asm-arm/setup.h resp. arch/arm/kernel/setup.c
Best regards,
Wolfgang Denk

u-boot-bounces@lists.denx.de wrote on Friday, June 18, 2010 12:50 PM:
Dear Minkyu Kang,
In message 4C1B4AEE.8090500@samsung.com you wrote:
ATAG_VIDEOLFB is not used anywhere.
... not any more, that is.
The belowing warning is occurred due to this ATAG.
[ 0.000000] Ignoring unrecognised tag 0x54410008
This patch fixed it.
I think we should try to find another way to fix this.
- defined (CONFIG_VFD) || \
- defined (CONFIG_LCD)
- defined (CONFIG_REVISION_TAG)
static void setup_start_tag (bd_t *bd);
...
-# if defined (CONFIG_VFD) || defined (CONFIG_LCD) -static void setup_videolfb_tag (gd_t *gd); -# endif
...
- defined (CONFIG_REVISION_TAG) || \
- defined (CONFIG_LCD) || \
- defined (CONFIG_VFD)
- defined (CONFIG_REVISION_TAG)
...
-#if defined (CONFIG_VFD) || defined (CONFIG_LCD)
- setup_videolfb_tag ((gd_t *) gd);
-#endif
...
etc.
By removing all references to CONFIG_VFD you break support for the board using this feature. As far as I know this board is stillrunnign
If you reference to the trab board, then yes it is still running. But on this board a very very old version of U-Boot is running, and I don't see, that this would change during the remaining lifetime of the board. Thus it's fine by me to break/remove the board support from current U-Boot.
a 2.4.27-vrs1 kernel, which hdas ATAG_VIDEOLFB defined and used in include/asm-arm/setup.h resp. arch/arm/kernel/setup.c
Best regards,
Wolfgang Denk
Best regards, Martin Krause
Development Phone +49 8153 9308-157, Fax +49 8153 9308-7157 mailto:martin.krause@tqs.de
TQ-Systems GmbH Muehlstrasse 2, Gut Delling, D-82229 Seefeld, Germany Amtsgericht München, HRB 105 018, UST-IdNr. DE 811 607 913 Place of business: Seefeld Managing Directors: Dipl.-Ing. (FH) Detlef Schneider, Dipl.-Ing. (FH) Rüdiger Stahl http://www.tq-group.com/

Dear Martin,
In message 47F3F98010FF784EBEE6526EAAB078D10635E71C@tq-mailsrv.tq-net.de you wrote:
If you reference to the trab board, then yes it is still running. But on this board a very very old version of U-Boot is running, and I don't see, that this would change during the remaining lifetime of the board. Thus it's fine by me to break/remove the board support from current U-Boot.
Should we remove the whole trab support, then?
Best regards,
Wolfgang Denk

Hi Wolfgang,
Wolfgang Denk wrote on Friday, June 18, 2010 8:18 PM:
Dear Martin,
In message 47F3F98010FF784EBEE6526EAAB078D10635E71C@tq-mailsrv.tq-net.de you wrote:
If you reference to the trab board, then yes it is still running. But on this board a very very old version of U-Boot is running, and I don't see, that this would change during the remaining lifetime of the board. Thus it's fine by me to break/remove the board support from current U-Boot.
Should we remove the whole trab support, then?
If it helps in any way to make U-Boot better (make the code more maintainable, remove some special configuration options, which are only used on trab board, etc.), and no one has objections, then the whole trab board support can be removed.
Best Regards, Martin Krasue

Dear "Martin Krause",
In message 47F3F98010FF784EBEE6526EAAB078D10635E720@tq-mailsrv.tq-net.de you wrote:
Should we remove the whole trab support, then?
If it helps in any way to make U-Boot better (make the code more maintainable, remove some special configuration options, which are only used on trab board, etc.), and no one has objections, then=20 the whole trab board support can be removed.
OK, I'll keep this in mind. So far the board support is still somewhat useful as I use it as test case for s3c2400 processors, but as soon as this board should cause troube that would require efforts we will consider dropping it.
Thanks for the feedback.
Best regards,
Wolfgang Denk

Dear Minkyu Kang,
In message 4C1B4AEE.8090500@samsung.com you wrote:
ATAG_VIDEOLFB is not used anywhere. The belowing warning is occurred due to this ATAG.
[ 0.000000] Ignoring unrecognised tag 0x54410008
This patch fixed it.
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com
arch/arm/lib/bootm.c | 43 +++---------------------------------------- 1 files changed, 3 insertions(+), 40 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Martin Krause
-
Minkyu Kang
-
Wolfgang Denk