[U-Boot] [PATCH 3/3] minor fixes for mvBL-M7 and use of common code
MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
On Mon, 22 Jun 2009 15:50:29 +0200 André Schwarz andre.schwarz@matrix-vision.de wrote:
Hello André,
X-Mailer: Evolution 2.26.1
...
[0001-rebased-mvBLM7-with-minor-fixes.patch text/x-patch (8.2KB)]
please use Insert->Text File... (Alt-n x) to insert the patch.
-#define _IO_BASE 0x00000000
the above is the reason for the below:
Applying: minor fixes for mvBL-M7 and use of common code error: patch failed: include/configs/MVBLM7.h:193 error: include/configs/MVBLM7.h: patch does not apply Patch failed at 0001 minor fixes for mvBL-M7 and use of common code
...and because I have the "remove _IO_BASE and KSEG1ADDR from board configuration files" patch already applied, and probably justifiably so, since it arrived earlier to the list than your patch.
btw, I also get this at build time:
Configuring for MVBLM7 board... mv_common.c: In function 'mv_load_fpga': mv_common.c:93: warning: implicit declaration of function 'fpga_load'
So did you want 1-3/3 of these to bypass u-boot-mpc83xx and go straight to WD? I'm asking because there's overlap with the mpc5xxx maintainer (WD himself apparently) in this patchseries.
Kim
Kim,
On Tue, 2009-06-23 at 18:17 -0500, Kim Phillips wrote:
On Mon, 22 Jun 2009 15:50:29 +0200 André Schwarz andre.schwarz@matrix-vision.de wrote:
Hello André,
X-Mailer: Evolution 2.26.1
...
[0001-rebased-mvBLM7-with-minor-fixes.patch text/x-patch (8.2KB)]
please use Insert->Text File... (Alt-n x) to insert the patch.
sorry - has been my first patch sent with evolution.
-#define _IO_BASE 0x00000000
the above is the reason for the below:
ok - understood. Didn't expect your patch being applied that quickly, i.e. obviously missed all ACK's.
Applying: minor fixes for mvBL-M7 and use of common code error: patch failed: include/configs/MVBLM7.h:193 error: include/configs/MVBLM7.h: patch does not apply Patch failed at 0001 minor fixes for mvBL-M7 and use of common code
...and because I have the "remove _IO_BASE and KSEG1ADDR from board configuration files" patch already applied, and probably justifiably so, since it arrived earlier to the list than your patch.
btw, I also get this at build time:
Configuring for MVBLM7 board... mv_common.c: In function 'mv_load_fpga': mv_common.c:93: warning: implicit declaration of function 'fpga_load'
So did you want 1-3/3 of these to bypass u-boot-mpc83xx and go straight to WD? I'm asking because there's overlap with the mpc5xxx maintainer (WD himself apparently) in this patchseries.
Will wait for all replies. As far as I know WD is on vacation, i.e. this is going to take some time. I'm in no hurry - if it's ok for you I'll fix all remaining issues with a single rebase/resend.
Cheers, André
Kim
MATRIX VISION GmbH, Talstra�e 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch�ftsf�hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
On Wed, 24 Jun 2009 16:19:06 +0200 André Schwarz andre.schwarz@matrix-vision.de wrote:
-#define _IO_BASE 0x00000000
the above is the reason for the below:
ok - understood. Didn't expect your patch being applied that quickly, i.e. obviously missed all ACK's.
WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.
So did you want 1-3/3 of these to bypass u-boot-mpc83xx and go straight to WD? I'm asking because there's overlap with the mpc5xxx maintainer (WD himself apparently) in this patchseries.
Will wait for all replies. As far as I know WD is on vacation, i.e. this is going to take some time. I'm in no hurry - if it's ok for you I'll fix all remaining issues with a single rebase/resend.
sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.
Kim
Dear Kim Phillips,
In message 20090624112410.b287f606.kim.phillips@freescale.com you wrote:
WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.
...
sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.
I'm pretty sure that I lost track of what you are talking here. So if ther eis anything you expect me to do please tell me (ideally in short and easy sentences :-)
Best regards,
Wolfgang Denk
On Tue, 07 Jul 2009 21:04:43 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Kim Phillips,
In message 20090624112410.b287f606.kim.phillips@freescale.com you wrote:
WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.
...
sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.
I'm pretty sure that I lost track of what you are talking here. So if ther eis anything you expect me to do please tell me (ideally in short and easy sentences :-)
no, there isn't, WD. Glad you're back, though.
André, feel free to re-send your patchseries to WD now.
Thanks both,
Kim
Kim Phillips schrieb:
On Tue, 07 Jul 2009 21:04:43 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Kim Phillips,
In message 20090624112410.b287f606.kim.phillips@freescale.com you wrote:
WD hasn't applied it yet - I applied it to my local tree. None of this means your patch should touch the same line and thus cause unnecessary conflicts.
...
sure, go ahead - I guess we have to wait for WD to pick them up. I'll try and ack them before he gets back.
I'm pretty sure that I lost track of what you are talking here. So if ther eis anything you expect me to do please tell me (ideally in short and easy sentences :-)
no, there isn't, WD. Glad you're back, though.
André, feel free to re-send your patchseries to WD now.
thanks - need to wait for other patches (e.g. Heiko) and rebase.
Thanks both,
Kim
MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
participants (4)
-
Andre Schwarz -
André Schwarz
-
Kim Phillips -
Wolfgang Denk