[U-Boot] Please pull u-boot-dm
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
---------------------------------------------------------------- Simon Glass (62): sandbox: Don't print a warning for CONFIG_I2C_COMPAT README: Remove CONFIG_SYS_MALLOC_F_LEN comment spl: Drop include of i2c.h Makefile: Allow the SPL final link rule to be overridden sandbox: Allow chaining from SPL to U-Boot proper sandbox: Support building an SPL image sandbox: Correct header file order in cpu.c sandbox: Add some missing headers in cpu.c sandbox: Don't use PCI in SPL sandbox: Don't include the main loop in SPL sandbox: Add basic SPL implementation sandbox: Don't use IDE and iotrace in SPL sandbox: serial: Don't sync video in SPL sandbox: Add a new sandbox_spl board sandbox: Add a test device that uses of-platdata dm: spl: Don't set up device tree with of-platdata dm: Makefile: Build of-platdata before SPL dm: core: Don't use device tree with of-platdata dm: regmap: Add a dummy implementation for of-platdata dm: syscon: Add support for of-platdata dm: sandbox: Add a simple driver to test of-platdata dm: Add a header that provides access to the of-platdata structs dm: clk: Add support for of-platdata dm: serial: Add support for of-platdata dm: Don't include fdtdec functions when of-platdata is enabled dm: Add an option to enable the of-platdata feature dm: Add a README for of-platdata dm: Add a library to provide simple device-tree access dm: Add a tool to generate C code from a device tree dm: Makefile: Build of-platdata files when the feature is enabled dm: Add a more efficient libfdt library Only build the libfdt python module if 'swig' is available tiny-printf: Support assert() dm: spl: Bind in all devices in SPL with of-platdata dm: core: Rename DM_NAME_ALLOCED to DM_FLAG_NAME_ALLOCED dtoc: Ignore the u-boot, dm-pre-reloc property dm: Don't attach the device tree to SPL with of-platdata dm: core: Expand platdata for of-platdata devices sandbox: Don't bring in the eeprom emulator in SPL dm: sandbox: Enable of-platdata for sandbox_spl dm: core: Move regmap allocation into a separate function dm: core: Add an implementation of regmap_init_mem_platdata() dm: serial: ns16550: Update to support of-platdata rockchip: serial: Add an of-platdata driver for rockchip rockchip: Update the sdram-channel property to support of-platdata rockchip: mmc: Move all DT decoding to ofdata_to_platdata() rockchip: mmc: Update the driver to support of-platdata rockchip: clk: Move all DT decoding to ofdata_to_platdata() rockchip: clk: Update the rk3288 driver to support of-platdata rockchip: pinctrl: Update the rk3288 driver to support of-platdata rockchip: Move the MMC setup check earlier rockchip: Don't use spl_boot_device() with of-platdata rockchip: syscon: Update to work with of-platdata rockchip: sdram: Move all DT decoding to ofdata_to_platdata() rockchip: sdram: Update the driver to support of-platdata rockchip: Use of-platdata for firefly-rk3288 test/py: Handle testing with the sandbox_spl board test/py: Note which console produced unexpected output test/py: Provide a way to get early console output test/py: Start sandbox SPL when enabled dm: Add a test for of-platdata dm: Update the of-platdata README for the new features
Makefile | 5 +- README | 3 - arch/arm/dts/rk3288-firefly.dts | 3 +- arch/arm/include/asm/arch-rockchip/sdram.h | 14 +-- arch/arm/mach-rockchip/rk3288-board-spl.c | 25 ++-- arch/arm/mach-rockchip/rk3288/sdram_rk3288.c | 130 +++++++++++++++----- arch/arm/mach-rockchip/rk3288/syscon_rk3288.c | 38 ++++++ arch/sandbox/Kconfig | 7 +- arch/sandbox/config.mk | 5 + arch/sandbox/cpu/Makefile | 1 + arch/sandbox/cpu/cpu.c | 6 +- arch/sandbox/cpu/os.c | 51 ++++++++ arch/sandbox/cpu/spl.c | 68 +++++++++++ arch/sandbox/cpu/start.c | 2 + arch/sandbox/cpu/u-boot-spl.lds | 24 ++++ arch/sandbox/dts/sandbox.dts | 31 +++++ arch/sandbox/include/asm/spl.h | 23 ++++ arch/sandbox/lib/Makefile | 2 + board/sandbox/MAINTAINERS | 7 ++ common/spl/spl.c | 6 +- configs/firefly-rk3288_defconfig | 3 + configs/sandbox_spl_defconfig | 183 +++++++++++++++++++++++++++ doc/driver-model/of-plat.txt | 310 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/clk/clk-uclass.c | 22 +++- drivers/clk/clk_fixed_rate.c | 2 + drivers/clk/clk_rk3288.c | 33 ++++- drivers/core/device-remove.c | 2 +- drivers/core/device.c | 47 +++++-- drivers/core/lists.c | 2 +- drivers/core/regmap.c | 57 +++++++-- drivers/core/root.c | 4 +- drivers/core/syscon-uclass.c | 13 ++ drivers/misc/Makefile | 7 ++ drivers/misc/spltest_sandbox.c | 53 ++++++++ drivers/mmc/rockchip_dw_mmc.c | 59 ++++++--- drivers/pinctrl/rockchip/pinctrl_rk3288.c | 8 +- drivers/serial/Kconfig | 9 ++ drivers/serial/Makefile | 3 + drivers/serial/ns16550.c | 4 +- drivers/serial/sandbox.c | 2 + drivers/serial/serial-uclass.c | 8 +- drivers/serial/serial_rockchip.c | 43 +++++++ dts/Kconfig | 21 ++++ include/clk.h | 4 + include/configs/sandbox.h | 4 + include/configs/sandbox_spl.h | 20 +++ include/dm/device.h | 6 +- include/dm/platdata.h | 5 + include/dt-structs.h | 19 +++ include/os.h | 25 ++++ include/regmap.h | 16 +++ include/syscon.h | 11 ++ lib/Makefile | 5 +- lib/libfdt/libfdt.swig | 89 ++++++++++++++ lib/libfdt/setup.py | 38 ++++++ lib/libfdt/test_libfdt.py | 14 +++ lib/tiny-printf.c | 9 ++ scripts/Makefile.host | 9 +- scripts/Makefile.spl | 47 ++++++- test/py/conftest.py | 2 +- test/py/tests/test_ofplatdata.py | 42 +++++++ test/py/u_boot_console_base.py | 12 +- test/py/u_boot_console_sandbox.py | 6 +- test/py/u_boot_spawn.py | 13 ++ tools/Makefile | 14 +++ tools/dtoc/.gitignore | 1 + tools/dtoc/dtoc | 1 + tools/dtoc/dtoc.py | 394 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/dtoc/fdt.py | 180 +++++++++++++++++++++++++++ tools/dtoc/fdt_fallback.py | 207 +++++++++++++++++++++++++++++++ tools/dtoc/fdt_util.py | 86 +++++++++++++ 71 files changed, 2495 insertions(+), 130 deletions(-) create mode 100644 arch/sandbox/cpu/spl.c create mode 100644 arch/sandbox/cpu/u-boot-spl.lds create mode 100644 arch/sandbox/include/asm/spl.h create mode 100644 configs/sandbox_spl_defconfig create mode 100644 doc/driver-model/of-plat.txt create mode 100644 drivers/misc/spltest_sandbox.c create mode 100644 drivers/serial/serial_rockchip.c create mode 100644 include/configs/sandbox_spl.h create mode 100644 include/dt-structs.h create mode 100644 lib/libfdt/libfdt.swig create mode 100644 lib/libfdt/setup.py create mode 100644 lib/libfdt/test_libfdt.py create mode 100644 test/py/tests/test_ofplatdata.py create mode 100644 tools/dtoc/.gitignore create mode 120000 tools/dtoc/dtoc create mode 100755 tools/dtoc/dtoc.py create mode 100644 tools/dtoc/fdt.py create mode 100644 tools/dtoc/fdt_fallback.py create mode 100644 tools/dtoc/fdt_util.py
Regards, Simon
On 07/14/2016 10:02 PM, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
Regards, Simon
On Fri, Jul 15, 2016 at 10:08:34AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
I believe that was in Debian/Jessie and gcc-4.9.2. I'll send the files off-list.
Hi Tom,
On 15 July 2016 at 10:13, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:08:34AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
I believe that was in Debian/Jessie and gcc-4.9.2. I'll send the files off-list.
OK, I'm a bit stumped by that. There are two string arrays - it should set the type to the larger of the two (i.e. 3 elements instead of 2). I don't see this problem in my self. What version of Python do you run? I will dig in and see if I can figure out what it is later on today.
But given that sandbox_spl is a new board, perhaps it is OK to apply this for now?
Regards, Simon
On Fri, Jul 15, 2016 at 10:22:36AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 10:13, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:08:34AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
I believe that was in Debian/Jessie and gcc-4.9.2. I'll send the files off-list.
OK, I'm a bit stumped by that. There are two string arrays - it should set the type to the larger of the two (i.e. 3 elements instead of 2). I don't see this problem in my self. What version of Python do you run? I will dig in and see if I can figure out what it is later on today.
It's a stock Debian/Jessie, so whatever is default.
But given that sandbox_spl is a new board, perhaps it is OK to apply this for now?
Yeah, but please follow up with a patch to fix the test thing Stephen found and I'll grab it before pushing, test failures turn his Jenkins setup red and then other stuff doesn't happen, iirc. Thanks!
On 07/15/2016 10:29 AM, Tom Rini wrote:
On Fri, Jul 15, 2016 at 10:22:36AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 10:13, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:08:34AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote: > Hi Tom, > > Here is the of-platdata implementation, including the introduction of > sandbox_spl. > > > The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897: > > Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 > 17:36:18 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-dm.git > > for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561: > > dm: Update the of-platdata README for the new features (2016-07-14 > 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
I believe that was in Debian/Jessie and gcc-4.9.2. I'll send the files off-list.
OK, I'm a bit stumped by that. There are two string arrays - it should set the type to the larger of the two (i.e. 3 elements instead of 2). I don't see this problem in my self. What version of Python do you run? I will dig in and see if I can figure out what it is later on today.
It's a stock Debian/Jessie, so whatever is default.
But given that sandbox_spl is a new board, perhaps it is OK to apply this for now?
Yeah, but please follow up with a patch to fix the test thing Stephen found and I'll grab it before pushing, test failures turn his Jenkins setup red and then other stuff doesn't happen, iirc. Thanks!
Build failures prevent any tests from running on any boards, unfortunately (perhaps I should make separate Jenkins jobs for each board, or make the test trigger not depend on the build status).
Test failures don't prevent any other tests from running, but they do make it harder to notice new failures; in the face of test failures, each Jenkins test job has both an old and a new status of "failed" and I then have to manually compare the list of failed tests. It's much easier to notice new failures.
Hi Tom,
On 15 July 2016 at 10:29, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:22:36AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 10:13, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:08:34AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote: >Hi Tom, > >Here is the of-platdata implementation, including the introduction of >sandbox_spl. > > >The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897: > > Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 >17:36:18 -0400) > >are available in the git repository at: > > git://git.denx.de/u-boot-dm.git > >for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561: > > dm: Update the of-platdata README for the new features (2016-07-14 >20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
I believe that was in Debian/Jessie and gcc-4.9.2. I'll send the files off-list.
OK, I'm a bit stumped by that. There are two string arrays - it should set the type to the larger of the two (i.e. 3 elements instead of 2). I don't see this problem in my self. What version of Python do you run? I will dig in and see if I can figure out what it is later on today.
It's a stock Debian/Jessie, so whatever is default.
OK thanks. I'll try installing it. Do you use 32-bit or 64-bit? (in case it matters)
I suspect the problem might be my relying on dictionary order somehow.
But given that sandbox_spl is a new board, perhaps it is OK to apply this for now?
Yeah, but please follow up with a patch to fix the test thing Stephen found and I'll grab it before pushing, test failures turn his Jenkins setup red and then other stuff doesn't happen, iirc. Thanks!
OK (as you saw) that is done.
-- Tom
Regards, Simon
On Sun, Jul 17, 2016 at 08:14:47AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 10:29, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:22:36AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 10:13, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:08:34AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote: > On 07/14/2016 10:02 PM, Simon Glass wrote: > >Hi Tom, > > > >Here is the of-platdata implementation, including the introduction of > >sandbox_spl. > > > > > >The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897: > > > > Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 > >17:36:18 -0400) > > > >are available in the git repository at: > > > > git://git.denx.de/u-boot-dm.git > > > >for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561: > > > > dm: Update the of-platdata README for the new features (2016-07-14 > >20:40:24 -0600) > > FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() > on the following boards for me: beaver, dalmore, jetson-tk1. That's > all the 32-bit Tegra boards I'm testing.
It's also adding a warning: w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
I believe that was in Debian/Jessie and gcc-4.9.2. I'll send the files off-list.
OK, I'm a bit stumped by that. There are two string arrays - it should set the type to the larger of the two (i.e. 3 elements instead of 2). I don't see this problem in my self. What version of Python do you run? I will dig in and see if I can figure out what it is later on today.
It's a stock Debian/Jessie, so whatever is default.
OK thanks. I'll try installing it. Do you use 32-bit or 64-bit? (in case it matters)
64bit.
Hi Tom,
On 17 July 2016 at 11:05, Tom Rini trini@konsulko.com wrote:
On Sun, Jul 17, 2016 at 08:14:47AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 10:29, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:22:36AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 10:13, Tom Rini trini@konsulko.com wrote:
On Fri, Jul 15, 2016 at 10:08:34AM -0600, Simon Glass wrote:
Hi Tom,
On 15 July 2016 at 09:46, Tom Rini trini@konsulko.com wrote: > On Fri, Jul 15, 2016 at 09:28:21AM -0600, Stephen Warren wrote: >> On 07/14/2016 10:02 PM, Simon Glass wrote: >> >Hi Tom, >> > >> >Here is the of-platdata implementation, including the introduction of >> >sandbox_spl. >> > >> > >> >The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897: >> > >> > Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 >> >17:36:18 -0400) >> > >> >are available in the git repository at: >> > >> > git://git.denx.de/u-boot-dm.git >> > >> >for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561: >> > >> > dm: Update the of-platdata README for the new features (2016-07-14 >> >20:40:24 -0600) >> >> FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() >> on the following boards for me: beaver, dalmore, jetson-tk1. That's >> all the 32-bit Tegra boards I'm testing. > > It's also adding a warning: > w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in > array initialize > r > w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near > initialization for ‘dtv_spl_t > est2.stringarray’)
What toolchain is this? Can you please send me the dt-platdata.c and include/generated/dt-structs.h files?
I believe that was in Debian/Jessie and gcc-4.9.2. I'll send the files off-list.
OK, I'm a bit stumped by that. There are two string arrays - it should set the type to the larger of the two (i.e. 3 elements instead of 2). I don't see this problem in my self. What version of Python do you run? I will dig in and see if I can figure out what it is later on today.
It's a stock Debian/Jessie, so whatever is default.
OK thanks. I'll try installing it. Do you use 32-bit or 64-bit? (in case it matters)
64bit.
OK, it didn't happen for me on Jessie but I managed to repeat this on an old Precise install. It's a simple fix...will send a patch. Great that you found it.
Regards, Simon
Hi Stephen,
On 15 July 2016 at 09:28, Stephen Warren swarren@wwwdotorg.org wrote:
On 07/14/2016 10:02 PM, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
FYI, the latest u-boot-dm/mater fails test/py test test_ofplatdata() on the following boards for me: beaver, dalmore, jetson-tk1. That's all the 32-bit Tegra boards I'm testing.
That's probably because it is not enabled for Tegra, so it should not be run. I suspect the test condition is insufficient and should include OF_PLATDATA:
@pytest.mark.buildconfigspec('spl')
Regards, Simon
On Thu, Jul 14, 2016 at 10:02:40PM -0600, Simon Glass wrote:
Hi Tom,
Here is the of-platdata implementation, including the introduction of sandbox_spl.
The following changes since commit 3a592a1349ac3961b0f4f2db0a8d9f128225d897:
Revert "armv8: Enable CPUECTLR.SMPEN for coherency" (2016-07-14 17:36:18 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-dm.git
for you to fetch changes up to 1269625177f120d659f66b18de4b532b16c44561:
dm: Update the of-platdata README for the new features (2016-07-14 20:40:24 -0600)
Applied to u-boot/master, thanks! But please note: +(sandbox_spl) .stringarray = {"another", "multi-word", "message"}, +(sandbox_spl) ^ w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: excess elements in array initialize r w+(sandbox_spl) spl/dts/dt-platdata.c:38:2: warning: (near initialization for ‘dtv_spl_t est2.stringarray’)
participants (3)
-
Simon Glass -
Stephen Warren -
Tom Rini