Commit 401d1c4f5d2 ("common: Drop asm/global_data.h from common header") broke CONFIG_CMD_SQUASHFS=y
Hello!
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
Here is console output:
fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’: fs/squashfs/sqfs_inode.c:121:18: warning: implicit declaration of function ‘le32_to_cpu’ [-Wimplicit-function-declaration] for (k = 0; k < le32_to_cpu(inode_count); k++) { ^~~~~~~~~~~ LD u-boot aarch64-linux-gnu-ld.bfd: fs/built-in.o: in function `sqfs_find_inode': /u-boot/fs/squashfs/sqfs_inode.c:126: undefined reference to `le32_to_cpu' aarch64-linux-gnu-ld.bfd: /u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' Segmentation fault make: *** [Makefile:1765: u-boot] Error 139 make: *** Deleting file 'u-boot'
When compiling U-Boot prior that commit, there is no error.
Simon and Tom: you have signed problematic mentioned commit. Could you please look at it?
On Fri, Feb 26, 2021 at 01:34:29PM +0100, Pali Rohár wrote:
Hello!
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
Here is console output:
fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’: fs/squashfs/sqfs_inode.c:121:18: warning: implicit declaration of function ‘le32_to_cpu’ [-Wimplicit-function-declaration] for (k = 0; k < le32_to_cpu(inode_count); k++) { ^~~~~~~~~~~ LD u-boot aarch64-linux-gnu-ld.bfd: fs/built-in.o: in function `sqfs_find_inode': /u-boot/fs/squashfs/sqfs_inode.c:126: undefined reference to `le32_to_cpu' aarch64-linux-gnu-ld.bfd: /u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' Segmentation fault make: *** [Makefile:1765: u-boot] Error 139 make: *** Deleting file 'u-boot'
When compiling U-Boot prior that commit, there is no error.
Simon and Tom: you have signed problematic mentioned commit. Could you please look at it?
Yes, that file probably needs <compiler.h>, please check.
On Friday 26 February 2021 07:51:53 Tom Rini wrote:
On Fri, Feb 26, 2021 at 01:34:29PM +0100, Pali Rohár wrote:
Hello!
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
Here is console output:
fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’: fs/squashfs/sqfs_inode.c:121:18: warning: implicit declaration of function ‘le32_to_cpu’ [-Wimplicit-function-declaration] for (k = 0; k < le32_to_cpu(inode_count); k++) { ^~~~~~~~~~~ LD u-boot aarch64-linux-gnu-ld.bfd: fs/built-in.o: in function `sqfs_find_inode': /u-boot/fs/squashfs/sqfs_inode.c:126: undefined reference to `le32_to_cpu' aarch64-linux-gnu-ld.bfd: /u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' Segmentation fault make: *** [Makefile:1765: u-boot] Error 139 make: *** Deleting file 'u-boot'
When compiling U-Boot prior that commit, there is no error.
Simon and Tom: you have signed problematic mentioned commit. Could you please look at it?
Yes, that file probably needs <compiler.h>, please check.
-- Tom
Perfect, including <compiler.h> fixed it!
On Friday 26 February 2021 13:54:40 Pali Rohár wrote:
On Friday 26 February 2021 07:51:53 Tom Rini wrote:
On Fri, Feb 26, 2021 at 01:34:29PM +0100, Pali Rohár wrote:
Hello!
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
Here is console output:
fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’: fs/squashfs/sqfs_inode.c:121:18: warning: implicit declaration of function ‘le32_to_cpu’ [-Wimplicit-function-declaration] for (k = 0; k < le32_to_cpu(inode_count); k++) { ^~~~~~~~~~~ LD u-boot aarch64-linux-gnu-ld.bfd: fs/built-in.o: in function `sqfs_find_inode': /u-boot/fs/squashfs/sqfs_inode.c:126: undefined reference to `le32_to_cpu' aarch64-linux-gnu-ld.bfd: /u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' Segmentation fault make: *** [Makefile:1765: u-boot] Error 139 make: *** Deleting file 'u-boot'
When compiling U-Boot prior that commit, there is no error.
Simon and Tom: you have signed problematic mentioned commit. Could you please look at it?
Yes, that file probably needs <compiler.h>, please check.
-- Tom
Perfect, including <compiler.h> fixed it!
Simon, or Tom, are you going to fix this issue in U-Boot master branch? I think patch needs Fixes: tag with mentioned commit as it broke compilation of U-Boot.
On Tue, Mar 02, 2021 at 05:59:47PM +0100, Pali Rohár wrote:
On Friday 26 February 2021 13:54:40 Pali Rohár wrote:
On Friday 26 February 2021 07:51:53 Tom Rini wrote:
On Fri, Feb 26, 2021 at 01:34:29PM +0100, Pali Rohár wrote:
Hello!
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
Here is console output:
fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’: fs/squashfs/sqfs_inode.c:121:18: warning: implicit declaration of function ‘le32_to_cpu’ [-Wimplicit-function-declaration] for (k = 0; k < le32_to_cpu(inode_count); k++) { ^~~~~~~~~~~ LD u-boot aarch64-linux-gnu-ld.bfd: fs/built-in.o: in function `sqfs_find_inode': /u-boot/fs/squashfs/sqfs_inode.c:126: undefined reference to `le32_to_cpu' aarch64-linux-gnu-ld.bfd: /u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' Segmentation fault make: *** [Makefile:1765: u-boot] Error 139 make: *** Deleting file 'u-boot'
When compiling U-Boot prior that commit, there is no error.
Simon and Tom: you have signed problematic mentioned commit. Could you please look at it?
Yes, that file probably needs <compiler.h>, please check.
-- Tom
Perfect, including <compiler.h> fixed it!
Simon, or Tom, are you going to fix this issue in U-Boot master branch? I think patch needs Fixes: tag with mentioned commit as it broke compilation of U-Boot.
No, I was assuming you would submit a patch since nothing in mainline atm is tripping on this issue.
On Tuesday 02 March 2021 16:27:27 Tom Rini wrote:
On Tue, Mar 02, 2021 at 05:59:47PM +0100, Pali Rohár wrote:
On Friday 26 February 2021 13:54:40 Pali Rohár wrote:
On Friday 26 February 2021 07:51:53 Tom Rini wrote:
On Fri, Feb 26, 2021 at 01:34:29PM +0100, Pali Rohár wrote:
Hello!
Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header") broke compilation of squashfs filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
Here is console output:
fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’: fs/squashfs/sqfs_inode.c:121:18: warning: implicit declaration of function ‘le32_to_cpu’ [-Wimplicit-function-declaration] for (k = 0; k < le32_to_cpu(inode_count); k++) { ^~~~~~~~~~~ LD u-boot aarch64-linux-gnu-ld.bfd: fs/built-in.o: in function `sqfs_find_inode': /u-boot/fs/squashfs/sqfs_inode.c:126: undefined reference to `le32_to_cpu' aarch64-linux-gnu-ld.bfd: /u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu' Segmentation fault make: *** [Makefile:1765: u-boot] Error 139 make: *** Deleting file 'u-boot'
When compiling U-Boot prior that commit, there is no error.
Simon and Tom: you have signed problematic mentioned commit. Could you please look at it?
Yes, that file probably needs <compiler.h>, please check.
-- Tom
Perfect, including <compiler.h> fixed it!
Simon, or Tom, are you going to fix this issue in U-Boot master branch? I think patch needs Fixes: tag with mentioned commit as it broke compilation of U-Boot.
No, I was assuming you would submit a patch since nothing in mainline atm is tripping on this issue.
Ok, I have done it, I sent patch ML. Please review it.
participants (2)
-
Pali Rohár -
Tom Rini