[U-Boot] [PATCH 1/2] patman: Use reverse order for changelog
Specially when many revisions are need for a patchset, the most interesting information is about the last set of changes so we output the changelog in reverse order to easy identification of most recent change set.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br --- tools/patman/series.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/patman/series.py b/tools/patman/series.py index 7829dc7..dddfab4 100644 --- a/tools/patman/series.py +++ b/tools/patman/series.py @@ -145,18 +145,18 @@ class Series(dict): Return: The change log as a list of strings, one per line
+ Changes in v2: + - Jog the dial back closer to the widget + Changes in v1: - Fix the widget - Jog the dial
- Changes in v2: - - Jog the dial back closer to the widget - etc. """ final = [] need_blank = False - for change in sorted(self.changes): + for change in sorted(self.changes, reverse=True): out = [] for this_commit, text in self.changes[change]: if commit and this_commit != commit:
When writting the changelog of a series it is expect that this order is going to be respected.
The sorting can make it out of context of the order had a meaning for the reader so this patch remove the sort of items.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br --- tools/patman/series.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/patman/series.py b/tools/patman/series.py index dddfab4..34eea92 100644 --- a/tools/patman/series.py +++ b/tools/patman/series.py @@ -164,7 +164,7 @@ class Series(dict): if text not in out: out.append(text) if out: - out = ['Changes in v%d:' % change] + sorted(out) + out = ['Changes in v%d:' % change] + out if need_blank: out = [''] + out final += out
Dear Otavio Salvador,
In message 1345311965-24414-2-git-send-email-otavio@ossystems.com.br you wrote:
When writting the changelog of a series it is expect that this order
s/writting/writing/
s/it is expect/it is expected/
is going to be respected.
What exactly do you mean here by "this order" ?
The sorting can make it out of context of the order had a meaning for the reader so this patch remove the sort of items.
I cannot really parse this, not even if I assume we should s/of/if/ here. What exactly do you mean?
Best regards,
Wolfgang Denk
On Sun, Sep 2, 2012 at 11:30 AM, Wolfgang Denk wd@denx.de wrote:
Dear Otavio Salvador,
In message 1345311965-24414-2-git-send-email-otavio@ossystems.com.br you wrote:
When writting the changelog of a series it is expect that this order
s/writting/writing/
s/it is expect/it is expected/
is going to be respected.
What exactly do you mean here by "this order" ?
The sorting can make it out of context of the order had a meaning for the reader so this patch remove the sort of items.
I cannot really parse this, not even if I assume we should s/of/if/ here. What exactly do you mean?
Looks like Otavio meant to do the same as this patch from Ilya Yanok, which is now applied:
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=73fe07a79a65600acce3d96c0b0d...
Regards,
Fabio Estevam
Dear Fabio,
In message CAOMZO5De1v6uTSQRBQcg3Fb=ve6EbOg+81RNHddh1AtgvkVvxg@mail.gmail.com you wrote:
I cannot really parse this, not even if I assume we should s/of/if/ here. What exactly do you mean?
Looks like Otavio meant to do the same as this patch from Ilya Yanok, which is now applied:
This is my guess, too. But I'd like to be sure.
Best regards,
Wolfgang Denk
On Sun, Sep 2, 2012 at 5:23 PM, Wolfgang Denk wd@denx.de wrote:
Dear Fabio,
In message CAOMZO5De1v6uTSQRBQcg3Fb=ve6EbOg+81RNHddh1AtgvkVvxg@mail.gmail.com you wrote:
I cannot really parse this, not even if I assume we should s/of/if/ here. What exactly do you mean?
Looks like Otavio meant to do the same as this patch from Ilya Yanok, which is now applied:
This is my guess, too. But I'd like to be sure.
Yes; you're both right. Same fix but I didn't change the uniq handle as I think it is nice to have.
On Sat, Aug 18, 2012 at 10:46 AM, Otavio Salvador otavio@ossystems.com.br wrote:
Specially when many revisions are need for a patchset, the most interesting information is about the last set of changes so we output the changelog in reverse order to easy identification of most recent change set.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br
Acked-by: Simon Glass sjg@chromium.org
tools/patman/series.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/patman/series.py b/tools/patman/series.py index 7829dc7..dddfab4 100644 --- a/tools/patman/series.py +++ b/tools/patman/series.py @@ -145,18 +145,18 @@ class Series(dict): Return: The change log as a list of strings, one per line
Changes in v2:- Jog the dial back closer to the widgetChanges in v1: - Fix the widget - Jog the dial
Changes in v2:- Jog the dial back closer to the widgetetc. """ final = [] need_blank = Falsefor change in sorted(self.changes):
for change in sorted(self.changes, reverse=True): out = [] for this_commit, text in self.changes[change]: if commit and this_commit != commit:-- 1.7.10.4
On Sat, Aug 18, 2012 at 07:46:04AM -0000, Otavio Salvador wrote:
Specially when many revisions are need for a patchset, the most interesting information is about the last set of changes so we output the changelog in reverse order to easy identification of most recent change set.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Acked-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (5)
-
Fabio Estevam -
Otavio Salvador -
Simon Glass -
Tom Rini -
Wolfgang Denk