[U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space
continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer from the same problem.
Signed-off-by: Kim Phillips kim.phillips@freescale.com CC: Scott Wood scottwood@freescale.com --- include/configs/MPC8349EMDS.h | 3 ++- include/configs/MPC8349ITX.h | 3 ++- include/configs/MVBLM7.h | 3 ++- include/configs/SIMPC8313.h | 2 +- include/configs/sbc8349.h | 3 ++- 5 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index b3c0e2d..0d1d663 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -683,7 +683,8 @@ #define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE) #define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0) diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h index 38a7386..ab6fe55 100644 --- a/include/configs/MPC8349ITX.h +++ b/include/configs/MPC8349ITX.h @@ -615,7 +615,8 @@ boards, we say we have two, but don't display a message if we find only one. */ #define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE) #define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L 0 diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h index 4ecf806..b321825 100644 --- a/include/configs/MVBLM7.h +++ b/include/configs/MVBLM7.h @@ -360,7 +360,8 @@ #define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* stack in DCACHE 0xFDF00000 & FLASH @ 0xFF800000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE) #define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP) #define CONFIG_SYS_IBAT7L 0 #define CONFIG_SYS_IBAT7U 0 diff --git a/include/configs/SIMPC8313.h b/include/configs/SIMPC8313.h index e20527e..79582e1 100644 --- a/include/configs/SIMPC8313.h +++ b/include/configs/SIMPC8313.h @@ -437,7 +437,7 @@ #define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_GUARDEDSTORAGE) #define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0) diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h index f476e3e..42033ac 100644 --- a/include/configs/sbc8349.h +++ b/include/configs/sbc8349.h @@ -605,7 +605,8 @@ #define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE) #define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
Dear Kim Phillips,
In message 20090330175628.602dae2f.kim.phillips@freescale.com you wrote:
continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer from the same problem.
Signed-off-by: Kim Phillips kim.phillips@freescale.com CC: Scott Wood scottwood@freescale.com
Umm... what does that mean: "continuation of commit a5d7049a4"?
If these commits belong together logically, you must not split them apart.
Best regards,
Wolfgang Denk
Wolfgang Denk wrote:
Dear Kim Phillips,
In message 20090330175628.602dae2f.kim.phillips@freescale.com you wrote:
continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer from the same problem.
Signed-off-by: Kim Phillips kim.phillips@freescale.com CC: Scott Wood scottwood@freescale.com
Umm... what does that mean: "continuation of commit a5d7049a4"?
If these commits belong together logically, you must not split them apart.
There's no bisectability problem; it's just similar bugs being fixed on other boards.
-Scott
Dear Scott Wood,
In message 49D28575.1040303@freescale.com you wrote:
Umm... what does that mean: "continuation of commit a5d7049a4"?
If these commits belong together logically, you must not split them apart.
There's no bisectability problem; it's just similar bugs being fixed on other boards.
why not fix them in a single commit, then?
Best regards,
Wolfgang Denk
On Tue, 31 Mar 2009 23:24:42 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Scott Wood,
In message 49D28575.1040303@freescale.com you wrote:
Umm... what does that mean: "continuation of commit a5d7049a4"?
If these commits belong together logically, you must not split them apart.
There's no bisectability problem; it's just similar bugs being fixed on other boards.
why not fix them in a single commit, then?
this sounds reasonable - it gets rid of a moot commit, saving bisection its traversal. I'll add this to Scott's original patch and explain what I did between the s-o-b lines.
Kim
participants (3)
-
Kim Phillips -
Scott Wood -
Wolfgang Denk