On 16/11/2012 17:46, Benoît Thébaudeau wrote:

The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance selection bit.

This issue has been reported by Eric Bénard eric@eukrea.com and fixed by Christoph Fritz chf.fritz@googlemail.com on Linux, from which these #define-s had been copied.

Signed-off-by: Benoît Thébaudeau benoit.thebaudeau@advansee.com Cc: Stefano Babic sbabic@denx.de Cc: Marek Vasut marex@denx.de

---

.../drivers/usb/host/ehci-mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c index 7c5f71c..352ad86 100644 --- u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c +++ u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c @@ -37,7 +37,7 @@ #define MX25_H1_SIC_SHIFT 21 #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT) #define MX25_H1_PP_BIT (1 << 18) -#define MX25_H1_PM_BIT (1 << 8) +#define MX25_H1_PM_BIT (1 << 16) #define MX25_H1_IPPUE_UP_BIT (1 << 7) #define MX25_H1_IPPUE_DOWN_BIT (1 << 6) #define MX25_H1_TLL_BIT (1 << 5)

Applied to u-boot-imx, thanks.

Best regards, Stefano Babic