[U-Boot] [PATCH V2 0/2] bootstage: fix fdt stashing and reporting
In arm, it seems there is a discrepancy in the code. The fdt stashing code uses an undefined variable.
In powerpc, implement fdt stashing and pre-boot reporting of bootstage timing data.
Fixed a typo in the commit log.
Rommel G Custodio (2): bootstage: arm: fix fdt stashing code bootstage: powerpc: support fdt stash and reporting
arch/arm/lib/bootm.c | 3 +-- arch/powerpc/lib/bootm.c | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-)
The conditional is using a variable that is not defined.
Signed-off-by: Rommel G Custodio sessyargc+u-boot@gmail.com --- arch/arm/lib/bootm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index a8295bf..7f1b2e0 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -71,8 +71,7 @@ static void announce_and_cleanup(int fake) "(fake run for tracing)" : ""); bootstage_mark_name(BOOTSTAGE_ID_BOOTM_HANDOFF, "start_kernel"); #ifdef CONFIG_BOOTSTAGE_FDT - if (flag == BOOTM_STATE_OS_FAKE_GO) - bootstage_fdt_add_report(); + bootstage_fdt_add_report(); #endif #ifdef CONFIG_BOOTSTAGE_REPORT bootstage_report();
Hi Rommel,
On Thu, 20 Feb 2014 00:16:56 +0900, Rommel G Custodio sessyargc@gmail.com wrote:
The conditional is using a variable that is not defined.
Signed-off-by: Rommel G Custodio sessyargc+u-boot@gmail.com
arch/arm/lib/bootm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index a8295bf..7f1b2e0 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -71,8 +71,7 @@ static void announce_and_cleanup(int fake) "(fake run for tracing)" : ""); bootstage_mark_name(BOOTSTAGE_ID_BOOTM_HANDOFF, "start_kernel"); #ifdef CONFIG_BOOTSTAGE_FDT
- if (flag == BOOTM_STATE_OS_FAKE_GO)
bootstage_fdt_add_report();
- bootstage_fdt_add_report();
#endif #ifdef CONFIG_BOOTSTAGE_REPORT bootstage_report();
Applied to u-boot-arm/master, thanks!
Amicalement,
This implements stashing of bootstage timing data to FDT and automatic timing reporting. To enable define CONFIG_BOOTSTAGE_FDT and CONFIG_BOOTSTAGE_REPORT respectively.
Signed-off-by: Rommel G Custodio sessyargc+u-boot@gmail.com --- arch/powerpc/lib/bootm.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/lib/bootm.c b/arch/powerpc/lib/bootm.c index 41fc8f7..1e36bec 100644 --- a/arch/powerpc/lib/bootm.c +++ b/arch/powerpc/lib/bootm.c @@ -54,6 +54,13 @@ static void boot_jump_linux(bootm_headers_t *images)
bootstage_mark(BOOTSTAGE_ID_RUN_OS);
+#ifdef CONFIG_BOOTSTAGE_FDT + bootstage_fdt_add_report(); +#endif +#ifdef CONFIG_BOOTSTAGE_REPORT + bootstage_report(); +#endif + #if defined(CONFIG_SYS_INIT_RAM_LOCK) && !defined(CONFIG_E500) unlock_ram_in_cache(); #endif
On 02/19/2014 07:16 AM, Rommel G Custodio wrote:
This implements stashing of bootstage timing data to FDT and automatic timing reporting. To enable define CONFIG_BOOTSTAGE_FDT and CONFIG_BOOTSTAGE_REPORT respectively.
Signed-off-by: Rommel G Custodio sessyargc+u-boot@gmail.com
Applied to u-boot-mpc85xx/master. Thanks.
York
participants (3)
-
Albert ARIBAUD -
Rommel G Custodio -
York Sun