[U-Boot-Users] [PATCH] Fix show_boot_progress prototype
in commit fad634071 "make show_boot_progress () weak." show_boot_progress is supposed to be declared as weak but declare as inline instead of.
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/include/common.h b/include/common.h index 8630780..eeb6686 100644 --- a/include/common.h +++ b/include/common.h @@ -661,7 +661,7 @@ int pcmcia_init (void); /* * Board-specific Platform code can reimplement show_boot_progress () if needed */ -void inline show_boot_progress (int val); +void __attribute__((weak)) show_boot_progress (int val);
#ifdef CONFIG_INIT_CRITICAL #error CONFIG_INIT_CRITICAL is deprecated!
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/common/image.c b/common/image.c index d218f2f..ac033df 100644 --- a/common/image.c +++ b/common/image.c @@ -366,12 +366,12 @@ static void __image_print_contents (image_header_t *hdr, const char *p) } }
-inline void image_print_contents (image_header_t *hdr) +void image_print_contents (image_header_t *hdr) { __image_print_contents (hdr, " "); }
-inline void image_print_contents_noindent (image_header_t *hdr) +void image_print_contents_noindent (image_header_t *hdr) { __image_print_contents (hdr, ""); } diff --git a/include/image.h b/include/image.h index 60fdb2b..491d1cb 100644 --- a/include/image.h +++ b/include/image.h @@ -392,8 +392,8 @@ ulong image_multi_count (image_header_t *hdr); void image_multi_getimg (image_header_t *hdr, ulong idx, ulong *data, ulong *len);
-inline void image_print_contents (image_header_t *hdr); -inline void image_print_contents_noindent (image_header_t *hdr); +void image_print_contents (image_header_t *hdr); +void image_print_contents_noindent (image_header_t *hdr);
#ifndef USE_HOSTCC static inline int image_check_target_arch (image_header_t *hdr)
In message 1208623614-26957-1-git-send-email-plagnioj@jcrosoft.com you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
Would you please explain *why* you are doing this?
Best regards,
Wolfgang Denk
Jean-Christophe PLAGNIOL-VILLARD wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
Hi Jean-Christophe,
Please have a look at my patch:
Date: Fri, 18 Apr 2008 12:39:23 +0200 Subject: [U-Boot-Users] [PATCH v2] Memory footprint optimizations
It rearranges image printing functions, in particular it removes the image_print_contents_noindent() function and changes the implementation of image_print_contents() making it non-inline among other things. So it seems that your changes will not be necessary eventually (apart from the rationale for them, which Wolfgang has already asked about).
Regards, Bartlomiej
In message 1208620760-23645-1-git-send-email-plagnioj@jcrosoft.com you wrote:
in commit fad634071 "make show_boot_progress () weak." show_boot_progress is supposed to be declared as weak but declare as inline instead of.
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/include/common.h b/include/common.h index 8630780..eeb6686 100644
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Bartlomiej Sieka -
Jean-Christophe PLAGNIOL-VILLARD -
Wolfgang Denk