[PATCH v1 0/2] power: pmic: add TPS65913 support
Existing PALMAS PMIC driver is fully compatible with TI TPS65913 PMIC found in many Tegra 4 devices, like Tegra Note 7 and ASUS TF701T. Add TPS65913 dts compatible with TPS659038 data.
Without regulator_autoset PALMAS regulators are just "requested" without actual initial setup (device tree is completely ignored). This causes major issue since voltage is usually set on probing and rarely is changed. Drivers which change voltage will also assume that initial voltage was already set and this was not the case.
Svyatoslav Ryhel (2): power: pmic: support TI TPS65913 PMIC power: regulator: palmas: set up voltage on probe
drivers/power/pmic/palmas.c | 1 + drivers/power/regulator/palmas_regulator.c | 4 ++++ 2 files changed, 5 insertions(+)
Existing PALMAS PMIC driver is fully compatible with TI TPS65913 PMIC found in many Tegra 4 devices, like Tegra Note 7 and ASUS TF701T. TPS65913 shares same structure of regulators like TPS659038 so data can be reused.
Tested-by: Svyatoslav Ryhel clamor95@gmail.com # NVIDIA Tegratab Signed-off-by: Svyatoslav Ryhel clamor95@gmail.com --- drivers/power/pmic/palmas.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/power/pmic/palmas.c b/drivers/power/pmic/palmas.c index 6080cbff0b..d6eb9cb433 100644 --- a/drivers/power/pmic/palmas.c +++ b/drivers/power/pmic/palmas.c @@ -87,6 +87,7 @@ static struct dm_pmic_ops palmas_ops = {
static const struct udevice_id palmas_ids[] = { { .compatible = "ti,tps659038", .data = TPS659038 }, + { .compatible = "ti,tps65913" , .data = TPS659038 }, { .compatible = "ti,tps65917" , .data = TPS65917 }, { } };
Without this patch PALMAS regulators are just "requested" without actual initial setup (device tree values are completely ignored). This causes major issue since voltage is usually set on probing and rarely is changed. Drivers which change voltage assume that initial voltage was already set and this was not the case.
Tested-by: Svyatoslav Ryhel clamor95@gmail.com Signed-off-by: Svyatoslav Ryhel clamor95@gmail.com --- drivers/power/regulator/palmas_regulator.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/power/regulator/palmas_regulator.c b/drivers/power/regulator/palmas_regulator.c index 3c4eb83be7..cc292f6946 100644 --- a/drivers/power/regulator/palmas_regulator.c +++ b/drivers/power/regulator/palmas_regulator.c @@ -316,6 +316,8 @@ static int palmas_ldo_probe(struct udevice *dev) } }
+ regulator_autoset(dev); + return 0; }
@@ -423,6 +425,8 @@ static int palmas_smps_probe(struct udevice *dev) printf("Invalid PMIC ID\n"); }
+ regulator_autoset(dev); + return 0; }
participants (1)
-
Svyatoslav Ryhel