[U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state
Hello,
cppcheck reports:
[net/eth.c:64]: (error) Uninitialized variable: skip_state
can you please have a look? Thanks!
Best regards,
Wolfgang Denk
On Thu, Nov 06, 2014 at 01:37:23PM +0100, Wolfgang Denk wrote:
Hello,
cppcheck reports:
[net/eth.c:64]: (error) Uninitialized variable: skip_state
can you please have a look? Thanks!
Dense code, like cmd_ini.c my cppcheck is OK and looking at the code manually I think it's fine too: return ((skip_state = getenv(enetvar)) != NULL);
Dear Tom Rini,
In message 20141106164628.GR24724@bill-the-cat you wrote:
[net/eth.c:64]: (error) Uninitialized variable: skip_state
Dense code, like cmd_ini.c my cppcheck is OK and looking at the code manually I think it's fine too: return ((skip_state = getenv(enetvar)) != NULL);
Looks OK to me, too, but recent versions of cppcheck spew this error.
Best regards,
Wolfgang Denk
On Thu, Nov 06, 2014 at 07:12:55PM +0100, Wolfgang Denk wrote:
Dear Tom Rini,
In message 20141106164628.GR24724@bill-the-cat you wrote:
[net/eth.c:64]: (error) Uninitialized variable: skip_state
Dense code, like cmd_ini.c my cppcheck is OK and looking at the code manually I think it's fine too: return ((skip_state = getenv(enetvar)) != NULL);
Looks OK to me, too, but recent versions of cppcheck spew this error.
File a bug back with them then? I do like what cppcheck is doing 'tho, I poked some of the sandbox ones as well and they're real.
participants (2)
-
Tom Rini -
Wolfgang Denk