[U-Boot] [PATCH v2] sandbox: Build with -fPIC

Sandbox is not a real bootloader and it does require a position independent code to be supported.
Thus, build it with -fPIC explicitly.
Fixes: 16940f720f9b ("Makefile: Don't generate position independent code") Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Reported-by: Simon Glass sjg@chromium.org Tested-by: Bin Meng bmeng.cn@gmail.com ---
- rebased on top of latest u-boot/master - added Bin's Tb tag
arch/sandbox/config.mk | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/sandbox/config.mk b/arch/sandbox/config.mk index 2babcde881..95f9e3ff63 100644 --- a/arch/sandbox/config.mk +++ b/arch/sandbox/config.mk @@ -3,6 +3,7 @@
PLATFORM_CPPFLAGS += -D__SANDBOX__ -U_FORTIFY_SOURCE PLATFORM_CPPFLAGS += -DCONFIG_ARCH_MAP_SYSMEM +PLATFORM_CPPFLAGS += -fPIC PLATFORM_LIBS += -lrt
# Define this to avoid linking with SDL, which requires SDL libraries

On 3 September 2018 at 11:08, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Sandbox is not a real bootloader and it does require a position independent code to be supported.
Thus, build it with -fPIC explicitly.
Fixes: 16940f720f9b ("Makefile: Don't generate position independent code") Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Reported-by: Simon Glass sjg@chromium.org Tested-by: Bin Meng bmeng.cn@gmail.com
- rebased on top of latest u-boot/master
- added Bin's Tb tag
arch/sandbox/config.mk | 1 + 1 file changed, 1 insertion(+)
Acked-by: Simon Glass sjg@chromium.org Tested-by: Simon Glass sjg@chromium.org

On 14 September 2018 at 19:03, Simon Glass sjg@chromium.org wrote:
On 3 September 2018 at 11:08, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Sandbox is not a real bootloader and it does require a position independent code to be supported.
Thus, build it with -fPIC explicitly.
Fixes: 16940f720f9b ("Makefile: Don't generate position independent code") Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Reported-by: Simon Glass sjg@chromium.org Tested-by: Bin Meng bmeng.cn@gmail.com
- rebased on top of latest u-boot/master
- added Bin's Tb tag
arch/sandbox/config.mk | 1 + 1 file changed, 1 insertion(+)
Acked-by: Simon Glass sjg@chromium.org Tested-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, and now in mainline, thanks!
participants (2)
-
Andy Shevchenko
-
Simon Glass